diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2018-05-03 10:25:52 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2018-07-03 07:12:57 -0400 |
commit | 418cc6ca06071e7b7d75c0d525d80a6f49a763d6 (patch) | |
tree | 12a8b278e184d4b5350248a47ce2f5208ea8a100 /drivers/dma-buf/dma-fence.c | |
parent | 070473bcf703366e9acb14e172d5b6563cc07a26 (diff) |
dma-fence: Make ->wait callback optional
Almost everyone uses dma_fence_default_wait.
v2: Also remove the BUG_ON(!ops->wait) (Chris).
Reviewed-by: Christian König <christian.koenig@amd.com> (v1)
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Link: https://patchwork.freedesktop.org/patch/msgid/20180503142603.28513-5-daniel.vetter@ffwll.ch
Diffstat (limited to 'drivers/dma-buf/dma-fence.c')
-rw-r--r-- | drivers/dma-buf/dma-fence.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index ea343f992112..7a92f85a4cec 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c | |||
@@ -158,7 +158,10 @@ dma_fence_wait_timeout(struct dma_fence *fence, bool intr, signed long timeout) | |||
158 | return -EINVAL; | 158 | return -EINVAL; |
159 | 159 | ||
160 | trace_dma_fence_wait_start(fence); | 160 | trace_dma_fence_wait_start(fence); |
161 | ret = fence->ops->wait(fence, intr, timeout); | 161 | if (fence->ops->wait) |
162 | ret = fence->ops->wait(fence, intr, timeout); | ||
163 | else | ||
164 | ret = dma_fence_default_wait(fence, intr, timeout); | ||
162 | trace_dma_fence_wait_end(fence); | 165 | trace_dma_fence_wait_end(fence); |
163 | return ret; | 166 | return ret; |
164 | } | 167 | } |
@@ -556,8 +559,7 @@ dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops, | |||
556 | spinlock_t *lock, u64 context, unsigned seqno) | 559 | spinlock_t *lock, u64 context, unsigned seqno) |
557 | { | 560 | { |
558 | BUG_ON(!lock); | 561 | BUG_ON(!lock); |
559 | BUG_ON(!ops || !ops->wait || | 562 | BUG_ON(!ops || !ops->get_driver_name || !ops->get_timeline_name); |
560 | !ops->get_driver_name || !ops->get_timeline_name); | ||
561 | 563 | ||
562 | kref_init(&fence->refcount); | 564 | kref_init(&fence->refcount); |
563 | fence->ops = ops; | 565 | fence->ops = ops; |