diff options
author | Dave Jiang <dave.jiang@intel.com> | 2017-02-22 18:40:06 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-02-22 19:41:26 -0500 |
commit | f42003917b4569a2f4f0c79c35e1e3df2859f81a (patch) | |
tree | 93532f9f8deee9a6ad2f309e2edde57400a2e774 /drivers/dax | |
parent | d8a849e1bc123790bbbf1facba94452a3aef5736 (diff) |
mm, dax: change pmd_fault() to take only vmf parameter
pmd_fault() and related functions really only need the vmf parameter since
the additional parameters are all included in the vmf struct. Remove the
additional parameter and simplify pmd_fault() and friends.
Link: http://lkml.kernel.org/r/1484085142-2297-8-git-send-email-ross.zwisler@linux.intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/dax')
-rw-r--r-- | drivers/dax/dax.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c index a8833cc35697..18e9875f6277 100644 --- a/drivers/dax/dax.c +++ b/drivers/dax/dax.c | |||
@@ -472,8 +472,7 @@ static int dax_dev_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
472 | return rc; | 472 | return rc; |
473 | } | 473 | } |
474 | 474 | ||
475 | static int __dax_dev_pmd_fault(struct dax_dev *dax_dev, | 475 | static int __dax_dev_pmd_fault(struct dax_dev *dax_dev, struct vm_fault *vmf) |
476 | struct vm_area_struct *vma, struct vm_fault *vmf) | ||
477 | { | 476 | { |
478 | unsigned long pmd_addr = vmf->address & PMD_MASK; | 477 | unsigned long pmd_addr = vmf->address & PMD_MASK; |
479 | struct device *dev = &dax_dev->dev; | 478 | struct device *dev = &dax_dev->dev; |
@@ -482,7 +481,7 @@ static int __dax_dev_pmd_fault(struct dax_dev *dax_dev, | |||
482 | pgoff_t pgoff; | 481 | pgoff_t pgoff; |
483 | pfn_t pfn; | 482 | pfn_t pfn; |
484 | 483 | ||
485 | if (check_vma(dax_dev, vma, __func__)) | 484 | if (check_vma(dax_dev, vmf->vma, __func__)) |
486 | return VM_FAULT_SIGBUS; | 485 | return VM_FAULT_SIGBUS; |
487 | 486 | ||
488 | dax_region = dax_dev->region; | 487 | dax_region = dax_dev->region; |
@@ -497,7 +496,7 @@ static int __dax_dev_pmd_fault(struct dax_dev *dax_dev, | |||
497 | return VM_FAULT_SIGBUS; | 496 | return VM_FAULT_SIGBUS; |
498 | } | 497 | } |
499 | 498 | ||
500 | pgoff = linear_page_index(vma, pmd_addr); | 499 | pgoff = linear_page_index(vmf->vma, pmd_addr); |
501 | phys = pgoff_to_phys(dax_dev, pgoff, PMD_SIZE); | 500 | phys = pgoff_to_phys(dax_dev, pgoff, PMD_SIZE); |
502 | if (phys == -1) { | 501 | if (phys == -1) { |
503 | dev_dbg(dev, "%s: phys_to_pgoff(%#lx) failed\n", __func__, | 502 | dev_dbg(dev, "%s: phys_to_pgoff(%#lx) failed\n", __func__, |
@@ -507,22 +506,23 @@ static int __dax_dev_pmd_fault(struct dax_dev *dax_dev, | |||
507 | 506 | ||
508 | pfn = phys_to_pfn_t(phys, dax_region->pfn_flags); | 507 | pfn = phys_to_pfn_t(phys, dax_region->pfn_flags); |
509 | 508 | ||
510 | return vmf_insert_pfn_pmd(vma, vmf->address, vmf->pmd, pfn, | 509 | return vmf_insert_pfn_pmd(vmf->vma, vmf->address, vmf->pmd, pfn, |
511 | vmf->flags & FAULT_FLAG_WRITE); | 510 | vmf->flags & FAULT_FLAG_WRITE); |
512 | } | 511 | } |
513 | 512 | ||
514 | static int dax_dev_pmd_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | 513 | static int dax_dev_pmd_fault(struct vm_fault *vmf) |
515 | { | 514 | { |
516 | int rc; | 515 | int rc; |
517 | struct file *filp = vma->vm_file; | 516 | struct file *filp = vmf->vma->vm_file; |
518 | struct dax_dev *dax_dev = filp->private_data; | 517 | struct dax_dev *dax_dev = filp->private_data; |
519 | 518 | ||
520 | dev_dbg(&dax_dev->dev, "%s: %s: %s (%#lx - %#lx)\n", __func__, | 519 | dev_dbg(&dax_dev->dev, "%s: %s: %s (%#lx - %#lx)\n", __func__, |
521 | current->comm, (vmf->flags & FAULT_FLAG_WRITE) | 520 | current->comm, (vmf->flags & FAULT_FLAG_WRITE) |
522 | ? "write" : "read", vma->vm_start, vma->vm_end); | 521 | ? "write" : "read", |
522 | vmf->vma->vm_start, vmf->vma->vm_end); | ||
523 | 523 | ||
524 | rcu_read_lock(); | 524 | rcu_read_lock(); |
525 | rc = __dax_dev_pmd_fault(dax_dev, vma, vmf); | 525 | rc = __dax_dev_pmd_fault(dax_dev, vmf); |
526 | rcu_read_unlock(); | 526 | rcu_read_unlock(); |
527 | 527 | ||
528 | return rc; | 528 | return rc; |