summaryrefslogtreecommitdiffstats
path: root/drivers/crypto/mxs-dcp.c
diff options
context:
space:
mode:
authorStephen Boyd <swboyd@chromium.org>2019-07-30 14:15:05 -0400
committerHerbert Xu <herbert@gondor.apana.org.au>2019-08-09 01:11:38 -0400
commit514838e920d06f5c2ba56e9656107dfcbbb90219 (patch)
tree69b0ab1382bca331e0880ad6f335931fd25a1d7c /drivers/crypto/mxs-dcp.c
parentf26882a3475eb7b2c35fd3b1e291924161b1327d (diff)
crypto: drivers - Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: <linux-crypto@vger.kernel.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/mxs-dcp.c')
-rw-r--r--drivers/crypto/mxs-dcp.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c
index f1fa637cb029..bf8d2197bc11 100644
--- a/drivers/crypto/mxs-dcp.c
+++ b/drivers/crypto/mxs-dcp.c
@@ -994,16 +994,12 @@ static int mxs_dcp_probe(struct platform_device *pdev)
994 } 994 }
995 995
996 dcp_vmi_irq = platform_get_irq(pdev, 0); 996 dcp_vmi_irq = platform_get_irq(pdev, 0);
997 if (dcp_vmi_irq < 0) { 997 if (dcp_vmi_irq < 0)
998 dev_err(dev, "Failed to get IRQ: (%d)!\n", dcp_vmi_irq);
999 return dcp_vmi_irq; 998 return dcp_vmi_irq;
1000 }
1001 999
1002 dcp_irq = platform_get_irq(pdev, 1); 1000 dcp_irq = platform_get_irq(pdev, 1);
1003 if (dcp_irq < 0) { 1001 if (dcp_irq < 0)
1004 dev_err(dev, "Failed to get IRQ: (%d)!\n", dcp_irq);
1005 return dcp_irq; 1002 return dcp_irq;
1006 }
1007 1003
1008 sdcp = devm_kzalloc(dev, sizeof(*sdcp), GFP_KERNEL); 1004 sdcp = devm_kzalloc(dev, sizeof(*sdcp), GFP_KERNEL);
1009 if (!sdcp) 1005 if (!sdcp)