diff options
author | Frederic Danis <frederic.danis@linux.intel.com> | 2015-05-15 05:58:42 -0400 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2015-05-15 10:04:50 -0400 |
commit | 43b79209b5be533173eea08535558cf517b334ca (patch) | |
tree | 389f9badaca33a46c90c426c9ceea6b4d48b195f /drivers/bluetooth/btbcm.c | |
parent | b1f5cf0cae090dae9ac045670fec2d0c5253592a (diff) |
Bluetooth: btbcm: Fix calls to __hci_cmd_sync()
Remove test of command reply status as it is already performed by
__hci_cmd_sync().
__hci_cmd_sync_ev() function already returns an error if it got a
non-zero status either through a Command Complete or a Command
Status event.
For both of these events the status is collected up in the event
handlers called by hci_event_packet() and then passed as the second
parameter to req_complete_skb(). The req_complete_skb() callback in
turn is hci_req_sync_complete() for __hci_cmd_sync_ev() which stores
the status in hdev->req_result. The hdev->req_result is then further
converted through bt_to_errno() back in __hci_cmd_sync_ev().
Signed-off-by: Frederic Danis <frederic.danis@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth/btbcm.c')
-rw-r--r-- | drivers/bluetooth/btbcm.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c index 4bba86677adc..728fce38a5a2 100644 --- a/drivers/bluetooth/btbcm.c +++ b/drivers/bluetooth/btbcm.c | |||
@@ -55,12 +55,6 @@ int btbcm_check_bdaddr(struct hci_dev *hdev) | |||
55 | } | 55 | } |
56 | 56 | ||
57 | bda = (struct hci_rp_read_bd_addr *)skb->data; | 57 | bda = (struct hci_rp_read_bd_addr *)skb->data; |
58 | if (bda->status) { | ||
59 | BT_ERR("%s: BCM: Device address result failed (%02x)", | ||
60 | hdev->name, bda->status); | ||
61 | kfree_skb(skb); | ||
62 | return -bt_to_errno(bda->status); | ||
63 | } | ||
64 | 58 | ||
65 | /* The address 00:20:70:02:A0:00 indicates a BCM20702A0 controller | 59 | /* The address 00:20:70:02:A0:00 indicates a BCM20702A0 controller |
66 | * with no configured address. | 60 | * with no configured address. |