diff options
author | Alexander Sverdlin <alexander.sverdlin@gmail.com> | 2015-06-22 16:38:53 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-06-24 14:03:10 -0400 |
commit | c181fb3e723351e2f7a1f76b6c0627a4b8ad1723 (patch) | |
tree | 38b3c10bbb513fd795d166551a291e9fad852ee9 /drivers/base | |
parent | b953c0d234bc72e8489d3bf51a276c5c4ec85345 (diff) |
ACPI / OF: Rename of_node() and acpi_node() to to_of_node() and to_acpi_node()
Commit 8a0662d9 introduced of_node and acpi_node symbols in global namespace
but there were already ~63 of_node local variables or function parameters
(no single acpi_node though, but anyway).
After debugging undefined but used of_node local varible (which turned out
to reference static function of_node() instead) it became clear that the names
for the functions are too short and too generic for global scope.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/base')
-rw-r--r-- | drivers/base/property.c | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/drivers/base/property.c b/drivers/base/property.c index 1d0b116cae95..dfd4de69b67b 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c | |||
@@ -128,9 +128,9 @@ EXPORT_SYMBOL_GPL(device_property_present); | |||
128 | bool fwnode_property_present(struct fwnode_handle *fwnode, const char *propname) | 128 | bool fwnode_property_present(struct fwnode_handle *fwnode, const char *propname) |
129 | { | 129 | { |
130 | if (is_of_node(fwnode)) | 130 | if (is_of_node(fwnode)) |
131 | return of_property_read_bool(of_node(fwnode), propname); | 131 | return of_property_read_bool(to_of_node(fwnode), propname); |
132 | else if (is_acpi_node(fwnode)) | 132 | else if (is_acpi_node(fwnode)) |
133 | return !acpi_dev_prop_get(acpi_node(fwnode), propname, NULL); | 133 | return !acpi_dev_prop_get(to_acpi_node(fwnode), propname, NULL); |
134 | 134 | ||
135 | return !!pset_prop_get(to_pset(fwnode), propname); | 135 | return !!pset_prop_get(to_pset(fwnode), propname); |
136 | } | 136 | } |
@@ -285,10 +285,10 @@ EXPORT_SYMBOL_GPL(device_property_read_string); | |||
285 | ({ \ | 285 | ({ \ |
286 | int _ret_; \ | 286 | int _ret_; \ |
287 | if (is_of_node(_fwnode_)) \ | 287 | if (is_of_node(_fwnode_)) \ |
288 | _ret_ = OF_DEV_PROP_READ_ARRAY(of_node(_fwnode_), _propname_, \ | 288 | _ret_ = OF_DEV_PROP_READ_ARRAY(to_of_node(_fwnode_), _propname_, \ |
289 | _type_, _val_, _nval_); \ | 289 | _type_, _val_, _nval_); \ |
290 | else if (is_acpi_node(_fwnode_)) \ | 290 | else if (is_acpi_node(_fwnode_)) \ |
291 | _ret_ = acpi_dev_prop_read(acpi_node(_fwnode_), _propname_, \ | 291 | _ret_ = acpi_dev_prop_read(to_acpi_node(_fwnode_), _propname_, \ |
292 | _proptype_, _val_, _nval_); \ | 292 | _proptype_, _val_, _nval_); \ |
293 | else \ | 293 | else \ |
294 | _ret_ = pset_prop_read_array(to_pset(_fwnode_), _propname_, \ | 294 | _ret_ = pset_prop_read_array(to_pset(_fwnode_), _propname_, \ |
@@ -424,11 +424,11 @@ int fwnode_property_read_string_array(struct fwnode_handle *fwnode, | |||
424 | { | 424 | { |
425 | if (is_of_node(fwnode)) | 425 | if (is_of_node(fwnode)) |
426 | return val ? | 426 | return val ? |
427 | of_property_read_string_array(of_node(fwnode), propname, | 427 | of_property_read_string_array(to_of_node(fwnode), |
428 | val, nval) : | 428 | propname, val, nval) : |
429 | of_property_count_strings(of_node(fwnode), propname); | 429 | of_property_count_strings(to_of_node(fwnode), propname); |
430 | else if (is_acpi_node(fwnode)) | 430 | else if (is_acpi_node(fwnode)) |
431 | return acpi_dev_prop_read(acpi_node(fwnode), propname, | 431 | return acpi_dev_prop_read(to_acpi_node(fwnode), propname, |
432 | DEV_PROP_STRING, val, nval); | 432 | DEV_PROP_STRING, val, nval); |
433 | 433 | ||
434 | return pset_prop_read_array(to_pset(fwnode), propname, | 434 | return pset_prop_read_array(to_pset(fwnode), propname, |
@@ -455,9 +455,9 @@ int fwnode_property_read_string(struct fwnode_handle *fwnode, | |||
455 | const char *propname, const char **val) | 455 | const char *propname, const char **val) |
456 | { | 456 | { |
457 | if (is_of_node(fwnode)) | 457 | if (is_of_node(fwnode)) |
458 | return of_property_read_string(of_node(fwnode), propname, val); | 458 | return of_property_read_string(to_of_node(fwnode), propname, val); |
459 | else if (is_acpi_node(fwnode)) | 459 | else if (is_acpi_node(fwnode)) |
460 | return acpi_dev_prop_read(acpi_node(fwnode), propname, | 460 | return acpi_dev_prop_read(to_acpi_node(fwnode), propname, |
461 | DEV_PROP_STRING, val, 1); | 461 | DEV_PROP_STRING, val, 1); |
462 | 462 | ||
463 | return -ENXIO; | 463 | return -ENXIO; |
@@ -475,13 +475,13 @@ struct fwnode_handle *device_get_next_child_node(struct device *dev, | |||
475 | if (IS_ENABLED(CONFIG_OF) && dev->of_node) { | 475 | if (IS_ENABLED(CONFIG_OF) && dev->of_node) { |
476 | struct device_node *node; | 476 | struct device_node *node; |
477 | 477 | ||
478 | node = of_get_next_available_child(dev->of_node, of_node(child)); | 478 | node = of_get_next_available_child(dev->of_node, to_of_node(child)); |
479 | if (node) | 479 | if (node) |
480 | return &node->fwnode; | 480 | return &node->fwnode; |
481 | } else if (IS_ENABLED(CONFIG_ACPI)) { | 481 | } else if (IS_ENABLED(CONFIG_ACPI)) { |
482 | struct acpi_device *node; | 482 | struct acpi_device *node; |
483 | 483 | ||
484 | node = acpi_get_next_child(dev, acpi_node(child)); | 484 | node = acpi_get_next_child(dev, to_acpi_node(child)); |
485 | if (node) | 485 | if (node) |
486 | return acpi_fwnode_handle(node); | 486 | return acpi_fwnode_handle(node); |
487 | } | 487 | } |
@@ -500,7 +500,7 @@ EXPORT_SYMBOL_GPL(device_get_next_child_node); | |||
500 | void fwnode_handle_put(struct fwnode_handle *fwnode) | 500 | void fwnode_handle_put(struct fwnode_handle *fwnode) |
501 | { | 501 | { |
502 | if (is_of_node(fwnode)) | 502 | if (is_of_node(fwnode)) |
503 | of_node_put(of_node(fwnode)); | 503 | of_node_put(to_of_node(fwnode)); |
504 | } | 504 | } |
505 | EXPORT_SYMBOL_GPL(fwnode_handle_put); | 505 | EXPORT_SYMBOL_GPL(fwnode_handle_put); |
506 | 506 | ||