Merge tag 'pm-4.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

Pull power management updates from Rafael  Wysocki:
 "Again, the majority of changes go into the cpufreq subsystem, but
  there are no big features this time.  The cpufreq changes that stand
  out somewhat are the governor interface rework and improvements
  related to the handling of frequency tables.  Apart from those, there
  are fixes and new device/CPU IDs in drivers, cleanups and an
  improvement of the new schedutil governor.

  Next, there are some changes in the hibernation core, including a fix
  for a nasty problem related to the MONITOR/MWAIT usage by CPU offline
  during resume from hibernation, a few core improvements related to
  memory management during resume, a couple of additional debug features
  and cleanups.

  Finally, we have some fixes and cleanups in the devfreq subsystem,
  generic power domains framework improvements related to system
  suspend/resume, support for some new chips in intel_idle and in the
  power capping RAPL driver, a new version of the AnalyzeSuspend utility
  and some assorted fixes and cleanups.

  Specifics:

   - Rework the cpufreq governor interface to make it more
     straightforward and modify the conservative governor to avoid using
     transition notifications (Rafael Wysocki).

   - Rework the handling of frequency tables by the cpufreq core to make
     it more efficient (Viresh Kumar).

   - Modify the schedutil governor to reduce the number of wakeups it
     causes to occur in cases when the CPU frequency doesn't need to be
     changed (Steve Muckle, Viresh Kumar).

   - Fix some minor issues and clean up code in the cpufreq core and
     governors (Rafael Wysocki, Viresh Kumar).

   - Add Intel Broxton support to the intel_pstate driver (Srinivas
     Pandruvada).

   - Fix problems related to the config TDP feature and to the validity
     of the MSR_HWP_INTERRUPT register in intel_pstate (Jan Kiszka,
     Srinivas Pandruvada).

   - Make intel_pstate update the cpu_frequency tracepoint even if the
     frequency doesn't change to avoid confusing powertop (Rafael
     Wysocki).

   - Clean up the usage of __init/__initdata in intel_pstate, mark some
     of its internal variables as __read_mostly and drop an unused
     structure element from it (Jisheng Zhang, Carsten Emde).

   - Clean up the usage of some duplicate MSR symbols in intel_pstate
     and turbostat (Srinivas Pandruvada).

   - Update/fix the powernv, s3c24xx and mvebu cpufreq drivers (Akshay
     Adiga, Viresh Kumar, Ben Dooks).

   - Fix a regression (introduced during the 4.5 cycle) in the
     pcc-cpufreq driver by reverting the problematic commit (Andreas
     Herrmann).

   - Add support for Intel Denverton to intel_idle, clean up Broxton
     support in it and make it explicitly non-modular (Jacob Pan, Jan
     Beulich, Paul Gortmaker).

   - Add support for Denverton and Ivy Bridge server to the Intel RAPL
     power capping driver and make it more careful about the handing of
     MSRs that may not be present (Jacob Pan, Xiaolong Wang).

   - Fix resume from hibernation on x86-64 by making the CPU offline
     during resume avoid using MONITOR/MWAIT in the "play dead" loop
     which may lead to an inadvertent "revival" of a "dead" CPU and a
     page fault leading to a kernel crash from it (Rafael Wysocki).

   - Make memory management during resume from hibernation more
     straightforward (Rafael Wysocki).

   - Add debug features that should help to detect problems related to
     hibernation and resume from it (Rafael Wysocki, Chen Yu).

   - Clean up hibernation core somewhat (Rafael Wysocki).

   - Prevent KASAN from instrumenting the hibernation core which leads
     to large numbers of false-positives from it (James Morse).

   - Prevent PM (hibernate and suspend) notifiers from being called
     during the cleanup phase if they have not been called during the
     corresponding preparation phase which is possible if one of the
     other notifiers returns an error at that time (Lianwei Wang).

   - Improve suspend-related debug printout in the tasks freezer and
     clean up suspend-related console handling (Roger Lu, Borislav
     Petkov).

   - Update the AnalyzeSuspend script in the kernel sources to version
     4.2 (Todd Brandt).

   - Modify the generic power domains framework to make it handle system
     suspend/resume better (Ulf Hansson).

   - Make the runtime PM framework avoid resuming devices synchronously
     when user space changes the runtime PM settings for them and
     improve its error reporting (Rafael Wysocki, Linus Walleij).

   - Fix error paths in devfreq drivers (exynos, exynos-ppmu,
     exynos-bus) and in the core, make some devfreq code explicitly
     non-modular and change some of it into tristate (Bartlomiej
     Zolnierkiewicz, Peter Chen, Paul Gortmaker).

   - Add DT support to the generic PM clocks management code and make it
     export some more symbols (Jon Hunter, Paul Gortmaker).

   - Make the PCI PM core code slightly more robust against possible
     driver errors (Andy Shevchenko).

   - Make it possible to change DESTDIR and PREFIX in turbostat (Andy
     Shevchenko)"

* tag 'pm-4.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: (89 commits)
  Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency"
  PM / hibernate: Introduce test_resume mode for hibernation
  cpufreq: export cpufreq_driver_resolve_freq()
  cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()
  PCI / PM: check all fields in pci_set_platform_pm()
  cpufreq: acpi-cpufreq: use cached frequency mapping when possible
  cpufreq: schedutil: map raw required frequency to driver frequency
  cpufreq: add cpufreq_driver_resolve_freq()
  cpufreq: intel_pstate: Check cpuid for MSR_HWP_INTERRUPT
  intel_pstate: Update cpu_frequency tracepoint every time
  cpufreq: intel_pstate: clean remnant struct element
  PM / tools: scripts: AnalyzeSuspend v4.2
  x86 / hibernate: Use hlt_play_dead() when resuming from hibernation
  cpufreq: powernv: Replacing pstate_id with frequency table index
  intel_pstate: Fix MSR_CONFIG_TDP_x addressing in core_get_max_pstate()
  PM / hibernate: Image data protection during restoration
  PM / hibernate: Add missing braces in __register_nosave_region()
  PM / hibernate: Clean up comments in snapshot.c
  PM / hibernate: Clean up function headers in snapshot.c
  PM / hibernate: Add missing braces in hibernate_setup()
  ...

3 files changed, 109 insertions, 250 deletions

diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 3657ac1cb801..8e2e4757adcb 100644
--- a/drivers/base/power/clock_ops.c
+++ b/drivers/base/power/clock_ops.c
@@ -121,6 +121,7 @@ int pm_clk_add(struct device *dev, const char *con_id)
 {
         return __pm_clk_add(dev, con_id, NULL);
 }
+EXPORT_SYMBOL_GPL(pm_clk_add);
 
 /**
  * pm_clk_add_clk - Start using a device clock for power management.
@@ -136,9 +137,42 @@ int pm_clk_add_clk(struct device *dev, struct clk *clk)
 {
         return __pm_clk_add(dev, NULL, clk);
 }
+EXPORT_SYMBOL_GPL(pm_clk_add_clk);
 
 
 /**
+ * of_pm_clk_add_clk - Start using a device clock for power management.
+ * @dev: Device whose clock is going to be used for power management.
+ * @name: Name of clock that is going to be used for power management.
+ *
+ * Add the clock described in the 'clocks' device-tree node that matches
+ * with the 'name' provided, to the list of clocks used for the power
+ * management of @dev. On success, returns 0. Returns a negative error
+ * code if the clock is not found or cannot be added.
+ */
+int of_pm_clk_add_clk(struct device *dev, const char *name)
+{
+        struct clk *clk;
+        int ret;
+
+        if (!dev || !dev->of_node || !name)
+                return -EINVAL;
+
+        clk = of_clk_get_by_name(dev->of_node, name);
+        if (IS_ERR(clk))
+                return PTR_ERR(clk);
+
+        ret = pm_clk_add_clk(dev, clk);
+        if (ret) {
+                clk_put(clk);
+                return ret;
+        }
+
+        return 0;
+}
+EXPORT_SYMBOL_GPL(of_pm_clk_add_clk);
+
+/**
  * of_pm_clk_add_clks - Start using device clock(s) for power management.
  * @dev: Device whose clock(s) is going to be used for power management.
  *
@@ -192,6 +226,7 @@ error:
 
         return ret;
 }
+EXPORT_SYMBOL_GPL(of_pm_clk_add_clks);
 
 /**
  * __pm_clk_remove - Destroy PM clock entry.
@@ -252,6 +287,7 @@ void pm_clk_remove(struct device *dev, const char *con_id)
 
         __pm_clk_remove(ce);
 }
+EXPORT_SYMBOL_GPL(pm_clk_remove);
 
 /**
  * pm_clk_remove_clk - Stop using a device clock for power management.
@@ -285,6 +321,7 @@ void pm_clk_remove_clk(struct device *dev, struct clk *clk)
 
         __pm_clk_remove(ce);
 }
+EXPORT_SYMBOL_GPL(pm_clk_remove_clk);
 
 /**
  * pm_clk_init - Initialize a device's list of power management clocks.
@@ -299,6 +336,7 @@ void pm_clk_init(struct device *dev)
         if (psd)
                 INIT_LIST_HEAD(&psd->clock_list);
 }
+EXPORT_SYMBOL_GPL(pm_clk_init);
 
 /**
  * pm_clk_create - Create and initialize a device's list of PM clocks.
@@ -311,6 +349,7 @@ int pm_clk_create(struct device *dev)
 {
         return dev_pm_get_subsys_data(dev);
 }
+EXPORT_SYMBOL_GPL(pm_clk_create);
 
 /**
  * pm_clk_destroy - Destroy a device's list of power management clocks.
@@ -345,6 +384,7 @@ void pm_clk_destroy(struct device *dev)
                 __pm_clk_remove(ce);
         }
 }
+EXPORT_SYMBOL_GPL(pm_clk_destroy);
 
 /**
  * pm_clk_suspend - Disable clocks in a device's PM clock list.
@@ -375,6 +415,7 @@ int pm_clk_suspend(struct device *dev)
 
         return 0;
 }
+EXPORT_SYMBOL_GPL(pm_clk_suspend);
 
 /**
  * pm_clk_resume - Enable clocks in a device's PM clock list.
@@ -400,6 +441,7 @@ int pm_clk_resume(struct device *dev)
 
         return 0;
 }
+EXPORT_SYMBOL_GPL(pm_clk_resume);
 
 /**
  * pm_clk_notify - Notify routine for device addition and removal.
@@ -480,6 +522,7 @@ int pm_clk_runtime_suspend(struct device *dev)
 
         return 0;
 }
+EXPORT_SYMBOL_GPL(pm_clk_runtime_suspend);
 
 int pm_clk_runtime_resume(struct device *dev)
 {
@@ -495,6 +538,7 @@ int pm_clk_runtime_resume(struct device *dev)
 
         return pm_generic_runtime_resume(dev);
 }
+EXPORT_SYMBOL_GPL(pm_clk_runtime_resume);
 
 #else /* !CONFIG_PM_CLK */
 
@@ -598,3 +642,4 @@ void pm_clk_add_notifier(struct bus_type *bus,
         clknb->nb.notifier_call = pm_clk_notify;
         bus_register_notifier(bus, &clknb->nb);
 }
+EXPORT_SYMBOL_GPL(pm_clk_add_notifier);
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index de23b648fce3..a1f2aff33997 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -187,8 +187,7 @@ static int genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth)
         struct gpd_link *link;
         int ret = 0;
 
-        if (genpd->status == GPD_STATE_ACTIVE
-            || (genpd->prepared_count > 0 && genpd->suspend_power_off))
+        if (genpd->status == GPD_STATE_ACTIVE)
                 return 0;
 
         /*
@@ -735,82 +734,24 @@ static int pm_genpd_prepare(struct device *dev)
 
         mutex_lock(&genpd->lock);
 
-        if (genpd->prepared_count++ == 0) {
+        if (genpd->prepared_count++ == 0)
                 genpd->suspended_count = 0;
-                genpd->suspend_power_off = genpd->status == GPD_STATE_POWER_OFF;
-        }
 
         mutex_unlock(&genpd->lock);
 
-        if (genpd->suspend_power_off)
-                return 0;
-
-        /*
-         * The PM domain must be in the GPD_STATE_ACTIVE state at this point,
-         * so genpd_poweron() will return immediately, but if the device
-         * is suspended (e.g. it's been stopped by genpd_stop_dev()), we need
-         * to make it operational.
-         */
-        pm_runtime_resume(dev);
-        __pm_runtime_disable(dev, false);
-
         ret = pm_generic_prepare(dev);
         if (ret) {
                 mutex_lock(&genpd->lock);
 
-                if (--genpd->prepared_count == 0)
-                        genpd->suspend_power_off = false;
+                genpd->prepared_count--;
 
                 mutex_unlock(&genpd->lock);
-                pm_runtime_enable(dev);
         }
 
         return ret;
 }
 
 /**
- * pm_genpd_suspend - Suspend a device belonging to an I/O PM domain.
- * @dev: Device to suspend.
- *
- * Suspend a device under the assumption that its pm_domain field points to the
- * domain member of an object of type struct generic_pm_domain representing
- * a PM domain consisting of I/O devices.
- */
-static int pm_genpd_suspend(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_suspend(dev);
-}
-
-/**
- * pm_genpd_suspend_late - Late suspend of a device from an I/O PM domain.
- * @dev: Device to suspend.
- *
- * Carry out a late suspend of a device under the assumption that its
- * pm_domain field points to the domain member of an object of type
- * struct generic_pm_domain representing a PM domain consisting of I/O devices.
- */
-static int pm_genpd_suspend_late(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_suspend_late(dev);
-}
-
-/**
  * pm_genpd_suspend_noirq - Completion of suspend of device in an I/O PM domain.
  * @dev: Device to suspend.
  *
@@ -820,6 +761,7 @@ static int pm_genpd_suspend_late(struct device *dev)
 static int pm_genpd_suspend_noirq(struct device *dev)
 {
         struct generic_pm_domain *genpd;
+        int ret;
 
         dev_dbg(dev, "%s()\n", __func__);
 
@@ -827,11 +769,14 @@ static int pm_genpd_suspend_noirq(struct device *dev)
         if (IS_ERR(genpd))
                 return -EINVAL;
 
-        if (genpd->suspend_power_off
-            || (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev)))
+        if (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
                 return 0;
 
-        genpd_stop_dev(genpd, dev);
+        if (genpd->dev_ops.stop && genpd->dev_ops.start) {
+                ret = pm_runtime_force_suspend(dev);
+                if (ret)
+                        return ret;
+        }
 
         /*
          * Since all of the "noirq" callbacks are executed sequentially, it is
@@ -853,6 +798,7 @@ static int pm_genpd_suspend_noirq(struct device *dev)
 static int pm_genpd_resume_noirq(struct device *dev)
 {
         struct generic_pm_domain *genpd;
+        int ret = 0;
 
         dev_dbg(dev, "%s()\n", __func__);
 
@@ -860,8 +806,7 @@ static int pm_genpd_resume_noirq(struct device *dev)
         if (IS_ERR(genpd))
                 return -EINVAL;
 
-        if (genpd->suspend_power_off
-            || (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev)))
+        if (dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
                 return 0;
 
         /*
@@ -872,93 +817,10 @@ static int pm_genpd_resume_noirq(struct device *dev)
         pm_genpd_sync_poweron(genpd, true);
         genpd->suspended_count--;
 
-        return genpd_start_dev(genpd, dev);
-}
-
-/**
- * pm_genpd_resume_early - Early resume of a device in an I/O PM domain.
- * @dev: Device to resume.
- *
- * Carry out an early resume of a device under the assumption that its
- * pm_domain field points to the domain member of an object of type
- * struct generic_pm_domain representing a power domain consisting of I/O
- * devices.
- */
-static int pm_genpd_resume_early(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_resume_early(dev);
-}
-
-/**
- * pm_genpd_resume - Resume of device in an I/O PM domain.
- * @dev: Device to resume.
- *
- * Resume a device under the assumption that its pm_domain field points to the
- * domain member of an object of type struct generic_pm_domain representing
- * a power domain consisting of I/O devices.
- */
-static int pm_genpd_resume(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_resume(dev);
-}
-
-/**
- * pm_genpd_freeze - Freezing a device in an I/O PM domain.
- * @dev: Device to freeze.
- *
- * Freeze a device under the assumption that its pm_domain field points to the
- * domain member of an object of type struct generic_pm_domain representing
- * a power domain consisting of I/O devices.
- */
-static int pm_genpd_freeze(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_freeze(dev);
-}
+        if (genpd->dev_ops.stop && genpd->dev_ops.start)
+                ret = pm_runtime_force_resume(dev);
 
-/**
- * pm_genpd_freeze_late - Late freeze of a device in an I/O PM domain.
- * @dev: Device to freeze.
- *
- * Carry out a late freeze of a device under the assumption that its
- * pm_domain field points to the domain member of an object of type
- * struct generic_pm_domain representing a power domain consisting of I/O
- * devices.
- */
-static int pm_genpd_freeze_late(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_freeze_late(dev);
+        return ret;
 }
 
 /**
@@ -973,6 +835,7 @@ static int pm_genpd_freeze_late(struct device *dev)
 static int pm_genpd_freeze_noirq(struct device *dev)
 {
         struct generic_pm_domain *genpd;
+        int ret = 0;
 
         dev_dbg(dev, "%s()\n", __func__);
 
@@ -980,7 +843,10 @@ static int pm_genpd_freeze_noirq(struct device *dev)
         if (IS_ERR(genpd))
                 return -EINVAL;
 
-        return genpd->suspend_power_off ? 0 : genpd_stop_dev(genpd, dev);
+        if (genpd->dev_ops.stop && genpd->dev_ops.start)
+                ret = pm_runtime_force_suspend(dev);
+
+        return ret;
 }
 
 /**
@@ -993,6 +859,7 @@ static int pm_genpd_freeze_noirq(struct device *dev)
 static int pm_genpd_thaw_noirq(struct device *dev)
 {
         struct generic_pm_domain *genpd;
+        int ret = 0;
 
         dev_dbg(dev, "%s()\n", __func__);
 
@@ -1000,51 +867,10 @@ static int pm_genpd_thaw_noirq(struct device *dev)
         if (IS_ERR(genpd))
                 return -EINVAL;
 
-        return genpd->suspend_power_off ?
-                0 : genpd_start_dev(genpd, dev);
-}
-
-/**
- * pm_genpd_thaw_early - Early thaw of device in an I/O PM domain.
- * @dev: Device to thaw.
- *
- * Carry out an early thaw of a device under the assumption that its
- * pm_domain field points to the domain member of an object of type
- * struct generic_pm_domain representing a power domain consisting of I/O
- * devices.
- */
-static int pm_genpd_thaw_early(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
-
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_thaw_early(dev);
-}
-
-/**
- * pm_genpd_thaw - Thaw a device belonging to an I/O power domain.
- * @dev: Device to thaw.
- *
- * Thaw a device under the assumption that its pm_domain field points to the
- * domain member of an object of type struct generic_pm_domain representing
- * a power domain consisting of I/O devices.
- */
-static int pm_genpd_thaw(struct device *dev)
-{
-        struct generic_pm_domain *genpd;
-
-        dev_dbg(dev, "%s()\n", __func__);
+        if (genpd->dev_ops.stop && genpd->dev_ops.start)
+                ret = pm_runtime_force_resume(dev);
 
-        genpd = dev_to_genpd(dev);
-        if (IS_ERR(genpd))
-                return -EINVAL;
-
-        return genpd->suspend_power_off ? 0 : pm_generic_thaw(dev);
+        return ret;
 }
 
 /**
@@ -1057,6 +883,7 @@ static int pm_genpd_thaw(struct device *dev)
 static int pm_genpd_restore_noirq(struct device *dev)
 {
         struct generic_pm_domain *genpd;
+        int ret = 0;
 
         dev_dbg(dev, "%s()\n", __func__);
 
@@ -1072,30 +899,20 @@ static int pm_genpd_restore_noirq(struct device *dev)
          * At this point suspended_count == 0 means we are being run for the
          * first time for the given domain in the present cycle.
          */
-        if (genpd->suspended_count++ == 0) {
+        if (genpd->suspended_count++ == 0)
                 /*
                  * The boot kernel might put the domain into arbitrary state,
                  * so make it appear as powered off to pm_genpd_sync_poweron(),
                  * so that it tries to power it on in case it was really off.
                  */
                 genpd->status = GPD_STATE_POWER_OFF;
-                if (genpd->suspend_power_off) {
-                        /*
-                         * If the domain was off before the hibernation, make
-                         * sure it will be off going forward.
-                         */
-                        genpd_power_off(genpd, true);
-
-                        return 0;
-                }
-        }
-
-        if (genpd->suspend_power_off)
-                return 0;
 
         pm_genpd_sync_poweron(genpd, true);
 
-        return genpd_start_dev(genpd, dev);
+        if (genpd->dev_ops.stop && genpd->dev_ops.start)
+                ret = pm_runtime_force_resume(dev);
+
+        return ret;
 }
 
 /**
@@ -1110,7 +927,6 @@ static int pm_genpd_restore_noirq(struct device *dev)
 static void pm_genpd_complete(struct device *dev)
 {
         struct generic_pm_domain *genpd;
-        bool run_complete;
 
         dev_dbg(dev, "%s()\n", __func__);
 
@@ -1118,20 +934,15 @@ static void pm_genpd_complete(struct device *dev)
         if (IS_ERR(genpd))
                 return;
 
+        pm_generic_complete(dev);
+
         mutex_lock(&genpd->lock);
 
-        run_complete = !genpd->suspend_power_off;
-        if (--genpd->prepared_count == 0)
-                genpd->suspend_power_off = false;
+        genpd->prepared_count--;
+        if (!genpd->prepared_count)
+                genpd_queue_power_off_work(genpd);
 
         mutex_unlock(&genpd->lock);
-
-        if (run_complete) {
-                pm_generic_complete(dev);
-                pm_runtime_set_active(dev);
-                pm_runtime_enable(dev);
-                pm_request_idle(dev);
-        }
 }
 
 /**
@@ -1173,18 +984,10 @@ EXPORT_SYMBOL_GPL(pm_genpd_syscore_poweron);
 #else /* !CONFIG_PM_SLEEP */
 
 #define pm_genpd_prepare                NULL
-#define pm_genpd_suspend                NULL
-#define pm_genpd_suspend_late           NULL
 #define pm_genpd_suspend_noirq          NULL
-#define pm_genpd_resume_early           NULL
 #define pm_genpd_resume_noirq           NULL
-#define pm_genpd_resume                 NULL
-#define pm_genpd_freeze                 NULL
-#define pm_genpd_freeze_late            NULL
 #define pm_genpd_freeze_noirq           NULL
-#define pm_genpd_thaw_early             NULL
 #define pm_genpd_thaw_noirq             NULL
-#define pm_genpd_thaw                   NULL
 #define pm_genpd_restore_noirq          NULL
 #define pm_genpd_complete               NULL
 
@@ -1455,12 +1258,14 @@ EXPORT_SYMBOL_GPL(pm_genpd_remove_subdomain);
  * @genpd: PM domain object to initialize.
  * @gov: PM domain governor to associate with the domain (may be NULL).
  * @is_off: Initial value of the domain's power_is_off field.
+ *
+ * Returns 0 on successful initialization, else a negative error code.
  */
-void pm_genpd_init(struct generic_pm_domain *genpd,
-                   struct dev_power_governor *gov, bool is_off)
+int pm_genpd_init(struct generic_pm_domain *genpd,
+                  struct dev_power_governor *gov, bool is_off)
 {
         if (IS_ERR_OR_NULL(genpd))
-                return;
+                return -EINVAL;
 
         INIT_LIST_HEAD(&genpd->master_links);
         INIT_LIST_HEAD(&genpd->slave_links);
@@ -1476,24 +1281,24 @@ void pm_genpd_init(struct generic_pm_domain *genpd,
         genpd->domain.ops.runtime_suspend = genpd_runtime_suspend;
         genpd->domain.ops.runtime_resume = genpd_runtime_resume;
         genpd->domain.ops.prepare = pm_genpd_prepare;
-        genpd->domain.ops.suspend = pm_genpd_suspend;
-        genpd->domain.ops.suspend_late = pm_genpd_suspend_late;
+        genpd->domain.ops.suspend = pm_generic_suspend;
+        genpd->domain.ops.suspend_late = pm_generic_suspend_late;
         genpd->domain.ops.suspend_noirq = pm_genpd_suspend_noirq;
         genpd->domain.ops.resume_noirq = pm_genpd_resume_noirq;
-        genpd->domain.ops.resume_early = pm_genpd_resume_early;
-        genpd->domain.ops.resume = pm_genpd_resume;
-        genpd->domain.ops.freeze = pm_genpd_freeze;
-        genpd->domain.ops.freeze_late = pm_genpd_freeze_late;
+        genpd->domain.ops.resume_early = pm_generic_resume_early;
+        genpd->domain.ops.resume = pm_generic_resume;
+        genpd->domain.ops.freeze = pm_generic_freeze;
+        genpd->domain.ops.freeze_late = pm_generic_freeze_late;
         genpd->domain.ops.freeze_noirq = pm_genpd_freeze_noirq;
         genpd->domain.ops.thaw_noirq = pm_genpd_thaw_noirq;
-        genpd->domain.ops.thaw_early = pm_genpd_thaw_early;
-        genpd->domain.ops.thaw = pm_genpd_thaw;
-        genpd->domain.ops.poweroff = pm_genpd_suspend;
-        genpd->domain.ops.poweroff_late = pm_genpd_suspend_late;
+        genpd->domain.ops.thaw_early = pm_generic_thaw_early;
+        genpd->domain.ops.thaw = pm_generic_thaw;
+        genpd->domain.ops.poweroff = pm_generic_poweroff;
+        genpd->domain.ops.poweroff_late = pm_generic_poweroff_late;
         genpd->domain.ops.poweroff_noirq = pm_genpd_suspend_noirq;
         genpd->domain.ops.restore_noirq = pm_genpd_restore_noirq;
-        genpd->domain.ops.restore_early = pm_genpd_resume_early;
-        genpd->domain.ops.restore = pm_genpd_resume;
+        genpd->domain.ops.restore_early = pm_generic_restore_early;
+        genpd->domain.ops.restore = pm_generic_restore;
         genpd->domain.ops.complete = pm_genpd_complete;
 
         if (genpd->flags & GENPD_FLAG_PM_CLK) {
@@ -1518,6 +1323,8 @@ void pm_genpd_init(struct generic_pm_domain *genpd,
         mutex_lock(&gpd_list_lock);
         list_add(&genpd->gpd_list_node, &gpd_list);
         mutex_unlock(&gpd_list_lock);
+
+        return 0;
 }
 EXPORT_SYMBOL_GPL(pm_genpd_init);
 
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index b74690418504..e097d355cc04 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -1045,10 +1045,14 @@ int __pm_runtime_set_status(struct device *dev, unsigned int status)
                  */
                 if (!parent->power.disable_depth
                     && !parent->power.ignore_children
-                    && parent->power.runtime_status != RPM_ACTIVE)
+                    && parent->power.runtime_status != RPM_ACTIVE) {
+                        dev_err(dev, "runtime PM trying to activate child device %s but parent (%s) is not active\n",
+                                dev_name(dev),
+                                dev_name(parent));
                         error = -EBUSY;
-                else if (dev->power.runtime_status == RPM_SUSPENDED)
+                } else if (dev->power.runtime_status == RPM_SUSPENDED) {
                         atomic_inc(&parent->power.child_count);
+                }
 
                 spin_unlock(&parent->power.lock);
 
@@ -1256,7 +1260,7 @@ void pm_runtime_allow(struct device *dev)
 
         dev->power.runtime_auto = true;
         if (atomic_dec_and_test(&dev->power.usage_count))
-                rpm_idle(dev, RPM_AUTO);
+                rpm_idle(dev, RPM_AUTO | RPM_ASYNC);
 
  out:
         spin_unlock_irq(&dev->power.lock);
@@ -1506,6 +1510,9 @@ int pm_runtime_force_resume(struct device *dev)
                 goto out;
         }
 
+        if (!pm_runtime_status_suspended(dev))
+                goto out;
+
         ret = pm_runtime_set_active(dev);
         if (ret)
                 goto out;