diff options
author | Andreas Werner <andreas.werner@men.de> | 2015-12-04 12:12:49 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2015-12-07 10:25:57 -0500 |
commit | ea013a9b205b47b1fcbc72522146fad560af0712 (patch) | |
tree | 4cb4246efacefc985f78987c88d36232a9d928fd /drivers/ata/libata-eh.c | |
parent | d98f1cd0a3b70ea91f1dfda3ac36c3b2e1a4d5e2 (diff) |
libata-eh.c: Introduce new ata port flag for controller which lockup on read log page
Some controller lockup on a ata_read_log_page.
Add new ata port flag ATA_FLAG_NO_LOG_PAGE which can used
to blacklist a controller.
If this flag is set, any attempt to read a log page returns an error
without actually issuing the command.
Signed-off-by: Andreas Werner <andreas.werner@men.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/libata-eh.c')
-rw-r--r-- | drivers/ata/libata-eh.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index cb0508af1459..961acc788f44 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c | |||
@@ -1505,12 +1505,20 @@ static const char *ata_err_string(unsigned int err_mask) | |||
1505 | unsigned int ata_read_log_page(struct ata_device *dev, u8 log, | 1505 | unsigned int ata_read_log_page(struct ata_device *dev, u8 log, |
1506 | u8 page, void *buf, unsigned int sectors) | 1506 | u8 page, void *buf, unsigned int sectors) |
1507 | { | 1507 | { |
1508 | unsigned long ap_flags = dev->link->ap->flags; | ||
1508 | struct ata_taskfile tf; | 1509 | struct ata_taskfile tf; |
1509 | unsigned int err_mask; | 1510 | unsigned int err_mask; |
1510 | bool dma = false; | 1511 | bool dma = false; |
1511 | 1512 | ||
1512 | DPRINTK("read log page - log 0x%x, page 0x%x\n", log, page); | 1513 | DPRINTK("read log page - log 0x%x, page 0x%x\n", log, page); |
1513 | 1514 | ||
1515 | /* | ||
1516 | * Return error without actually issuing the command on controllers | ||
1517 | * which e.g. lockup on a read log page. | ||
1518 | */ | ||
1519 | if (ap_flags & ATA_FLAG_NO_LOG_PAGE) | ||
1520 | return AC_ERR_DEV; | ||
1521 | |||
1514 | retry: | 1522 | retry: |
1515 | ata_tf_init(dev, &tf); | 1523 | ata_tf_init(dev, &tf); |
1516 | if (dev->dma_mode && ata_id_has_read_log_dma_ext(dev->id) && | 1524 | if (dev->dma_mode && ata_id_has_read_log_dma_ext(dev->id) && |