summaryrefslogtreecommitdiffstats
path: root/drivers/acpi/apei
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2016-05-23 04:28:03 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2016-06-23 17:41:38 -0400
commitb2f740baa4215254cee94a1d326a29d984169e4e (patch)
treeb31bfbc8ca09ff8f85029385b3c7d83099d38f75 /drivers/acpi/apei
parent33688abb2802ff3a230bd2441f765477b94cc89e (diff)
ACPI / einj: Convert EINJ_PFX to proper pr_fmt
... and remove it from the pr_* calls. Signed-off-by: Borislav Petkov <bp@suse.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/apei')
-rw-r--r--drivers/acpi/apei/einj.c25
1 files changed, 11 insertions, 14 deletions
diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 559c1173de1c..4ba41855799f 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -33,7 +33,8 @@
33 33
34#include "apei-internal.h" 34#include "apei-internal.h"
35 35
36#define EINJ_PFX "EINJ: " 36#undef pr_fmt
37#define pr_fmt(fmt) "EINJ: " fmt
37 38
38#define SPIN_UNIT 100 /* 100ns */ 39#define SPIN_UNIT 100 /* 100ns */
39/* Firmware should respond within 1 milliseconds */ 40/* Firmware should respond within 1 milliseconds */
@@ -179,8 +180,7 @@ static int einj_get_available_error_type(u32 *type)
179static int einj_timedout(u64 *t) 180static int einj_timedout(u64 *t)
180{ 181{
181 if ((s64)*t < SPIN_UNIT) { 182 if ((s64)*t < SPIN_UNIT) {
182 pr_warning(FW_WARN EINJ_PFX 183 pr_warning(FW_WARN "Firmware does not respond in time\n");
183 "Firmware does not respond in time\n");
184 return 1; 184 return 1;
185 } 185 }
186 *t -= SPIN_UNIT; 186 *t -= SPIN_UNIT;
@@ -307,8 +307,7 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
307 r = request_mem_region(trigger_paddr, sizeof(*trigger_tab), 307 r = request_mem_region(trigger_paddr, sizeof(*trigger_tab),
308 "APEI EINJ Trigger Table"); 308 "APEI EINJ Trigger Table");
309 if (!r) { 309 if (!r) {
310 pr_err(EINJ_PFX 310 pr_err("Can not request [mem %#010llx-%#010llx] for Trigger table\n",
311 "Can not request [mem %#010llx-%#010llx] for Trigger table\n",
312 (unsigned long long)trigger_paddr, 311 (unsigned long long)trigger_paddr,
313 (unsigned long long)trigger_paddr + 312 (unsigned long long)trigger_paddr +
314 sizeof(*trigger_tab) - 1); 313 sizeof(*trigger_tab) - 1);
@@ -316,13 +315,12 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
316 } 315 }
317 trigger_tab = ioremap_cache(trigger_paddr, sizeof(*trigger_tab)); 316 trigger_tab = ioremap_cache(trigger_paddr, sizeof(*trigger_tab));
318 if (!trigger_tab) { 317 if (!trigger_tab) {
319 pr_err(EINJ_PFX "Failed to map trigger table!\n"); 318 pr_err("Failed to map trigger table!\n");
320 goto out_rel_header; 319 goto out_rel_header;
321 } 320 }
322 rc = einj_check_trigger_header(trigger_tab); 321 rc = einj_check_trigger_header(trigger_tab);
323 if (rc) { 322 if (rc) {
324 pr_warning(FW_BUG EINJ_PFX 323 pr_warning(FW_BUG "Invalid trigger error action table.\n");
325 "The trigger error action table is invalid\n");
326 goto out_rel_header; 324 goto out_rel_header;
327 } 325 }
328 326
@@ -336,8 +334,7 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
336 table_size - sizeof(*trigger_tab), 334 table_size - sizeof(*trigger_tab),
337 "APEI EINJ Trigger Table"); 335 "APEI EINJ Trigger Table");
338 if (!r) { 336 if (!r) {
339 pr_err(EINJ_PFX 337 pr_err("Can not request [mem %#010llx-%#010llx] for Trigger Table Entry\n",
340"Can not request [mem %#010llx-%#010llx] for Trigger Table Entry\n",
341 (unsigned long long)trigger_paddr + sizeof(*trigger_tab), 338 (unsigned long long)trigger_paddr + sizeof(*trigger_tab),
342 (unsigned long long)trigger_paddr + table_size - 1); 339 (unsigned long long)trigger_paddr + table_size - 1);
343 goto out_rel_header; 340 goto out_rel_header;
@@ -345,7 +342,7 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
345 iounmap(trigger_tab); 342 iounmap(trigger_tab);
346 trigger_tab = ioremap_cache(trigger_paddr, table_size); 343 trigger_tab = ioremap_cache(trigger_paddr, table_size);
347 if (!trigger_tab) { 344 if (!trigger_tab) {
348 pr_err(EINJ_PFX "Failed to map trigger table!\n"); 345 pr_err("Failed to map trigger table!\n");
349 goto out_rel_entry; 346 goto out_rel_entry;
350 } 347 }
351 trigger_entry = (struct acpi_whea_header *) 348 trigger_entry = (struct acpi_whea_header *)
@@ -704,13 +701,13 @@ static int __init einj_init(void)
704 return -ENODEV; 701 return -ENODEV;
705 else if (ACPI_FAILURE(status)) { 702 else if (ACPI_FAILURE(status)) {
706 const char *msg = acpi_format_exception(status); 703 const char *msg = acpi_format_exception(status);
707 pr_err(EINJ_PFX "Failed to get table, %s\n", msg); 704 pr_err("Failed to get table, %s\n", msg);
708 return -EINVAL; 705 return -EINVAL;
709 } 706 }
710 707
711 rc = einj_check_table(einj_tab); 708 rc = einj_check_table(einj_tab);
712 if (rc) { 709 if (rc) {
713 pr_warning(FW_BUG EINJ_PFX "EINJ table is invalid\n"); 710 pr_warning(FW_BUG "EINJ table is invalid\n");
714 return -EINVAL; 711 return -EINVAL;
715 } 712 }
716 713
@@ -787,7 +784,7 @@ static int __init einj_init(void)
787 goto err_unmap; 784 goto err_unmap;
788 } 785 }
789 786
790 pr_info(EINJ_PFX "Error INJection is initialized.\n"); 787 pr_info("Error INJection is initialized.\n");
791 788
792 return 0; 789 return 0;
793 790