summaryrefslogtreecommitdiffstats
path: root/block/cfq-iosched.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2014-09-07 19:15:20 -0400
committerJens Axboe <axboe@fb.com>2014-09-08 11:55:37 -0400
commitf4da80727cfbc3590d95ff17ef8db96e6f1483a4 (patch)
treecd073c26cb66e6d2f8640c3aabb412ff22946b63 /block/cfq-iosched.c
parent55872c5a3c01f0fe7b5298d19e24e237f5b5ff06 (diff)
blkcg: remove blkcg->id
blkcg->id is a unique id given to each blkcg; however, the cgroup_subsys_state which each blkcg embeds already has ->serial_nr which can be used for the same purpose. Drop blkcg->id and replace its uses with blkcg->css.serial_nr. Rename cfq_cgroup->blkcg_id to ->blkcg_serial_nr and @id in check_blkcg_changed() to @serial_nr for consistency. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/cfq-iosched.c')
-rw-r--r--block/cfq-iosched.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index cadc37841744..900f569afcc5 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -299,7 +299,7 @@ struct cfq_io_cq {
299 struct cfq_ttime ttime; 299 struct cfq_ttime ttime;
300 int ioprio; /* the current ioprio */ 300 int ioprio; /* the current ioprio */
301#ifdef CONFIG_CFQ_GROUP_IOSCHED 301#ifdef CONFIG_CFQ_GROUP_IOSCHED
302 uint64_t blkcg_id; /* the current blkcg ID */ 302 uint64_t blkcg_serial_nr; /* the current blkcg serial */
303#endif 303#endif
304}; 304};
305 305
@@ -3534,17 +3534,17 @@ static void check_blkcg_changed(struct cfq_io_cq *cic, struct bio *bio)
3534{ 3534{
3535 struct cfq_data *cfqd = cic_to_cfqd(cic); 3535 struct cfq_data *cfqd = cic_to_cfqd(cic);
3536 struct cfq_queue *sync_cfqq; 3536 struct cfq_queue *sync_cfqq;
3537 uint64_t id; 3537 uint64_t serial_nr;
3538 3538
3539 rcu_read_lock(); 3539 rcu_read_lock();
3540 id = bio_blkcg(bio)->id; 3540 serial_nr = bio_blkcg(bio)->css.serial_nr;
3541 rcu_read_unlock(); 3541 rcu_read_unlock();
3542 3542
3543 /* 3543 /*
3544 * Check whether blkcg has changed. The condition may trigger 3544 * Check whether blkcg has changed. The condition may trigger
3545 * spuriously on a newly created cic but there's no harm. 3545 * spuriously on a newly created cic but there's no harm.
3546 */ 3546 */
3547 if (unlikely(!cfqd) || likely(cic->blkcg_id == id)) 3547 if (unlikely(!cfqd) || likely(cic->blkcg_serial_nr == serial_nr))
3548 return; 3548 return;
3549 3549
3550 sync_cfqq = cic_to_cfqq(cic, 1); 3550 sync_cfqq = cic_to_cfqq(cic, 1);
@@ -3558,7 +3558,7 @@ static void check_blkcg_changed(struct cfq_io_cq *cic, struct bio *bio)
3558 cfq_put_queue(sync_cfqq); 3558 cfq_put_queue(sync_cfqq);
3559 } 3559 }
3560 3560
3561 cic->blkcg_id = id; 3561 cic->blkcg_serial_nr = serial_nr;
3562} 3562}
3563#else 3563#else
3564static inline void check_blkcg_changed(struct cfq_io_cq *cic, struct bio *bio) { } 3564static inline void check_blkcg_changed(struct cfq_io_cq *cic, struct bio *bio) { }