diff options
author | Tejun Heo <tj@kernel.org> | 2012-04-13 16:11:25 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2012-04-20 04:06:06 -0400 |
commit | f48ec1d7885281a9c6cd7779d61f321d1b1fd741 (patch) | |
tree | 87f94a60dae017dc68b76605f76b89031004a7f7 /block/cfq-iosched.c | |
parent | 5bc4afb1ec6aa562fac4d9aba34d957ee42f5813 (diff) |
cfq: fix build breakage & warnings
* CFQ_WEIGHT_* defined inside CONFIG_BLK_CGROUP causes cfq-iosched.c
compile failure when the config is disabled. Move it outside the
ifdef block.
* Dummy cfqg_stats_*() definitions were lacking inline modifiers
causing unused functions warning if !CONFIG_CFQ_GROUP_IOSCHED. Add
them.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/cfq-iosched.c')
-rw-r--r-- | block/cfq-iosched.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index cff8b5ba6208..7a8c3e0ab3a2 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
@@ -17,7 +17,7 @@ | |||
17 | #include "blk.h" | 17 | #include "blk.h" |
18 | #include "blk-cgroup.h" | 18 | #include "blk-cgroup.h" |
19 | 19 | ||
20 | static struct blkio_policy_type blkio_policy_cfq; | 20 | static struct blkio_policy_type blkio_policy_cfq __maybe_unused; |
21 | 21 | ||
22 | /* | 22 | /* |
23 | * tunables | 23 | * tunables |
@@ -541,14 +541,13 @@ static void cfqg_stats_update_avg_queue_size(struct cfq_group *cfqg) | |||
541 | 541 | ||
542 | #else /* CONFIG_CFQ_GROUP_IOSCHED && CONFIG_DEBUG_BLK_CGROUP */ | 542 | #else /* CONFIG_CFQ_GROUP_IOSCHED && CONFIG_DEBUG_BLK_CGROUP */ |
543 | 543 | ||
544 | static void cfqg_stats_set_start_group_wait_time(struct cfq_group *cfqg, | 544 | static inline void cfqg_stats_set_start_group_wait_time(struct cfq_group *cfqg, struct cfq_group *curr_cfqg) { } |
545 | struct cfq_group *curr_cfqg) { } | 545 | static inline void cfqg_stats_end_empty_time(struct cfqg_stats *stats) { } |
546 | static void cfqg_stats_end_empty_time(struct cfqg_stats *stats) { } | 546 | static inline void cfqg_stats_update_dequeue(struct cfq_group *cfqg) { } |
547 | static void cfqg_stats_update_dequeue(struct cfq_group *cfqg) { } | 547 | static inline void cfqg_stats_set_start_empty_time(struct cfq_group *cfqg) { } |
548 | static void cfqg_stats_set_start_empty_time(struct cfq_group *cfqg) { } | 548 | static inline void cfqg_stats_update_idle_time(struct cfq_group *cfqg) { } |
549 | static void cfqg_stats_update_idle_time(struct cfq_group *cfqg) { } | 549 | static inline void cfqg_stats_set_start_idle_time(struct cfq_group *cfqg) { } |
550 | static void cfqg_stats_set_start_idle_time(struct cfq_group *cfqg) { } | 550 | static inline void cfqg_stats_update_avg_queue_size(struct cfq_group *cfqg) { } |
551 | static void cfqg_stats_update_avg_queue_size(struct cfq_group *cfqg) { } | ||
552 | 551 | ||
553 | #endif /* CONFIG_CFQ_GROUP_IOSCHED && CONFIG_DEBUG_BLK_CGROUP */ | 552 | #endif /* CONFIG_CFQ_GROUP_IOSCHED && CONFIG_DEBUG_BLK_CGROUP */ |
554 | 553 | ||