diff options
author | Kimberly Brown <kimbrownkd@gmail.com> | 2019-04-01 22:51:30 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-25 16:06:11 -0400 |
commit | 800f5aa1e7e1093fce197eecf2ff05b8491a5935 (patch) | |
tree | c1d42dc8cff38e8d94becd3650b3af00e10dcda7 /block/blk-mq-sysfs.c | |
parent | c484a6783d2b800ebbb110b28b0d96444f8b81ca (diff) |
block: Replace all ktype default_attrs with groups
The kobj_type default_attrs field is being replaced by the
default_groups field. Replace all of the ktype default_attrs fields in
the block subsystem with default_groups and use the ATTRIBUTE_GROUPS
macro to create the default groups.
Remove default_ctx_attrs[] because it doesn't contain any attributes.
This patch was tested by verifying that the sysfs files for the
attributes in the default groups were created.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'block/blk-mq-sysfs.c')
-rw-r--r-- | block/blk-mq-sysfs.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/block/blk-mq-sysfs.c b/block/blk-mq-sysfs.c index 3f9c3f4ac44c..5315e538b3b1 100644 --- a/block/blk-mq-sysfs.c +++ b/block/blk-mq-sysfs.c | |||
@@ -173,10 +173,6 @@ static ssize_t blk_mq_hw_sysfs_cpus_show(struct blk_mq_hw_ctx *hctx, char *page) | |||
173 | return ret; | 173 | return ret; |
174 | } | 174 | } |
175 | 175 | ||
176 | static struct attribute *default_ctx_attrs[] = { | ||
177 | NULL, | ||
178 | }; | ||
179 | |||
180 | static struct blk_mq_hw_ctx_sysfs_entry blk_mq_hw_sysfs_nr_tags = { | 176 | static struct blk_mq_hw_ctx_sysfs_entry blk_mq_hw_sysfs_nr_tags = { |
181 | .attr = {.name = "nr_tags", .mode = 0444 }, | 177 | .attr = {.name = "nr_tags", .mode = 0444 }, |
182 | .show = blk_mq_hw_sysfs_nr_tags_show, | 178 | .show = blk_mq_hw_sysfs_nr_tags_show, |
@@ -196,6 +192,7 @@ static struct attribute *default_hw_ctx_attrs[] = { | |||
196 | &blk_mq_hw_sysfs_cpus.attr, | 192 | &blk_mq_hw_sysfs_cpus.attr, |
197 | NULL, | 193 | NULL, |
198 | }; | 194 | }; |
195 | ATTRIBUTE_GROUPS(default_hw_ctx); | ||
199 | 196 | ||
200 | static const struct sysfs_ops blk_mq_sysfs_ops = { | 197 | static const struct sysfs_ops blk_mq_sysfs_ops = { |
201 | .show = blk_mq_sysfs_show, | 198 | .show = blk_mq_sysfs_show, |
@@ -214,13 +211,12 @@ static struct kobj_type blk_mq_ktype = { | |||
214 | 211 | ||
215 | static struct kobj_type blk_mq_ctx_ktype = { | 212 | static struct kobj_type blk_mq_ctx_ktype = { |
216 | .sysfs_ops = &blk_mq_sysfs_ops, | 213 | .sysfs_ops = &blk_mq_sysfs_ops, |
217 | .default_attrs = default_ctx_attrs, | ||
218 | .release = blk_mq_ctx_sysfs_release, | 214 | .release = blk_mq_ctx_sysfs_release, |
219 | }; | 215 | }; |
220 | 216 | ||
221 | static struct kobj_type blk_mq_hw_ktype = { | 217 | static struct kobj_type blk_mq_hw_ktype = { |
222 | .sysfs_ops = &blk_mq_hw_sysfs_ops, | 218 | .sysfs_ops = &blk_mq_hw_sysfs_ops, |
223 | .default_attrs = default_hw_ctx_attrs, | 219 | .default_groups = default_hw_ctx_groups, |
224 | .release = blk_mq_hw_sysfs_release, | 220 | .release = blk_mq_hw_sysfs_release, |
225 | }; | 221 | }; |
226 | 222 | ||