diff options
author | Martin K. Petersen <martin.petersen@oracle.com> | 2015-10-21 13:19:38 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2015-10-21 16:42:39 -0400 |
commit | a48f041d91bf1aee599fa2adb53b780ed20c2ee5 (patch) | |
tree | c1cb66965f987d782c5c6bc63826d2250caf8d18 /block/blk-integrity.c | |
parent | 0f8087ecdeac921fc4920f1328f55c15080bc6aa (diff) |
block: Reduce the size of struct blk_integrity
The per-device properties in the blk_integrity structure were previously
unsigned short. However, most of the values fit inside a char. The only
exception is the data interval size and we can work around that by
storing it as a power of two.
This cuts the size of the dynamic portion of blk_integrity in half.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-integrity.c')
-rw-r--r-- | block/blk-integrity.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/block/blk-integrity.c b/block/blk-integrity.c index daf590ab3b46..c7508654faff 100644 --- a/block/blk-integrity.c +++ b/block/blk-integrity.c | |||
@@ -155,10 +155,10 @@ int blk_integrity_compare(struct gendisk *gd1, struct gendisk *gd2) | |||
155 | if (!b1 || !b2) | 155 | if (!b1 || !b2) |
156 | return -1; | 156 | return -1; |
157 | 157 | ||
158 | if (b1->interval != b2->interval) { | 158 | if (b1->interval_exp != b2->interval_exp) { |
159 | pr_err("%s: %s/%s protection interval %u != %u\n", | 159 | pr_err("%s: %s/%s protection interval %u != %u\n", |
160 | __func__, gd1->disk_name, gd2->disk_name, | 160 | __func__, gd1->disk_name, gd2->disk_name, |
161 | b1->interval, b2->interval); | 161 | 1 << b1->interval_exp, 1 << b2->interval_exp); |
162 | return -1; | 162 | return -1; |
163 | } | 163 | } |
164 | 164 | ||
@@ -440,7 +440,7 @@ int blk_integrity_register(struct gendisk *disk, struct blk_integrity *template) | |||
440 | kobject_uevent(&disk->integrity_kobj, KOBJ_ADD); | 440 | kobject_uevent(&disk->integrity_kobj, KOBJ_ADD); |
441 | 441 | ||
442 | bi->flags |= BLK_INTEGRITY_VERIFY | BLK_INTEGRITY_GENERATE; | 442 | bi->flags |= BLK_INTEGRITY_VERIFY | BLK_INTEGRITY_GENERATE; |
443 | bi->interval = queue_logical_block_size(disk->queue); | 443 | bi->interval_exp = ilog2(queue_logical_block_size(disk->queue)); |
444 | disk->integrity = bi; | 444 | disk->integrity = bi; |
445 | } else | 445 | } else |
446 | bi = disk->integrity; | 446 | bi = disk->integrity; |