block, bfq: inject other-queue I/O into seeky idle queues on NCQ flash

The Achilles' heel of BFQ is its failing to reach a high throughput
with sync random I/O on flash storage with internal queueing, in case
the processes doing I/O have differentiated weights.

The cause of this failure is as follows. If at least two processes do
sync I/O, and have a different weight from each other, then BFQ plugs
I/O dispatching every time one of these processes, while it is being
served, remains temporarily without pending I/O requests. This
plugging is necessary to guarantee that every process enjoys a
bandwidth proportional to its weight; but it empties the internal
queue(s) of the drive. And this kills throughput with random I/O. So,
if some processes have differentiated weights and do both sync and
random I/O, the end result is a throughput collapse.

This commit tries to counter this problem by injecting the service of
other processes, in a controlled way, while the process in service
happens to have no I/O. This injection is performed only if the medium
is non rotational and performs internal queueing, and the process in
service does random I/O (service injection might be beneficial for
sequential I/O too, we'll work on that).

As an example of the benefits of this commit, on a PLEXTOR PX-256M5S
SSD, and with five processes having differentiated weights and doing
sync random 4KB I/O, this commit makes the throughput with bfq grow by
400%, from 25 to 100MB/s. This higher throughput is 10MB/s lower than
that reached with none. As some less random I/O is added to the mix,
the throughput becomes equal to or higher than that with none.

This commit is a very first attempt to recover throughput without
losing control, and certainly has many limitations. One is, e.g., that
the processes whose service is injected are not chosen so as to
distribute the extra bandwidth they receive in accordance to their
weights. Thus there might be loss of weighted fairness in some
cases. Anyway, this loss concerns extra service, which would not have
been received at all without this commit. Other limitations and issues
will probably show up with usage.

Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

1 files changed, 62 insertions, 6 deletions

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 653100fb719e..d94838bcc135 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -3182,6 +3182,13 @@ static unsigned long bfq_bfqq_softrt_next_start(struct bfq_data *bfqd,
                     jiffies + nsecs_to_jiffies(bfqq->bfqd->bfq_slice_idle) + 4);
 }
 
+static bool bfq_bfqq_injectable(struct bfq_queue *bfqq)
+{
+        return BFQQ_SEEKY(bfqq) && bfqq->wr_coeff == 1 &&
+                blk_queue_nonrot(bfqq->bfqd->queue) &&
+                bfqq->bfqd->hw_tag;
+}
+
 /**
  * bfq_bfqq_expire - expire a queue.
  * @bfqd: device owning the queue.
@@ -3291,6 +3298,8 @@ void bfq_bfqq_expire(struct bfq_data *bfqd,
         if (ref == 1) /* bfqq is gone, no more actions on it */
                 return;
 
+        bfqq->injected_service = 0;
+
         /* mark bfqq as waiting a request only if a bic still points to it */
         if (!bfq_bfqq_busy(bfqq) &&
             reason != BFQQE_BUDGET_TIMEOUT &&
@@ -3629,6 +3638,30 @@ static bool bfq_bfqq_must_idle(struct bfq_queue *bfqq)
         return RB_EMPTY_ROOT(&bfqq->sort_list) && bfq_better_to_idle(bfqq);
 }
 
+static struct bfq_queue *bfq_choose_bfqq_for_injection(struct bfq_data *bfqd)
+{
+        struct bfq_queue *bfqq;
+
+        /*
+         * A linear search; but, with a high probability, very few
+         * steps are needed to find a candidate queue, i.e., a queue
+         * with enough budget left for its next request. In fact:
+         * - BFQ dynamically updates the budget of every queue so as
+         *   to accommodate the expected backlog of the queue;
+         * - if a queue gets all its requests dispatched as injected
+         *   service, then the queue is removed from the active list
+         *   (and re-added only if it gets new requests, but with
+         *   enough budget for its new backlog).
+         */
+        list_for_each_entry(bfqq, &bfqd->active_list, bfqq_list)
+                if (!RB_EMPTY_ROOT(&bfqq->sort_list) &&
+                    bfq_serv_to_charge(bfqq->next_rq, bfqq) <=
+                    bfq_bfqq_budget_left(bfqq))
+                        return bfqq;
+
+        return NULL;
+}
+
 /*
  * Select a queue for service.  If we have a current queue in service,
  * check whether to continue servicing it, or retrieve and set a new one.
@@ -3710,10 +3743,19 @@ check_queue:
          * No requests pending. However, if the in-service queue is idling
          * for a new request, or has requests waiting for a completion and
          * may idle after their completion, then keep it anyway.
+         *
+         * Yet, to boost throughput, inject service from other queues if
+         * possible.
          */
         if (bfq_bfqq_wait_request(bfqq) ||
             (bfqq->dispatched != 0 && bfq_better_to_idle(bfqq))) {
-                bfqq = NULL;
+                if (bfq_bfqq_injectable(bfqq) &&
+                    bfqq->injected_service * bfqq->inject_coeff <
+                    bfqq->entity.service * 10)
+                        bfqq = bfq_choose_bfqq_for_injection(bfqd);
+                else
+                        bfqq = NULL;
+
                 goto keep_queue;
         }
 
@@ -3803,6 +3845,14 @@ static struct request *bfq_dispatch_rq_from_bfqq(struct bfq_data *bfqd,
 
         bfq_dispatch_remove(bfqd->queue, rq);
 
+        if (bfqq != bfqd->in_service_queue) {
+                if (likely(bfqd->in_service_queue))
+                        bfqd->in_service_queue->injected_service +=
+                                bfq_serv_to_charge(rq, bfqq);
+
+                goto return_rq;
+        }
+
         /*
          * If weight raising has to terminate for bfqq, then next
          * function causes an immediate update of bfqq's weight,
@@ -3821,13 +3871,12 @@ static struct request *bfq_dispatch_rq_from_bfqq(struct bfq_data *bfqd,
          * belongs to CLASS_IDLE and other queues are waiting for
          * service.
          */
-        if (bfqd->busy_queues > 1 && bfq_class_idle(bfqq))
-                goto expire;
-
-        return rq;
+        if (!(bfqd->busy_queues > 1 && bfq_class_idle(bfqq)))
+                goto return_rq;
 
-expire:
         bfq_bfqq_expire(bfqd, bfqq, false, BFQQE_BUDGET_EXHAUSTED);
+
+return_rq:
         return rq;
 }
 
@@ -4232,6 +4281,13 @@ static void bfq_init_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq,
                         bfq_mark_bfqq_has_short_ttime(bfqq);
                 bfq_mark_bfqq_sync(bfqq);
                 bfq_mark_bfqq_just_created(bfqq);
+                /*
+                 * Aggressively inject a lot of service: up to 90%.
+                 * This coefficient remains constant during bfqq life,
+                 * but this behavior might be changed, after enough
+                 * testing and tuning.
+                 */
+                bfqq->inject_coeff = 1;
         } else
                 bfq_clear_bfqq_sync(bfqq);