summaryrefslogtreecommitdiffstats
path: root/arch/x86/power
diff options
context:
space:
mode:
authorAndy Lutomirski <luto@kernel.org>2017-12-04 09:07:17 -0500
committerIngo Molnar <mingo@kernel.org>2017-12-17 07:59:55 -0500
commit7fb983b4dd569e08564134a850dfd4eb1c63d9b8 (patch)
treeb517637f76fc61268e1febface4a6ac5c7573496 /arch/x86/power
parent21506525fb8ddb0342f2a2370812d47f6a1f3833 (diff)
x86/entry: Fix assumptions that the HW TSS is at the beginning of cpu_tss
A future patch will move SYSENTER_stack to the beginning of cpu_tss to help detect overflow. Before this can happen, fix several code paths that hardcode assumptions about the old layout. Signed-off-by: Andy Lutomirski <luto@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Borislav Petkov <bp@suse.de> Reviewed-by: Dave Hansen <dave.hansen@intel.com> Reviewed-by: Thomas Gleixner <tglx@linutronix.de> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Borislav Petkov <bpetkov@suse.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: David Laight <David.Laight@aculab.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: Eduardo Valentin <eduval@amazon.com> Cc: Greg KH <gregkh@linuxfoundation.org> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Juergen Gross <jgross@suse.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rik van Riel <riel@redhat.com> Cc: Will Deacon <will.deacon@arm.com> Cc: aliguori@amazon.com Cc: daniel.gruss@iaik.tugraz.at Cc: hughd@google.com Cc: keescook@google.com Link: https://lkml.kernel.org/r/20171204150605.722425540@linutronix.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/power')
-rw-r--r--arch/x86/power/cpu.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
index 84fcfde53f8f..50593e138281 100644
--- a/arch/x86/power/cpu.c
+++ b/arch/x86/power/cpu.c
@@ -165,12 +165,13 @@ static void fix_processor_context(void)
165 struct desc_struct *desc = get_cpu_gdt_rw(cpu); 165 struct desc_struct *desc = get_cpu_gdt_rw(cpu);
166 tss_desc tss; 166 tss_desc tss;
167#endif 167#endif
168 set_tss_desc(cpu, t); /* 168
169 * This just modifies memory; should not be 169 /*
170 * necessary. But... This is necessary, because 170 * This just modifies memory; should not be necessary. But... This is
171 * 386 hardware has concept of busy TSS or some 171 * necessary, because 386 hardware has concept of busy TSS or some
172 * similar stupidity. 172 * similar stupidity.
173 */ 173 */
174 set_tss_desc(cpu, &t->x86_tss);
174 175
175#ifdef CONFIG_X86_64 176#ifdef CONFIG_X86_64
176 memcpy(&tss, &desc[GDT_ENTRY_TSS], sizeof(tss_desc)); 177 memcpy(&tss, &desc[GDT_ENTRY_TSS], sizeof(tss_desc));