diff options
author | YueHaibing <yuehaibing@huawei.com> | 2018-08-03 02:39:11 -0400 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2018-10-29 17:23:12 -0400 |
commit | d312a25d477519d5d47f8ce850e80b52cf4113b0 (patch) | |
tree | 8810685daaa5632f4c8262656e6a06e8f520d08c /arch/um/drivers | |
parent | 369cca266860db8222c991fced8caa42c3e5b05f (diff) |
um: NULL check before kfree is not needed
kfree(NULL) is safe,so this removes NULL check before freeing the mem
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'arch/um/drivers')
-rw-r--r-- | arch/um/drivers/vector_kern.c | 15 | ||||
-rw-r--r-- | arch/um/drivers/vector_user.c | 6 |
2 files changed, 7 insertions, 14 deletions
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index 50ee3bb5a63a..c84133cf4848 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c | |||
@@ -1118,16 +1118,11 @@ static int vector_net_close(struct net_device *dev) | |||
1118 | os_close_file(vp->fds->tx_fd); | 1118 | os_close_file(vp->fds->tx_fd); |
1119 | vp->fds->tx_fd = -1; | 1119 | vp->fds->tx_fd = -1; |
1120 | } | 1120 | } |
1121 | if (vp->bpf != NULL) | 1121 | kfree(vp->bpf); |
1122 | kfree(vp->bpf); | 1122 | kfree(vp->fds->remote_addr); |
1123 | if (vp->fds->remote_addr != NULL) | 1123 | kfree(vp->transport_data); |
1124 | kfree(vp->fds->remote_addr); | 1124 | kfree(vp->header_rxbuffer); |
1125 | if (vp->transport_data != NULL) | 1125 | kfree(vp->header_txbuffer); |
1126 | kfree(vp->transport_data); | ||
1127 | if (vp->header_rxbuffer != NULL) | ||
1128 | kfree(vp->header_rxbuffer); | ||
1129 | if (vp->header_txbuffer != NULL) | ||
1130 | kfree(vp->header_txbuffer); | ||
1131 | if (vp->rx_queue != NULL) | 1126 | if (vp->rx_queue != NULL) |
1132 | destroy_queue(vp->rx_queue); | 1127 | destroy_queue(vp->rx_queue); |
1133 | if (vp->tx_queue != NULL) | 1128 | if (vp->tx_queue != NULL) |
diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c index 4d6a78e31089..3d8cdbdb4e66 100644 --- a/arch/um/drivers/vector_user.c +++ b/arch/um/drivers/vector_user.c | |||
@@ -267,8 +267,7 @@ cleanup: | |||
267 | os_close_file(rxfd); | 267 | os_close_file(rxfd); |
268 | if (txfd >= 0) | 268 | if (txfd >= 0) |
269 | os_close_file(txfd); | 269 | os_close_file(txfd); |
270 | if (result != NULL) | 270 | kfree(result); |
271 | kfree(result); | ||
272 | return NULL; | 271 | return NULL; |
273 | } | 272 | } |
274 | 273 | ||
@@ -434,8 +433,7 @@ cleanup: | |||
434 | if (fd >= 0) | 433 | if (fd >= 0) |
435 | os_close_file(fd); | 434 | os_close_file(fd); |
436 | if (result != NULL) { | 435 | if (result != NULL) { |
437 | if (result->remote_addr != NULL) | 436 | kfree(result->remote_addr); |
438 | kfree(result->remote_addr); | ||
439 | kfree(result); | 437 | kfree(result); |
440 | } | 438 | } |
441 | return NULL; | 439 | return NULL; |