diff options
author | David Hildenbrand <dahi@linux.vnet.ibm.com> | 2015-05-11 11:52:09 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2015-05-19 02:39:14 -0400 |
commit | 2cb7c9cb426660b5ed58b643d9e7dd5d50ba901f (patch) | |
tree | 39976a7d4ee0ee34da0072e71fcd49e02480f096 /arch/sparc | |
parent | b3c395ef5556a6c60f4426cc060f5b7bdcf82d5b (diff) |
sched/preempt, mm/kmap: Explicitly disable/enable preemption in kmap_atomic_*
The existing code relies on pagefault_disable() implicitly disabling
preemption, so that no schedule will happen between kmap_atomic() and
kunmap_atomic().
Let's make this explicit, to prepare for pagefault_disable() not
touching preemption anymore.
Reviewed-and-tested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: David.Laight@ACULAB.COM
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: airlied@linux.ie
Cc: akpm@linux-foundation.org
Cc: benh@kernel.crashing.org
Cc: bigeasy@linutronix.de
Cc: borntraeger@de.ibm.com
Cc: daniel.vetter@intel.com
Cc: heiko.carstens@de.ibm.com
Cc: herbert@gondor.apana.org.au
Cc: hocko@suse.cz
Cc: hughd@google.com
Cc: mst@redhat.com
Cc: paulus@samba.org
Cc: ralf@linux-mips.org
Cc: schwidefsky@de.ibm.com
Cc: yang.shi@windriver.com
Link: http://lkml.kernel.org/r/1431359540-32227-5-git-send-email-dahi@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/sparc')
-rw-r--r-- | arch/sparc/mm/highmem.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/sparc/mm/highmem.c b/arch/sparc/mm/highmem.c index 449f864f0cef..a454ec5ff07a 100644 --- a/arch/sparc/mm/highmem.c +++ b/arch/sparc/mm/highmem.c | |||
@@ -53,7 +53,7 @@ void *kmap_atomic(struct page *page) | |||
53 | unsigned long vaddr; | 53 | unsigned long vaddr; |
54 | long idx, type; | 54 | long idx, type; |
55 | 55 | ||
56 | /* even !CONFIG_PREEMPT needs this, for in_atomic in do_page_fault */ | 56 | preempt_disable(); |
57 | pagefault_disable(); | 57 | pagefault_disable(); |
58 | if (!PageHighMem(page)) | 58 | if (!PageHighMem(page)) |
59 | return page_address(page); | 59 | return page_address(page); |
@@ -91,6 +91,7 @@ void __kunmap_atomic(void *kvaddr) | |||
91 | 91 | ||
92 | if (vaddr < FIXADDR_START) { // FIXME | 92 | if (vaddr < FIXADDR_START) { // FIXME |
93 | pagefault_enable(); | 93 | pagefault_enable(); |
94 | preempt_enable(); | ||
94 | return; | 95 | return; |
95 | } | 96 | } |
96 | 97 | ||
@@ -126,5 +127,6 @@ void __kunmap_atomic(void *kvaddr) | |||
126 | 127 | ||
127 | kmap_atomic_idx_pop(); | 128 | kmap_atomic_idx_pop(); |
128 | pagefault_enable(); | 129 | pagefault_enable(); |
130 | preempt_enable(); | ||
129 | } | 131 | } |
130 | EXPORT_SYMBOL(__kunmap_atomic); | 132 | EXPORT_SYMBOL(__kunmap_atomic); |