diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-07-15 14:17:52 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-07-15 14:17:52 -0400 |
commit | 89cbec71fead552fdd1fa38c57186669dfbba734 (patch) | |
tree | 0e8e235b23b0fc1cd2d32bb28cafdee636e62d51 /arch/blackfin | |
parent | 2173bd06315109ec73e7a6077c11469bd41d400b (diff) | |
parent | 3170d8d226c2053355f3946b4b5ded4c006fe6d4 (diff) |
Merge branch 'work.uaccess-unaligned' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull uacess-unaligned removal from Al Viro:
"That stuff had just one user, and an exotic one, at that - binfmt_flat
on arm and m68k"
* 'work.uaccess-unaligned' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
kill {__,}{get,put}_user_unaligned()
binfmt_flat: flat_{get,put}_addr_from_rp() should be able to fail
Diffstat (limited to 'arch/blackfin')
-rw-r--r-- | arch/blackfin/include/asm/flat.h | 25 | ||||
-rw-r--r-- | arch/blackfin/kernel/flat.c | 13 |
2 files changed, 21 insertions, 17 deletions
diff --git a/arch/blackfin/include/asm/flat.h b/arch/blackfin/include/asm/flat.h index c1314c56dd18..296d7f56fbfd 100644 --- a/arch/blackfin/include/asm/flat.h +++ b/arch/blackfin/include/asm/flat.h | |||
@@ -14,23 +14,28 @@ | |||
14 | #define flat_argvp_envp_on_stack() 0 | 14 | #define flat_argvp_envp_on_stack() 0 |
15 | #define flat_old_ram_flag(flags) (flags) | 15 | #define flat_old_ram_flag(flags) (flags) |
16 | 16 | ||
17 | extern unsigned long bfin_get_addr_from_rp (unsigned long *ptr, | 17 | extern unsigned long bfin_get_addr_from_rp (u32 *ptr, u32 relval, |
18 | unsigned long relval, | 18 | u32 flags, u32 *persistent); |
19 | unsigned long flags, | ||
20 | unsigned long *persistent); | ||
21 | 19 | ||
22 | extern void bfin_put_addr_at_rp(unsigned long *ptr, unsigned long addr, | 20 | extern void bfin_put_addr_at_rp(u32 *ptr, u32 addr, u32 relval); |
23 | unsigned long relval); | ||
24 | 21 | ||
25 | /* The amount by which a relocation can exceed the program image limits | 22 | /* The amount by which a relocation can exceed the program image limits |
26 | without being regarded as an error. */ | 23 | without being regarded as an error. */ |
27 | 24 | ||
28 | #define flat_reloc_valid(reloc, size) ((reloc) <= (size)) | 25 | #define flat_reloc_valid(reloc, size) ((reloc) <= (size)) |
29 | 26 | ||
30 | #define flat_get_addr_from_rp(rp, relval, flags, persistent) \ | 27 | static inline int flat_get_addr_from_rp(u32 __user *rp, u32 relval, u32 flags, |
31 | bfin_get_addr_from_rp(rp, relval, flags, persistent) | 28 | u32 *addr, u32 *persistent) |
32 | #define flat_put_addr_at_rp(rp, val, relval) \ | 29 | { |
33 | bfin_put_addr_at_rp(rp, val, relval) | 30 | *addr = bfin_get_addr_from_rp(rp, relval, flags, persistent); |
31 | return 0; | ||
32 | } | ||
33 | |||
34 | static inline int flat_put_addr_at_rp(u32 __user *rp, u32 val, u32 relval) | ||
35 | { | ||
36 | bfin_put_addr_at_rp(rp, val, relval); | ||
37 | return 0; | ||
38 | } | ||
34 | 39 | ||
35 | /* Convert a relocation entry into an address. */ | 40 | /* Convert a relocation entry into an address. */ |
36 | static inline unsigned long | 41 | static inline unsigned long |
diff --git a/arch/blackfin/kernel/flat.c b/arch/blackfin/kernel/flat.c index b5b658449616..d29ab6a2e909 100644 --- a/arch/blackfin/kernel/flat.c +++ b/arch/blackfin/kernel/flat.c | |||
@@ -13,14 +13,14 @@ | |||
13 | #define FLAT_BFIN_RELOC_TYPE_16H_BIT 1 | 13 | #define FLAT_BFIN_RELOC_TYPE_16H_BIT 1 |
14 | #define FLAT_BFIN_RELOC_TYPE_32_BIT 2 | 14 | #define FLAT_BFIN_RELOC_TYPE_32_BIT 2 |
15 | 15 | ||
16 | unsigned long bfin_get_addr_from_rp(unsigned long *ptr, | 16 | unsigned long bfin_get_addr_from_rp(u32 *ptr, |
17 | unsigned long relval, | 17 | u32 relval, |
18 | unsigned long flags, | 18 | u32 flags, |
19 | unsigned long *persistent) | 19 | u32 *persistent) |
20 | { | 20 | { |
21 | unsigned short *usptr = (unsigned short *)ptr; | 21 | unsigned short *usptr = (unsigned short *)ptr; |
22 | int type = (relval >> 26) & 7; | 22 | int type = (relval >> 26) & 7; |
23 | unsigned long val; | 23 | u32 val; |
24 | 24 | ||
25 | switch (type) { | 25 | switch (type) { |
26 | case FLAT_BFIN_RELOC_TYPE_16_BIT: | 26 | case FLAT_BFIN_RELOC_TYPE_16_BIT: |
@@ -59,8 +59,7 @@ EXPORT_SYMBOL(bfin_get_addr_from_rp); | |||
59 | * Insert the address ADDR into the symbol reference at RP; | 59 | * Insert the address ADDR into the symbol reference at RP; |
60 | * RELVAL is the raw relocation-table entry from which RP is derived | 60 | * RELVAL is the raw relocation-table entry from which RP is derived |
61 | */ | 61 | */ |
62 | void bfin_put_addr_at_rp(unsigned long *ptr, unsigned long addr, | 62 | void bfin_put_addr_at_rp(u32 *ptr, u32 addr, u32 relval) |
63 | unsigned long relval) | ||
64 | { | 63 | { |
65 | unsigned short *usptr = (unsigned short *)ptr; | 64 | unsigned short *usptr = (unsigned short *)ptr; |
66 | int type = (relval >> 26) & 7; | 65 | int type = (relval >> 26) & 7; |