diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-02-20 23:13:38 -0500 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-02-27 07:43:20 -0500 |
commit | b303c6df80c9f8f13785aa83a0471fca7e38b24d (patch) | |
tree | e5115e2524486b8633a4d024e9a1d2761f3c181f /Makefile | |
parent | bd55f96fa9fc29702ec30d75a4290bdadb00209d (diff) |
kbuild: compute false-positive -Wmaybe-uninitialized cases in Kconfig
Since -Wmaybe-uninitialized was introduced by GCC 4.7, we have patched
various false positives:
- commit e74fc973b6e5 ("Turn off -Wmaybe-uninitialized when building
with -Os") turned off this option for -Os.
- commit 815eb71e7149 ("Kbuild: disable 'maybe-uninitialized' warning
for CONFIG_PROFILE_ALL_BRANCHES") turned off this option for
CONFIG_PROFILE_ALL_BRANCHES
- commit a76bcf557ef4 ("Kbuild: enable -Wmaybe-uninitialized warning
for "make W=1"") turned off this option for GCC < 4.9
Arnd provided more explanation in https://lkml.org/lkml/2017/3/14/903
I think this looks better by shifting the logic from Makefile to Kconfig.
Link: https://github.com/ClangBuiltLinux/linux/issues/350
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Diffstat (limited to 'Makefile')
-rw-r--r-- | Makefile | 10 |
1 files changed, 3 insertions, 7 deletions
@@ -660,17 +660,13 @@ KBUILD_CFLAGS += $(call cc-disable-warning, int-in-bool-context) | |||
660 | 660 | ||
661 | ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE | 661 | ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE |
662 | KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) | 662 | KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) |
663 | KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) | ||
664 | else | ||
665 | ifdef CONFIG_PROFILE_ALL_BRANCHES | ||
666 | KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) | ||
667 | else | 663 | else |
668 | KBUILD_CFLAGS += -O2 | 664 | KBUILD_CFLAGS += -O2 |
669 | endif | 665 | endif |
670 | endif | ||
671 | 666 | ||
672 | KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0409, \ | 667 | ifdef CONFIG_CC_DISABLE_WARN_MAYBE_UNINITIALIZED |
673 | $(call cc-disable-warning,maybe-uninitialized,)) | 668 | KBUILD_CFLAGS += -Wno-maybe-uninitialized |
669 | endif | ||
674 | 670 | ||
675 | # Tell gcc to never replace conditional load with a non-conditional one | 671 | # Tell gcc to never replace conditional load with a non-conditional one |
676 | KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0) | 672 | KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0) |