summaryrefslogtreecommitdiffstats
path: root/Documentation/sysctl
diff options
context:
space:
mode:
authorJosh Poimboeuf <jpoimboe@redhat.com>2016-10-25 10:51:13 -0400
committerIngo Molnar <mingo@kernel.org>2016-10-25 12:40:37 -0400
commit0ee1dd9f5e7eae4e55f95935b72d4beecb03de9c (patch)
treed552e8dc63d8daac8e472accff99b6710b57348e /Documentation/sysctl
parentbb5e5ce545f2031c96f7901cd8d1698ea3ca4c9c (diff)
x86/dumpstack: Remove raw stack dump
For mostly historical reasons, the x86 oops dump shows the raw stack values: ... [registers] Stack: ffff880079af7350 ffff880079905400 0000000000000000 ffffc900008f3ae0 ffffffffa0196610 0000000000000001 00010000ffffffff 0000000087654321 0000000000000002 0000000000000000 0000000000000000 0000000000000000 Call Trace: ... This seems to be an artifact from long ago, and probably isn't needed anymore. It generally just adds noise to the dump, and it can be actively harmful because it leaks kernel addresses. Linus says: "The stack dump actually goes back to forever, and it used to be useful back in 1992 or so. But it used to be useful mainly because stacks were simpler and we didn't have very good call traces anyway. I definitely remember having used them - I just do not remember having used them in the last ten+ years. Of course, it's still true that if you can trigger an oops, you've likely already lost the security game, but since the stack dump is so useless, let's aim to just remove it and make games like the above harder." This also removes the related 'kstack=' cmdline option and the 'kstack_depth_to_print' sysctl. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/e83bd50df52d8fe88e94d2566426ae40d813bf8f.1477405374.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'Documentation/sysctl')
-rw-r--r--Documentation/sysctl/kernel.txt8
1 files changed, 0 insertions, 8 deletions
diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
index ffab8b5caa60..065f18478c1c 100644
--- a/Documentation/sysctl/kernel.txt
+++ b/Documentation/sysctl/kernel.txt
@@ -40,7 +40,6 @@ show up in /proc/sys/kernel:
40- hung_task_warnings 40- hung_task_warnings
41- kexec_load_disabled 41- kexec_load_disabled
42- kptr_restrict 42- kptr_restrict
43- kstack_depth_to_print [ X86 only ]
44- l2cr [ PPC only ] 43- l2cr [ PPC only ]
45- modprobe ==> Documentation/debugging-modules.txt 44- modprobe ==> Documentation/debugging-modules.txt
46- modules_disabled 45- modules_disabled
@@ -395,13 +394,6 @@ When kptr_restrict is set to (2), kernel pointers printed using
395 394
396============================================================== 395==============================================================
397 396
398kstack_depth_to_print: (X86 only)
399
400Controls the number of words to print when dumping the raw
401kernel stack.
402
403==============================================================
404
405l2cr: (PPC only) 397l2cr: (PPC only)
406 398
407This flag controls the L2 cache of G3 processor boards. If 399This flag controls the L2 cache of G3 processor boards. If