summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2018-06-18 11:11:14 -0400
committerJohannes Berg <johannes.berg@intel.com>2018-06-29 03:49:28 -0400
commitfe0984d38938249f3f11fc558a8845fc6f8a0105 (patch)
tree17567180d52ce42b221309252baa61aefdfd6961
parent8ba6731ad4c7e9f612b2f7dae1b5ed6bfc884b67 (diff)
cfg80211: track time using boottime
The cfg80211 layer uses get_seconds() to read the current time in its supend handling. This function is deprecated because of the 32-bit time_t overflow, and it can cause unexpected behavior when the time changes due to settimeofday() calls or leap second updates. In many cases, we want to use monotonic time instead, however cfg80211 explicitly tracks the time spent in suspend, so this changes the driver over to use ktime_get_boottime_seconds(), which is slightly slower, but not used in a fastpath here. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--net/wireless/core.h2
-rw-r--r--net/wireless/sysfs.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/net/wireless/core.h b/net/wireless/core.h
index 63eb1b5fdd04..7f52ef569320 100644
--- a/net/wireless/core.h
+++ b/net/wireless/core.h
@@ -76,7 +76,7 @@ struct cfg80211_registered_device {
76 struct cfg80211_scan_request *scan_req; /* protected by RTNL */ 76 struct cfg80211_scan_request *scan_req; /* protected by RTNL */
77 struct sk_buff *scan_msg; 77 struct sk_buff *scan_msg;
78 struct list_head sched_scan_req_list; 78 struct list_head sched_scan_req_list;
79 unsigned long suspend_at; 79 time64_t suspend_at;
80 struct work_struct scan_done_wk; 80 struct work_struct scan_done_wk;
81 81
82 struct genl_info *cur_cmd_info; 82 struct genl_info *cur_cmd_info;
diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c
index 570a2b67ca10..6ab32f6a1961 100644
--- a/net/wireless/sysfs.c
+++ b/net/wireless/sysfs.c
@@ -102,7 +102,7 @@ static int wiphy_suspend(struct device *dev)
102 struct cfg80211_registered_device *rdev = dev_to_rdev(dev); 102 struct cfg80211_registered_device *rdev = dev_to_rdev(dev);
103 int ret = 0; 103 int ret = 0;
104 104
105 rdev->suspend_at = get_seconds(); 105 rdev->suspend_at = ktime_get_boottime_seconds();
106 106
107 rtnl_lock(); 107 rtnl_lock();
108 if (rdev->wiphy.registered) { 108 if (rdev->wiphy.registered) {
@@ -130,7 +130,7 @@ static int wiphy_resume(struct device *dev)
130 int ret = 0; 130 int ret = 0;
131 131
132 /* Age scan results with time spent in suspend */ 132 /* Age scan results with time spent in suspend */
133 cfg80211_bss_age(rdev, get_seconds() - rdev->suspend_at); 133 cfg80211_bss_age(rdev, ktime_get_boottime_seconds() - rdev->suspend_at);
134 134
135 rtnl_lock(); 135 rtnl_lock();
136 if (rdev->wiphy.registered && rdev->ops->resume) 136 if (rdev->wiphy.registered && rdev->ops->resume)