diff options
author | Taehee Yoo <ap420073@gmail.com> | 2019-07-15 01:10:17 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-07-17 14:58:56 -0400 |
commit | fdd258d49e88a9e0b49ef04a506a796f1c768a8e (patch) | |
tree | 31ca49f36ebe8f5902ccf9dff707559847240864 | |
parent | a5b647007e9d794956dbed9339a3354a9fc4d5c3 (diff) |
caif-hsi: fix possible deadlock in cfhsi_exit_module()
cfhsi_exit_module() calls unregister_netdev() under rtnl_lock().
but unregister_netdev() internally calls rtnl_lock().
So deadlock would occur.
Fixes: c41254006377 ("caif-hsi: Add rtnl support")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/caif/caif_hsi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c index b2f10b6ad6e5..bbb2575d4728 100644 --- a/drivers/net/caif/caif_hsi.c +++ b/drivers/net/caif/caif_hsi.c | |||
@@ -1455,7 +1455,7 @@ static void __exit cfhsi_exit_module(void) | |||
1455 | rtnl_lock(); | 1455 | rtnl_lock(); |
1456 | list_for_each_safe(list_node, n, &cfhsi_list) { | 1456 | list_for_each_safe(list_node, n, &cfhsi_list) { |
1457 | cfhsi = list_entry(list_node, struct cfhsi, list); | 1457 | cfhsi = list_entry(list_node, struct cfhsi, list); |
1458 | unregister_netdev(cfhsi->ndev); | 1458 | unregister_netdevice(cfhsi->ndev); |
1459 | } | 1459 | } |
1460 | rtnl_unlock(); | 1460 | rtnl_unlock(); |
1461 | } | 1461 | } |