diff options
author | Bob Peterson <rpeterso@redhat.com> | 2019-05-13 10:42:18 -0400 |
---|---|---|
committer | Andreas Gruenbacher <agruenba@redhat.com> | 2019-06-27 15:30:27 -0400 |
commit | f29e62eed261f01431d348d8b22a6f275d553a51 (patch) | |
tree | 5aa07bda9a530d12a7d6090db71af1efc214755b | |
parent | 3792ce973f07a2644fd81424b9acacb12530a3cf (diff) |
gfs2: replace more printk with calls to fs_info and friends
This patch replaces a few leftover printk errors with calls to
fs_info and similar, so that the file system having the error is
properly logged.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
-rw-r--r-- | fs/gfs2/bmap.c | 5 | ||||
-rw-r--r-- | fs/gfs2/glops.c | 3 | ||||
-rw-r--r-- | fs/gfs2/rgrp.c | 27 | ||||
-rw-r--r-- | fs/gfs2/super.c | 6 |
4 files changed, 21 insertions, 20 deletions
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 93ea1d529aa3..3b761a0ba6ab 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c | |||
@@ -1862,9 +1862,8 @@ static int punch_hole(struct gfs2_inode *ip, u64 offset, u64 length) | |||
1862 | gfs2_assert_withdraw(sdp, bh); | 1862 | gfs2_assert_withdraw(sdp, bh); |
1863 | if (gfs2_assert_withdraw(sdp, | 1863 | if (gfs2_assert_withdraw(sdp, |
1864 | prev_bnr != bh->b_blocknr)) { | 1864 | prev_bnr != bh->b_blocknr)) { |
1865 | printk(KERN_EMERG "GFS2: fsid=%s:inode %llu, " | 1865 | fs_emerg(sdp, "inode %llu, block:%llu, i_h:%u," |
1866 | "block:%llu, i_h:%u, s_h:%u, mp_h:%u\n", | 1866 | "s_h:%u, mp_h:%u\n", |
1867 | sdp->sd_fsname, | ||
1868 | (unsigned long long)ip->i_no_addr, | 1867 | (unsigned long long)ip->i_no_addr, |
1869 | prev_bnr, ip->i_height, strip_h, mp_h); | 1868 | prev_bnr, ip->i_height, strip_h, mp_h); |
1870 | } | 1869 | } |
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 68e2a2d4e6a6..ff213690e364 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c | |||
@@ -506,7 +506,8 @@ static void freeze_go_sync(struct gfs2_glock *gl) | |||
506 | atomic_set(&sdp->sd_freeze_state, SFS_STARTING_FREEZE); | 506 | atomic_set(&sdp->sd_freeze_state, SFS_STARTING_FREEZE); |
507 | error = freeze_super(sdp->sd_vfs); | 507 | error = freeze_super(sdp->sd_vfs); |
508 | if (error) { | 508 | if (error) { |
509 | printk(KERN_INFO "GFS2: couldn't freeze filesystem: %d\n", error); | 509 | fs_info(sdp, "GFS2: couldn't freeze filesystem: %d\n", |
510 | error); | ||
510 | gfs2_assert_withdraw(sdp, 0); | 511 | gfs2_assert_withdraw(sdp, 0); |
511 | } | 512 | } |
512 | queue_work(gfs2_freeze_wq, &sdp->sd_freeze_work); | 513 | queue_work(gfs2_freeze_wq, &sdp->sd_freeze_work); |
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index a60b36fdbdd6..49ac0a5e74ea 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c | |||
@@ -1112,32 +1112,33 @@ static int gfs2_rgrp_lvb_valid(struct gfs2_rgrpd *rgd) | |||
1112 | { | 1112 | { |
1113 | struct gfs2_rgrp_lvb *rgl = rgd->rd_rgl; | 1113 | struct gfs2_rgrp_lvb *rgl = rgd->rd_rgl; |
1114 | struct gfs2_rgrp *str = (struct gfs2_rgrp *)rgd->rd_bits[0].bi_bh->b_data; | 1114 | struct gfs2_rgrp *str = (struct gfs2_rgrp *)rgd->rd_bits[0].bi_bh->b_data; |
1115 | struct gfs2_sbd *sdp = rgd->rd_sbd; | ||
1115 | int valid = 1; | 1116 | int valid = 1; |
1116 | 1117 | ||
1117 | if (rgl->rl_flags != str->rg_flags) { | 1118 | if (rgl->rl_flags != str->rg_flags) { |
1118 | printk(KERN_WARNING "GFS2: rgd: %llu lvb flag mismatch %u/%u", | 1119 | fs_warn(sdp, "GFS2: rgd: %llu lvb flag mismatch %u/%u", |
1119 | (unsigned long long)rgd->rd_addr, | 1120 | (unsigned long long)rgd->rd_addr, |
1120 | be32_to_cpu(rgl->rl_flags), be32_to_cpu(str->rg_flags)); | 1121 | be32_to_cpu(rgl->rl_flags), be32_to_cpu(str->rg_flags)); |
1121 | valid = 0; | 1122 | valid = 0; |
1122 | } | 1123 | } |
1123 | if (rgl->rl_free != str->rg_free) { | 1124 | if (rgl->rl_free != str->rg_free) { |
1124 | printk(KERN_WARNING "GFS2: rgd: %llu lvb free mismatch %u/%u", | 1125 | fs_warn(sdp, "GFS2: rgd: %llu lvb free mismatch %u/%u", |
1125 | (unsigned long long)rgd->rd_addr, | 1126 | (unsigned long long)rgd->rd_addr, |
1126 | be32_to_cpu(rgl->rl_free), be32_to_cpu(str->rg_free)); | 1127 | be32_to_cpu(rgl->rl_free), be32_to_cpu(str->rg_free)); |
1127 | valid = 0; | 1128 | valid = 0; |
1128 | } | 1129 | } |
1129 | if (rgl->rl_dinodes != str->rg_dinodes) { | 1130 | if (rgl->rl_dinodes != str->rg_dinodes) { |
1130 | printk(KERN_WARNING "GFS2: rgd: %llu lvb dinode mismatch %u/%u", | 1131 | fs_warn(sdp, "GFS2: rgd: %llu lvb dinode mismatch %u/%u", |
1131 | (unsigned long long)rgd->rd_addr, | 1132 | (unsigned long long)rgd->rd_addr, |
1132 | be32_to_cpu(rgl->rl_dinodes), | 1133 | be32_to_cpu(rgl->rl_dinodes), |
1133 | be32_to_cpu(str->rg_dinodes)); | 1134 | be32_to_cpu(str->rg_dinodes)); |
1134 | valid = 0; | 1135 | valid = 0; |
1135 | } | 1136 | } |
1136 | if (rgl->rl_igeneration != str->rg_igeneration) { | 1137 | if (rgl->rl_igeneration != str->rg_igeneration) { |
1137 | printk(KERN_WARNING "GFS2: rgd: %llu lvb igen mismatch " | 1138 | fs_warn(sdp, "GFS2: rgd: %llu lvb igen mismatch %llu/%llu", |
1138 | "%llu/%llu", (unsigned long long)rgd->rd_addr, | 1139 | (unsigned long long)rgd->rd_addr, |
1139 | (unsigned long long)be64_to_cpu(rgl->rl_igeneration), | 1140 | (unsigned long long)be64_to_cpu(rgl->rl_igeneration), |
1140 | (unsigned long long)be64_to_cpu(str->rg_igeneration)); | 1141 | (unsigned long long)be64_to_cpu(str->rg_igeneration)); |
1141 | valid = 0; | 1142 | valid = 0; |
1142 | } | 1143 | } |
1143 | return valid; | 1144 | return valid; |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 3eae973d525f..0acc5834f653 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -978,14 +978,14 @@ void gfs2_freeze_func(struct work_struct *work) | |||
978 | error = gfs2_glock_nq_init(sdp->sd_freeze_gl, LM_ST_SHARED, 0, | 978 | error = gfs2_glock_nq_init(sdp->sd_freeze_gl, LM_ST_SHARED, 0, |
979 | &freeze_gh); | 979 | &freeze_gh); |
980 | if (error) { | 980 | if (error) { |
981 | printk(KERN_INFO "GFS2: couldn't get freeze lock : %d\n", error); | 981 | fs_info(sdp, "GFS2: couldn't get freeze lock : %d\n", error); |
982 | gfs2_assert_withdraw(sdp, 0); | 982 | gfs2_assert_withdraw(sdp, 0); |
983 | } else { | 983 | } else { |
984 | atomic_set(&sdp->sd_freeze_state, SFS_UNFROZEN); | 984 | atomic_set(&sdp->sd_freeze_state, SFS_UNFROZEN); |
985 | error = thaw_super(sb); | 985 | error = thaw_super(sb); |
986 | if (error) { | 986 | if (error) { |
987 | printk(KERN_INFO "GFS2: couldn't thaw filesystem: %d\n", | 987 | fs_info(sdp, "GFS2: couldn't thaw filesystem: %d\n", |
988 | error); | 988 | error); |
989 | gfs2_assert_withdraw(sdp, 0); | 989 | gfs2_assert_withdraw(sdp, 0); |
990 | } | 990 | } |
991 | if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags)) | 991 | if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags)) |