summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia.lawall@lip6.fr>2016-10-01 16:53:11 -0400
committerRichard Weinberger <richard@nod.at>2016-10-02 16:55:02 -0400
commitec037dfcc064f5f81982c78e95bab783568ae35f (patch)
tree94f6b99bab92ed234480d528c12a6e93424b41de
parent74e9c700bcb7529a0ab3f57d1125f4494ec97b3c (diff)
UBIFS: improve function-level documentation
Fix various inconsistencies in the documentation associated with various functions. In the case of fs/ubifs/lprops.c, the second parameter of ubifs_get_lp_stats was renamed from st to lst in commit 84abf972ccff ("UBIFS: add re-mount debugging checks") In the case of fs/ubifs/lpt_commit.c, the excess variables have never existed in the associated functions since the code was introduced into the kernel. The others appear to be straightforward typos. Issues detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Richard Weinberger <richard@nod.at>
-rw-r--r--fs/ubifs/file.c2
-rw-r--r--fs/ubifs/gc.c2
-rw-r--r--fs/ubifs/lprops.c2
-rw-r--r--fs/ubifs/lpt_commit.c4
-rw-r--r--fs/ubifs/replay.c2
5 files changed, 5 insertions, 7 deletions
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 7bbf420d1289..4ed270beabbc 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1397,7 +1397,7 @@ int ubifs_update_time(struct inode *inode, struct timespec *time,
1397#endif 1397#endif
1398 1398
1399/** 1399/**
1400 * update_ctime - update mtime and ctime of an inode. 1400 * update_mctime - update mtime and ctime of an inode.
1401 * @inode: inode to update 1401 * @inode: inode to update
1402 * 1402 *
1403 * This function updates mtime and ctime of the inode if it is not equivalent to 1403 * This function updates mtime and ctime of the inode if it is not equivalent to
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index 821b34816976..e845c64b6ce1 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -113,7 +113,7 @@ static int switch_gc_head(struct ubifs_info *c)
113 * data_nodes_cmp - compare 2 data nodes. 113 * data_nodes_cmp - compare 2 data nodes.
114 * @priv: UBIFS file-system description object 114 * @priv: UBIFS file-system description object
115 * @a: first data node 115 * @a: first data node
116 * @a: second data node 116 * @b: second data node
117 * 117 *
118 * This function compares data nodes @a and @b. Returns %1 if @a has greater 118 * This function compares data nodes @a and @b. Returns %1 if @a has greater
119 * inode or block number, and %-1 otherwise. 119 * inode or block number, and %-1 otherwise.
diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c
index a0011aa3a779..6c3a1abd0e22 100644
--- a/fs/ubifs/lprops.c
+++ b/fs/ubifs/lprops.c
@@ -636,7 +636,7 @@ const struct ubifs_lprops *ubifs_change_lp(struct ubifs_info *c,
636/** 636/**
637 * ubifs_get_lp_stats - get lprops statistics. 637 * ubifs_get_lp_stats - get lprops statistics.
638 * @c: UBIFS file-system description object 638 * @c: UBIFS file-system description object
639 * @st: return statistics 639 * @lst: return statistics
640 */ 640 */
641void ubifs_get_lp_stats(struct ubifs_info *c, struct ubifs_lp_stats *lst) 641void ubifs_get_lp_stats(struct ubifs_info *c, struct ubifs_lp_stats *lst)
642{ 642{
diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
index ce89bdc3eb02..235654c2fe89 100644
--- a/fs/ubifs/lpt_commit.c
+++ b/fs/ubifs/lpt_commit.c
@@ -34,7 +34,6 @@ static int dbg_populate_lsave(struct ubifs_info *c);
34 34
35/** 35/**
36 * first_dirty_cnode - find first dirty cnode. 36 * first_dirty_cnode - find first dirty cnode.
37 * @c: UBIFS file-system description object
38 * @nnode: nnode at which to start 37 * @nnode: nnode at which to start
39 * 38 *
40 * This function returns the first dirty cnode or %NULL if there is not one. 39 * This function returns the first dirty cnode or %NULL if there is not one.
@@ -1623,7 +1622,6 @@ static int dbg_is_node_dirty(struct ubifs_info *c, int node_type, int lnum,
1623 * dbg_check_ltab_lnum - check the ltab for a LPT LEB number. 1622 * dbg_check_ltab_lnum - check the ltab for a LPT LEB number.
1624 * @c: the UBIFS file-system description object 1623 * @c: the UBIFS file-system description object
1625 * @lnum: LEB number where node was written 1624 * @lnum: LEB number where node was written
1626 * @offs: offset where node was written
1627 * 1625 *
1628 * This function returns %0 on success and a negative error code on failure. 1626 * This function returns %0 on success and a negative error code on failure.
1629 */ 1627 */
@@ -1870,7 +1868,7 @@ int dbg_chk_lpt_sz(struct ubifs_info *c, int action, int len)
1870} 1868}
1871 1869
1872/** 1870/**
1873 * ubifs_dump_lpt_leb - dump an LPT LEB. 1871 * dump_lpt_leb - dump an LPT LEB.
1874 * @c: UBIFS file-system description object 1872 * @c: UBIFS file-system description object
1875 * @lnum: LEB number to dump 1873 * @lnum: LEB number to dump
1876 * 1874 *
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
index 3ca4540130b5..fb0f44cd1e28 100644
--- a/fs/ubifs/replay.c
+++ b/fs/ubifs/replay.c
@@ -267,7 +267,7 @@ static int apply_replay_entry(struct ubifs_info *c, struct replay_entry *r)
267 * replay_entries_cmp - compare 2 replay entries. 267 * replay_entries_cmp - compare 2 replay entries.
268 * @priv: UBIFS file-system description object 268 * @priv: UBIFS file-system description object
269 * @a: first replay entry 269 * @a: first replay entry
270 * @a: second replay entry 270 * @b: second replay entry
271 * 271 *
272 * This is a comparios function for 'list_sort()' which compares 2 replay 272 * This is a comparios function for 'list_sort()' which compares 2 replay
273 * entries @a and @b by comparing their sequence numer. Returns %1 if @a has 273 * entries @a and @b by comparing their sequence numer. Returns %1 if @a has