summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnna Schumaker <Anna.Schumaker@Netapp.com>2017-04-07 14:15:09 -0400
committerTrond Myklebust <trond.myklebust@primarydata.com>2017-04-20 13:39:34 -0400
commite36d48e9e2c38e7d31c41e41b21f1f47b61250a9 (patch)
tree0ef6c229d0d2494f8b3be3cfca5bd38ae6f74478
parentfe4f844d49768909150d9c91e283106adcd9a1ea (diff)
NFS: Remove extra dprintk()s from namespace.c
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
-rw-r--r--fs/nfs/namespace.c34
1 files changed, 8 insertions, 26 deletions
diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c
index 786f17580582..1a224a33a6c2 100644
--- a/fs/nfs/namespace.c
+++ b/fs/nfs/namespace.c
@@ -143,11 +143,8 @@ struct vfsmount *nfs_d_automount(struct path *path)
143 struct nfs_fh *fh = NULL; 143 struct nfs_fh *fh = NULL;
144 struct nfs_fattr *fattr = NULL; 144 struct nfs_fattr *fattr = NULL;
145 145
146 dprintk("--> nfs_d_automount()\n");
147
148 mnt = ERR_PTR(-ESTALE);
149 if (IS_ROOT(path->dentry)) 146 if (IS_ROOT(path->dentry))
150 goto out_nofree; 147 return ERR_PTR(-ESTALE);
151 148
152 mnt = ERR_PTR(-ENOMEM); 149 mnt = ERR_PTR(-ENOMEM);
153 fh = nfs_alloc_fhandle(); 150 fh = nfs_alloc_fhandle();
@@ -155,13 +152,10 @@ struct vfsmount *nfs_d_automount(struct path *path)
155 if (fh == NULL || fattr == NULL) 152 if (fh == NULL || fattr == NULL)
156 goto out; 153 goto out;
157 154
158 dprintk("%s: enter\n", __func__);
159
160 mnt = server->nfs_client->rpc_ops->submount(server, path->dentry, fh, fattr); 155 mnt = server->nfs_client->rpc_ops->submount(server, path->dentry, fh, fattr);
161 if (IS_ERR(mnt)) 156 if (IS_ERR(mnt))
162 goto out; 157 goto out;
163 158
164 dprintk("%s: done, success\n", __func__);
165 mntget(mnt); /* prevent immediate expiration */ 159 mntget(mnt); /* prevent immediate expiration */
166 mnt_set_expiry(mnt, &nfs_automount_list); 160 mnt_set_expiry(mnt, &nfs_automount_list);
167 schedule_delayed_work(&nfs_automount_task, nfs_mountpoint_expiry_timeout); 161 schedule_delayed_work(&nfs_automount_task, nfs_mountpoint_expiry_timeout);
@@ -169,11 +163,6 @@ struct vfsmount *nfs_d_automount(struct path *path)
169out: 163out:
170 nfs_free_fattr(fattr); 164 nfs_free_fattr(fattr);
171 nfs_free_fhandle(fh); 165 nfs_free_fhandle(fh);
172out_nofree:
173 if (IS_ERR(mnt))
174 dprintk("<-- %s(): error %ld\n", __func__, PTR_ERR(mnt));
175 else
176 dprintk("<-- %s() = %p\n", __func__, mnt);
177 return mnt; 166 return mnt;
178} 167}
179 168
@@ -248,27 +237,20 @@ struct vfsmount *nfs_do_submount(struct dentry *dentry, struct nfs_fh *fh,
248 .fattr = fattr, 237 .fattr = fattr,
249 .authflavor = authflavor, 238 .authflavor = authflavor,
250 }; 239 };
251 struct vfsmount *mnt = ERR_PTR(-ENOMEM); 240 struct vfsmount *mnt;
252 char *page = (char *) __get_free_page(GFP_USER); 241 char *page = (char *) __get_free_page(GFP_USER);
253 char *devname; 242 char *devname;
254 243
255 dprintk("--> nfs_do_submount()\n");
256
257 dprintk("%s: submounting on %pd2\n", __func__,
258 dentry);
259 if (page == NULL) 244 if (page == NULL)
260 goto out; 245 return ERR_PTR(-ENOMEM);
246
261 devname = nfs_devname(dentry, page, PAGE_SIZE); 247 devname = nfs_devname(dentry, page, PAGE_SIZE);
262 mnt = (struct vfsmount *)devname;
263 if (IS_ERR(devname)) 248 if (IS_ERR(devname))
264 goto free_page; 249 mnt = (struct vfsmount *)devname;
265 mnt = nfs_do_clone_mount(NFS_SB(dentry->d_sb), devname, &mountdata); 250 else
266free_page: 251 mnt = nfs_do_clone_mount(NFS_SB(dentry->d_sb), devname, &mountdata);
267 free_page((unsigned long)page);
268out:
269 dprintk("%s: done\n", __func__);
270 252
271 dprintk("<-- nfs_do_submount() = %p\n", mnt); 253 free_page((unsigned long)page);
272 return mnt; 254 return mnt;
273} 255}
274EXPORT_SYMBOL_GPL(nfs_do_submount); 256EXPORT_SYMBOL_GPL(nfs_do_submount);