diff options
author | Colin Ian King <colin.king@canonical.com> | 2017-11-28 13:23:39 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2017-12-02 16:42:33 -0500 |
commit | e2843cb6cd6ba433d18d87e3e922b6e49ecccf01 (patch) | |
tree | 19a4a01fe75ccad32edaeb4244f1c153c92c0cca | |
parent | deb2e713ba54e87320cca4e3a62d3a88477b4ded (diff) |
gpio: gpio-stmpe: make various char arrays static const, shrinks object size
Don't populate the read-only arrays edge_det_values, rise_values and
fall_values on the stack but instead make them static and constify them.
Makes the object code smaller by over 240 bytes:
Before:
text data bss dec hex filename
9525 2520 192 12237 2fcd drivers/gpio/gpio-stmpe.o
After:
text data bss dec hex filename
9025 2776 192 11993 2ed9 drivers/gpio/gpio-stmpe.o
(gcc version 7.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/gpio/gpio-stmpe.c | 24 |
1 files changed, 15 insertions, 9 deletions
diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c index e6e5cca624a7..e3d048e65339 100644 --- a/drivers/gpio/gpio-stmpe.c +++ b/drivers/gpio/gpio-stmpe.c | |||
@@ -273,15 +273,21 @@ static void stmpe_dbg_show_one(struct seq_file *s, | |||
273 | u8 fall_reg; | 273 | u8 fall_reg; |
274 | u8 irqen_reg; | 274 | u8 irqen_reg; |
275 | 275 | ||
276 | char *edge_det_values[] = {"edge-inactive", | 276 | static const char * const edge_det_values[] = { |
277 | "edge-asserted", | 277 | "edge-inactive", |
278 | "not-supported"}; | 278 | "edge-asserted", |
279 | char *rise_values[] = {"no-rising-edge-detection", | 279 | "not-supported" |
280 | "rising-edge-detection", | 280 | }; |
281 | "not-supported"}; | 281 | static const char * const rise_values[] = { |
282 | char *fall_values[] = {"no-falling-edge-detection", | 282 | "no-rising-edge-detection", |
283 | "falling-edge-detection", | 283 | "rising-edge-detection", |
284 | "not-supported"}; | 284 | "not-supported" |
285 | }; | ||
286 | static const char * const fall_values[] = { | ||
287 | "no-falling-edge-detection", | ||
288 | "falling-edge-detection", | ||
289 | "not-supported" | ||
290 | }; | ||
285 | #define NOT_SUPPORTED_IDX 2 | 291 | #define NOT_SUPPORTED_IDX 2 |
286 | u8 edge_det = NOT_SUPPORTED_IDX; | 292 | u8 edge_det = NOT_SUPPORTED_IDX; |
287 | u8 rise = NOT_SUPPORTED_IDX; | 293 | u8 rise = NOT_SUPPORTED_IDX; |