summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Schatzberg <dschatzberg@fb.com>2019-05-14 18:41:18 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2019-05-14 22:52:48 -0400
commitdf5ba5be7425e1df296d40c5f37a39d98ec666a2 (patch)
tree3e499ed248db41188978e6a0474233c8cd7d8f50
parent0e94682b73bfa6c44c98af7a26771c9c08c055d5 (diff)
kernel/sched/psi.c: expose pressure metrics on root cgroup
Pressure metrics are already recorded and exposed in procfs for the entire system, but any tool which monitors cgroup pressure has to special case the root cgroup to read from procfs. This patch exposes the already recorded pressure metrics on the root cgroup. Link: http://lkml.kernel.org/r/20190510174938.3361741-1-dschatzberg@fb.com Signed-off-by: Dan Schatzberg <dschatzberg@fb.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Tejun Heo <tj@kernel.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--include/linux/psi.h1
-rw-r--r--kernel/cgroup/cgroup.c18
-rw-r--r--kernel/sched/psi.c2
3 files changed, 14 insertions, 7 deletions
diff --git a/include/linux/psi.h b/include/linux/psi.h
index af892c290116..7b3de7321219 100644
--- a/include/linux/psi.h
+++ b/include/linux/psi.h
@@ -12,6 +12,7 @@ struct css_set;
12#ifdef CONFIG_PSI 12#ifdef CONFIG_PSI
13 13
14extern struct static_key_false psi_disabled; 14extern struct static_key_false psi_disabled;
15extern struct psi_group psi_system;
15 16
16void psi_init(void); 17void psi_init(void);
17 18
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 1140357d46f4..217cec4e22c6 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -3540,15 +3540,24 @@ static int cpu_stat_show(struct seq_file *seq, void *v)
3540#ifdef CONFIG_PSI 3540#ifdef CONFIG_PSI
3541static int cgroup_io_pressure_show(struct seq_file *seq, void *v) 3541static int cgroup_io_pressure_show(struct seq_file *seq, void *v)
3542{ 3542{
3543 return psi_show(seq, &seq_css(seq)->cgroup->psi, PSI_IO); 3543 struct cgroup *cgroup = seq_css(seq)->cgroup;
3544 struct psi_group *psi = cgroup->id == 1 ? &psi_system : &cgroup->psi;
3545
3546 return psi_show(seq, psi, PSI_IO);
3544} 3547}
3545static int cgroup_memory_pressure_show(struct seq_file *seq, void *v) 3548static int cgroup_memory_pressure_show(struct seq_file *seq, void *v)
3546{ 3549{
3547 return psi_show(seq, &seq_css(seq)->cgroup->psi, PSI_MEM); 3550 struct cgroup *cgroup = seq_css(seq)->cgroup;
3551 struct psi_group *psi = cgroup->id == 1 ? &psi_system : &cgroup->psi;
3552
3553 return psi_show(seq, psi, PSI_MEM);
3548} 3554}
3549static int cgroup_cpu_pressure_show(struct seq_file *seq, void *v) 3555static int cgroup_cpu_pressure_show(struct seq_file *seq, void *v)
3550{ 3556{
3551 return psi_show(seq, &seq_css(seq)->cgroup->psi, PSI_CPU); 3557 struct cgroup *cgroup = seq_css(seq)->cgroup;
3558 struct psi_group *psi = cgroup->id == 1 ? &psi_system : &cgroup->psi;
3559
3560 return psi_show(seq, psi, PSI_CPU);
3552} 3561}
3553 3562
3554static ssize_t cgroup_pressure_write(struct kernfs_open_file *of, char *buf, 3563static ssize_t cgroup_pressure_write(struct kernfs_open_file *of, char *buf,
@@ -4801,7 +4810,6 @@ static struct cftype cgroup_base_files[] = {
4801#ifdef CONFIG_PSI 4810#ifdef CONFIG_PSI
4802 { 4811 {
4803 .name = "io.pressure", 4812 .name = "io.pressure",
4804 .flags = CFTYPE_NOT_ON_ROOT,
4805 .seq_show = cgroup_io_pressure_show, 4813 .seq_show = cgroup_io_pressure_show,
4806 .write = cgroup_io_pressure_write, 4814 .write = cgroup_io_pressure_write,
4807 .poll = cgroup_pressure_poll, 4815 .poll = cgroup_pressure_poll,
@@ -4809,7 +4817,6 @@ static struct cftype cgroup_base_files[] = {
4809 }, 4817 },
4810 { 4818 {
4811 .name = "memory.pressure", 4819 .name = "memory.pressure",
4812 .flags = CFTYPE_NOT_ON_ROOT,
4813 .seq_show = cgroup_memory_pressure_show, 4820 .seq_show = cgroup_memory_pressure_show,
4814 .write = cgroup_memory_pressure_write, 4821 .write = cgroup_memory_pressure_write,
4815 .poll = cgroup_pressure_poll, 4822 .poll = cgroup_pressure_poll,
@@ -4817,7 +4824,6 @@ static struct cftype cgroup_base_files[] = {
4817 }, 4824 },
4818 { 4825 {
4819 .name = "cpu.pressure", 4826 .name = "cpu.pressure",
4820 .flags = CFTYPE_NOT_ON_ROOT,
4821 .seq_show = cgroup_cpu_pressure_show, 4827 .seq_show = cgroup_cpu_pressure_show,
4822 .write = cgroup_cpu_pressure_write, 4828 .write = cgroup_cpu_pressure_write,
4823 .poll = cgroup_pressure_poll, 4829 .poll = cgroup_pressure_poll,
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index e88918e0bb6d..7acc632c3b82 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -173,7 +173,7 @@ static u64 psi_period __read_mostly;
173 173
174/* System-level pressure and stall tracking */ 174/* System-level pressure and stall tracking */
175static DEFINE_PER_CPU(struct psi_group_cpu, system_group_pcpu); 175static DEFINE_PER_CPU(struct psi_group_cpu, system_group_pcpu);
176static struct psi_group psi_system = { 176struct psi_group psi_system = {
177 .pcpu = &system_group_pcpu, 177 .pcpu = &system_group_pcpu,
178}; 178};
179 179