diff options
author | Takashi Iwai <tiwai@suse.de> | 2019-08-14 13:59:44 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2019-08-14 14:00:56 -0400 |
commit | ddf7cb83b0f45feb94ad89a987f600c766c463ca (patch) | |
tree | e5fb54d43450875854700c73a96415a2b1a7502c | |
parent | 53eff75e5f4dd4b9bc489955fdc60fde48d85e93 (diff) |
ALSA: hda: Unexport a few more stuff
Drop EXPORT_SYMBOL*() from a few more stuff in HD-audio core that
aren't used outside. Particular the unsol event handler can be
staticized now because the recent change removed all external
callers.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r-- | include/sound/hdaudio.h | 6 | ||||
-rw-r--r-- | sound/hda/hdac_bus.c | 5 | ||||
-rw-r--r-- | sound/hda/hdac_device.c | 6 | ||||
-rw-r--r-- | sound/hda/hdac_regmap.c | 1 | ||||
-rw-r--r-- | sound/hda/local.h | 3 |
5 files changed, 9 insertions, 12 deletions
diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h index edb176a265c7..b260c5fd2337 100644 --- a/include/sound/hdaudio.h +++ b/include/sound/hdaudio.h | |||
@@ -122,10 +122,6 @@ int snd_hdac_codec_modalias(struct hdac_device *hdac, char *buf, size_t size); | |||
122 | 122 | ||
123 | int snd_hdac_refresh_widgets(struct hdac_device *codec); | 123 | int snd_hdac_refresh_widgets(struct hdac_device *codec); |
124 | 124 | ||
125 | unsigned int snd_hdac_make_cmd(struct hdac_device *codec, hda_nid_t nid, | ||
126 | unsigned int verb, unsigned int parm); | ||
127 | int snd_hdac_exec_verb(struct hdac_device *codec, unsigned int cmd, | ||
128 | unsigned int flags, unsigned int *res); | ||
129 | int snd_hdac_read(struct hdac_device *codec, hda_nid_t nid, | 125 | int snd_hdac_read(struct hdac_device *codec, hda_nid_t nid, |
130 | unsigned int verb, unsigned int parm, unsigned int *res); | 126 | unsigned int verb, unsigned int parm, unsigned int *res); |
131 | int _snd_hdac_read_parm(struct hdac_device *codec, hda_nid_t nid, int parm, | 127 | int _snd_hdac_read_parm(struct hdac_device *codec, hda_nid_t nid, int parm, |
@@ -374,8 +370,6 @@ int snd_hdac_bus_exec_verb_unlocked(struct hdac_bus *bus, unsigned int addr, | |||
374 | unsigned int cmd, unsigned int *res); | 370 | unsigned int cmd, unsigned int *res); |
375 | void snd_hdac_bus_queue_event(struct hdac_bus *bus, u32 res, u32 res_ex); | 371 | void snd_hdac_bus_queue_event(struct hdac_bus *bus, u32 res, u32 res_ex); |
376 | 372 | ||
377 | void snd_hdac_bus_process_unsol_events(struct work_struct *work); | ||
378 | |||
379 | static inline void snd_hdac_codec_link_up(struct hdac_device *codec) | 373 | static inline void snd_hdac_codec_link_up(struct hdac_device *codec) |
380 | { | 374 | { |
381 | set_bit(codec->addr, &codec->bus->codec_powered); | 375 | set_bit(codec->addr, &codec->bus->codec_powered); |
diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c index 18ed3185df82..8f19876244eb 100644 --- a/sound/hda/hdac_bus.c +++ b/sound/hda/hdac_bus.c | |||
@@ -12,6 +12,8 @@ | |||
12 | #include "local.h" | 12 | #include "local.h" |
13 | #include "trace.h" | 13 | #include "trace.h" |
14 | 14 | ||
15 | static void snd_hdac_bus_process_unsol_events(struct work_struct *work); | ||
16 | |||
15 | static const struct hdac_bus_ops default_ops = { | 17 | static const struct hdac_bus_ops default_ops = { |
16 | .command = snd_hdac_bus_send_cmd, | 18 | .command = snd_hdac_bus_send_cmd, |
17 | .get_response = snd_hdac_bus_get_response, | 19 | .get_response = snd_hdac_bus_get_response, |
@@ -149,7 +151,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_bus_queue_event); | |||
149 | /* | 151 | /* |
150 | * process queued unsolicited events | 152 | * process queued unsolicited events |
151 | */ | 153 | */ |
152 | void snd_hdac_bus_process_unsol_events(struct work_struct *work) | 154 | static void snd_hdac_bus_process_unsol_events(struct work_struct *work) |
153 | { | 155 | { |
154 | struct hdac_bus *bus = container_of(work, struct hdac_bus, unsol_work); | 156 | struct hdac_bus *bus = container_of(work, struct hdac_bus, unsol_work); |
155 | struct hdac_device *codec; | 157 | struct hdac_device *codec; |
@@ -172,7 +174,6 @@ void snd_hdac_bus_process_unsol_events(struct work_struct *work) | |||
172 | drv->unsol_event(codec, res); | 174 | drv->unsol_event(codec, res); |
173 | } | 175 | } |
174 | } | 176 | } |
175 | EXPORT_SYMBOL_GPL(snd_hdac_bus_process_unsol_events); | ||
176 | 177 | ||
177 | /** | 178 | /** |
178 | * snd_hdac_bus_add_device - Add a codec to bus | 179 | * snd_hdac_bus_add_device - Add a codec to bus |
diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c index 033bcef8751a..bf83d7062ef6 100644 --- a/sound/hda/hdac_device.c +++ b/sound/hda/hdac_device.c | |||
@@ -221,8 +221,8 @@ EXPORT_SYMBOL_GPL(snd_hdac_codec_modalias); | |||
221 | * | 221 | * |
222 | * Return an encoded command verb or -1 for error. | 222 | * Return an encoded command verb or -1 for error. |
223 | */ | 223 | */ |
224 | unsigned int snd_hdac_make_cmd(struct hdac_device *codec, hda_nid_t nid, | 224 | static unsigned int snd_hdac_make_cmd(struct hdac_device *codec, hda_nid_t nid, |
225 | unsigned int verb, unsigned int parm) | 225 | unsigned int verb, unsigned int parm) |
226 | { | 226 | { |
227 | u32 val, addr; | 227 | u32 val, addr; |
228 | 228 | ||
@@ -240,7 +240,6 @@ unsigned int snd_hdac_make_cmd(struct hdac_device *codec, hda_nid_t nid, | |||
240 | val |= parm; | 240 | val |= parm; |
241 | return val; | 241 | return val; |
242 | } | 242 | } |
243 | EXPORT_SYMBOL_GPL(snd_hdac_make_cmd); | ||
244 | 243 | ||
245 | /** | 244 | /** |
246 | * snd_hdac_exec_verb - execute an encoded verb | 245 | * snd_hdac_exec_verb - execute an encoded verb |
@@ -261,7 +260,6 @@ int snd_hdac_exec_verb(struct hdac_device *codec, unsigned int cmd, | |||
261 | return codec->exec_verb(codec, cmd, flags, res); | 260 | return codec->exec_verb(codec, cmd, flags, res); |
262 | return snd_hdac_bus_exec_verb(codec->bus, codec->addr, cmd, res); | 261 | return snd_hdac_bus_exec_verb(codec->bus, codec->addr, cmd, res); |
263 | } | 262 | } |
264 | EXPORT_SYMBOL_GPL(snd_hdac_exec_verb); | ||
265 | 263 | ||
266 | 264 | ||
267 | /** | 265 | /** |
diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c index f399a1552e73..286361ecd640 100644 --- a/sound/hda/hdac_regmap.c +++ b/sound/hda/hdac_regmap.c | |||
@@ -21,6 +21,7 @@ | |||
21 | #include <sound/core.h> | 21 | #include <sound/core.h> |
22 | #include <sound/hdaudio.h> | 22 | #include <sound/hdaudio.h> |
23 | #include <sound/hda_regmap.h> | 23 | #include <sound/hda_regmap.h> |
24 | #include "local.h" | ||
24 | 25 | ||
25 | static int codec_pm_lock(struct hdac_device *codec) | 26 | static int codec_pm_lock(struct hdac_device *codec) |
26 | { | 27 | { |
diff --git a/sound/hda/local.h b/sound/hda/local.h index 3a4e303169a6..5b935219352f 100644 --- a/sound/hda/local.h +++ b/sound/hda/local.h | |||
@@ -37,4 +37,7 @@ int snd_hdac_bus_add_device(struct hdac_bus *bus, struct hdac_device *codec); | |||
37 | void snd_hdac_bus_remove_device(struct hdac_bus *bus, | 37 | void snd_hdac_bus_remove_device(struct hdac_bus *bus, |
38 | struct hdac_device *codec); | 38 | struct hdac_device *codec); |
39 | 39 | ||
40 | int snd_hdac_exec_verb(struct hdac_device *codec, unsigned int cmd, | ||
41 | unsigned int flags, unsigned int *res); | ||
42 | |||
40 | #endif /* __HDAC_LOCAL_H */ | 43 | #endif /* __HDAC_LOCAL_H */ |