summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2017-07-21 05:07:10 -0400
committerDavid Howells <dhowells@redhat.com>2017-07-21 06:00:20 -0400
commitddc6c70f07bb1f6dd39a2c6c430f7b4fa95199c8 (patch)
tree188e91f339ec9bff7c1126575e2c20dd1fd01a5b
parent727f8914477e4642c7d1ff381667cdc4178b40c6 (diff)
rxrpc: Move the packet.h include file into net/rxrpc/
Move the protocol description header file into net/rxrpc/ and rename it to protocol.h. It's no longer necessary to expose it as packets are no longer exposed to kernel services (such as AFS) that use the facility. The abort codes are transferred to the UAPI header instead as we pass these back to userspace and also to kernel services. Signed-off-by: David Howells <dhowells@redhat.com>
-rw-r--r--fs/afs/misc.c1
-rw-r--r--fs/afs/rxrpc.c1
-rw-r--r--include/uapi/linux/rxrpc.h44
-rw-r--r--net/rxrpc/ar-internal.h2
-rw-r--r--net/rxrpc/protocol.h (renamed from include/rxrpc/packet.h)45
5 files changed, 45 insertions, 48 deletions
diff --git a/fs/afs/misc.c b/fs/afs/misc.c
index 100b207efc9e..c05f1f1c0d41 100644
--- a/fs/afs/misc.c
+++ b/fs/afs/misc.c
@@ -12,7 +12,6 @@
12#include <linux/kernel.h> 12#include <linux/kernel.h>
13#include <linux/module.h> 13#include <linux/module.h>
14#include <linux/errno.h> 14#include <linux/errno.h>
15#include <rxrpc/packet.h>
16#include "internal.h" 15#include "internal.h"
17#include "afs_fs.h" 16#include "afs_fs.h"
18 17
diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c
index 02781e78ffb6..10743043d431 100644
--- a/fs/afs/rxrpc.c
+++ b/fs/afs/rxrpc.c
@@ -14,7 +14,6 @@
14 14
15#include <net/sock.h> 15#include <net/sock.h>
16#include <net/af_rxrpc.h> 16#include <net/af_rxrpc.h>
17#include <rxrpc/packet.h>
18#include "internal.h" 17#include "internal.h"
19#include "afs_cm.h" 18#include "afs_cm.h"
20 19
diff --git a/include/uapi/linux/rxrpc.h b/include/uapi/linux/rxrpc.h
index 08e2fb9c70ae..9656aad8f8f7 100644
--- a/include/uapi/linux/rxrpc.h
+++ b/include/uapi/linux/rxrpc.h
@@ -77,4 +77,48 @@ enum rxrpc_cmsg_type {
77#define RXRPC_SECURITY_RXGK 4 /* gssapi-based */ 77#define RXRPC_SECURITY_RXGK 4 /* gssapi-based */
78#define RXRPC_SECURITY_RXK5 5 /* kerberos 5 */ 78#define RXRPC_SECURITY_RXK5 5 /* kerberos 5 */
79 79
80/*
81 * RxRPC-level abort codes
82 */
83#define RX_CALL_DEAD -1 /* call/conn has been inactive and is shut down */
84#define RX_INVALID_OPERATION -2 /* invalid operation requested / attempted */
85#define RX_CALL_TIMEOUT -3 /* call timeout exceeded */
86#define RX_EOF -4 /* unexpected end of data on read op */
87#define RX_PROTOCOL_ERROR -5 /* low-level protocol error */
88#define RX_USER_ABORT -6 /* generic user abort */
89#define RX_ADDRINUSE -7 /* UDP port in use */
90#define RX_DEBUGI_BADTYPE -8 /* bad debugging packet type */
91
92/*
93 * (un)marshalling abort codes (rxgen)
94 */
95#define RXGEN_CC_MARSHAL -450
96#define RXGEN_CC_UNMARSHAL -451
97#define RXGEN_SS_MARSHAL -452
98#define RXGEN_SS_UNMARSHAL -453
99#define RXGEN_DECODE -454
100#define RXGEN_OPCODE -455
101#define RXGEN_SS_XDRFREE -456
102#define RXGEN_CC_XDRFREE -457
103
104/*
105 * Rx kerberos security abort codes
106 * - unfortunately we have no generalised security abort codes to say things
107 * like "unsupported security", so we have to use these instead and hope the
108 * other side understands
109 */
110#define RXKADINCONSISTENCY 19270400 /* security module structure inconsistent */
111#define RXKADPACKETSHORT 19270401 /* packet too short for security challenge */
112#define RXKADLEVELFAIL 19270402 /* security level negotiation failed */
113#define RXKADTICKETLEN 19270403 /* ticket length too short or too long */
114#define RXKADOUTOFSEQUENCE 19270404 /* packet had bad sequence number */
115#define RXKADNOAUTH 19270405 /* caller not authorised */
116#define RXKADBADKEY 19270406 /* illegal key: bad parity or weak */
117#define RXKADBADTICKET 19270407 /* security object was passed a bad ticket */
118#define RXKADUNKNOWNKEY 19270408 /* ticket contained unknown key version number */
119#define RXKADEXPIRED 19270409 /* authentication expired */
120#define RXKADSEALEDINCON 19270410 /* sealed data inconsistent */
121#define RXKADDATALEN 19270411 /* user data too long */
122#define RXKADILLEGALLEVEL 19270412 /* caller not authorised to use encrypted conns */
123
80#endif /* _UAPI_LINUX_RXRPC_H */ 124#endif /* _UAPI_LINUX_RXRPC_H */
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h
index 69b97339ff9d..8c0db9b3e4ab 100644
--- a/net/rxrpc/ar-internal.h
+++ b/net/rxrpc/ar-internal.h
@@ -15,7 +15,7 @@
15#include <net/netns/generic.h> 15#include <net/netns/generic.h>
16#include <net/sock.h> 16#include <net/sock.h>
17#include <net/af_rxrpc.h> 17#include <net/af_rxrpc.h>
18#include <rxrpc/packet.h> 18#include "protocol.h"
19 19
20#if 0 20#if 0
21#define CHECK_SLAB_OKAY(X) \ 21#define CHECK_SLAB_OKAY(X) \
diff --git a/include/rxrpc/packet.h b/net/rxrpc/protocol.h
index a2dcfb850b9f..4bddcf3face3 100644
--- a/include/rxrpc/packet.h
+++ b/net/rxrpc/protocol.h
@@ -187,49 +187,4 @@ struct rxkad_response {
187 __be32 ticket_len; /* Kerberos ticket length */ 187 __be32 ticket_len; /* Kerberos ticket length */
188} __packed; 188} __packed;
189 189
190/*****************************************************************************/
191/*
192 * RxRPC-level abort codes
193 */
194#define RX_CALL_DEAD -1 /* call/conn has been inactive and is shut down */
195#define RX_INVALID_OPERATION -2 /* invalid operation requested / attempted */
196#define RX_CALL_TIMEOUT -3 /* call timeout exceeded */
197#define RX_EOF -4 /* unexpected end of data on read op */
198#define RX_PROTOCOL_ERROR -5 /* low-level protocol error */
199#define RX_USER_ABORT -6 /* generic user abort */
200#define RX_ADDRINUSE -7 /* UDP port in use */
201#define RX_DEBUGI_BADTYPE -8 /* bad debugging packet type */
202
203/*
204 * (un)marshalling abort codes (rxgen)
205 */
206#define RXGEN_CC_MARSHAL -450
207#define RXGEN_CC_UNMARSHAL -451
208#define RXGEN_SS_MARSHAL -452
209#define RXGEN_SS_UNMARSHAL -453
210#define RXGEN_DECODE -454
211#define RXGEN_OPCODE -455
212#define RXGEN_SS_XDRFREE -456
213#define RXGEN_CC_XDRFREE -457
214
215/*
216 * Rx kerberos security abort codes
217 * - unfortunately we have no generalised security abort codes to say things
218 * like "unsupported security", so we have to use these instead and hope the
219 * other side understands
220 */
221#define RXKADINCONSISTENCY 19270400 /* security module structure inconsistent */
222#define RXKADPACKETSHORT 19270401 /* packet too short for security challenge */
223#define RXKADLEVELFAIL 19270402 /* security level negotiation failed */
224#define RXKADTICKETLEN 19270403 /* ticket length too short or too long */
225#define RXKADOUTOFSEQUENCE 19270404 /* packet had bad sequence number */
226#define RXKADNOAUTH 19270405 /* caller not authorised */
227#define RXKADBADKEY 19270406 /* illegal key: bad parity or weak */
228#define RXKADBADTICKET 19270407 /* security object was passed a bad ticket */
229#define RXKADUNKNOWNKEY 19270408 /* ticket contained unknown key version number */
230#define RXKADEXPIRED 19270409 /* authentication expired */
231#define RXKADSEALEDINCON 19270410 /* sealed data inconsistent */
232#define RXKADDATALEN 19270411 /* user data too long */
233#define RXKADILLEGALLEVEL 19270412 /* caller not authorised to use encrypted conns */
234
235#endif /* _LINUX_RXRPC_PACKET_H */ 190#endif /* _LINUX_RXRPC_PACKET_H */