diff options
author | Barry Song <21cnbao@gmail.com> | 2018-08-17 09:03:43 -0400 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2018-09-03 06:54:05 -0400 |
commit | d8570d018f69de60ec65790083767fd2e44a6c7a (patch) | |
tree | f8547f1a2c3df75c2aac055fd74136f81a794b0f | |
parent | 5b394b2ddf0347bef56e50c69a58773c94343ff3 (diff) |
dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r-- | drivers/dma/at_xdmac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4bf72561667c..4e557684f792 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c | |||
@@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data) | |||
1600 | if (atchan->status & AT_XDMAC_CIS_ROIS) | 1600 | if (atchan->status & AT_XDMAC_CIS_ROIS) |
1601 | dev_err(chan2dev(&atchan->chan), "request overflow error!!!"); | 1601 | dev_err(chan2dev(&atchan->chan), "request overflow error!!!"); |
1602 | 1602 | ||
1603 | spin_lock_bh(&atchan->lock); | 1603 | spin_lock(&atchan->lock); |
1604 | desc = list_first_entry(&atchan->xfers_list, | 1604 | desc = list_first_entry(&atchan->xfers_list, |
1605 | struct at_xdmac_desc, | 1605 | struct at_xdmac_desc, |
1606 | xfer_node); | 1606 | xfer_node); |
@@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data) | |||
1610 | txd = &desc->tx_dma_desc; | 1610 | txd = &desc->tx_dma_desc; |
1611 | 1611 | ||
1612 | at_xdmac_remove_xfer(atchan, desc); | 1612 | at_xdmac_remove_xfer(atchan, desc); |
1613 | spin_unlock_bh(&atchan->lock); | 1613 | spin_unlock(&atchan->lock); |
1614 | 1614 | ||
1615 | if (!at_xdmac_chan_is_cyclic(atchan)) { | 1615 | if (!at_xdmac_chan_is_cyclic(atchan)) { |
1616 | dma_cookie_complete(txd); | 1616 | dma_cookie_complete(txd); |