smb3: remove noisy debug message and minor cleanup

Message was intended only for developer temporary build
In addition cleanup two minor warnings noticed by Coverity
and a trivial change to workaround a sparse warning

Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

3 files changed, 6 insertions, 9 deletions

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 2e960e1049db..50dfd9049370 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1210,7 +1210,7 @@ struct cifs_search_info {
         bool smallBuf:1; /* so we know which buf_release function to call */
 };
 
-#define ACL_NO_MODE     -1
+#define ACL_NO_MODE     ((umode_t)(-1))
 struct cifs_open_parms {
         struct cifs_tcon *tcon;
         struct cifs_sb_info *cifs_sb;
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b724227b853c..a64dfa95a925 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4445,7 +4445,7 @@ static int setup_dfs_tgt_conn(const char *path,
         int rc;
         struct dfs_info3_param ref = {0};
         char *mdata = NULL, *fake_devname = NULL;
-        struct smb_vol fake_vol = {0};
+        struct smb_vol fake_vol = {NULL};
 
         cifs_dbg(FYI, "%s: dfs path: %s\n", __func__, path);
 
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index fd5f2b4b7582..05149862aea4 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -751,8 +751,8 @@ add_posix_context(struct kvec *iov, unsigned int *num_iovec, umode_t mode)
         unsigned int num = *num_iovec;
 
         iov[num].iov_base = create_posix_buf(mode);
-        if (mode == -1)
-                cifs_dbg(VFS, "illegal mode\n"); /* BB REMOVEME */
+        if (mode == ACL_NO_MODE)
+                cifs_dbg(FYI, "illegal mode\n");
         if (iov[num].iov_base == NULL)
                 return -ENOMEM;
         iov[num].iov_len = sizeof(struct create_posix);
@@ -2521,11 +2521,8 @@ SMB2_open_init(struct cifs_tcon *tcon, struct smb_rqst *rqst, __u8 *oplock,
                         return rc;
         }
 
-        /* TODO: add handling for the mode on create */
-        if (oparms->disposition == FILE_CREATE)
-                cifs_dbg(VFS, "mode is 0x%x\n", oparms->mode); /* BB REMOVEME */
-
-        if ((oparms->disposition == FILE_CREATE) && (oparms->mode != -1)) {
+        if ((oparms->disposition == FILE_CREATE) &&
+            (oparms->mode != ACL_NO_MODE)) {
                 if (n_iov > 2) {
                         struct create_context *ccontext =
                             (struct create_context *)iov[n_iov-1].iov_base;