diff options
author | YueHaibing <yuehaibing@huawei.com> | 2018-11-19 07:48:19 -0500 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2018-12-20 14:54:27 -0500 |
commit | cd0d465bb697a9c7bf66a9fe940f7981232f1676 (patch) | |
tree | d44c0916a1a82c9e29a4b8583d5d936ec5c56800 | |
parent | bad87ee82f74707913a27f16d40cd8a1c340b47e (diff) |
e100: Fix passing zero to 'PTR_ERR' warning in e100_load_ucode_wait
Fix a static code checker warning:
drivers/net/ethernet/intel/e100.c:1349
e100_load_ucode_wait() warn: passing zero to 'PTR_ERR'
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r-- | drivers/net/ethernet/intel/e100.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 5e5c57db0d3f..0fd268070fb4 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c | |||
@@ -1345,8 +1345,8 @@ static inline int e100_load_ucode_wait(struct nic *nic) | |||
1345 | 1345 | ||
1346 | fw = e100_request_firmware(nic); | 1346 | fw = e100_request_firmware(nic); |
1347 | /* If it's NULL, then no ucode is required */ | 1347 | /* If it's NULL, then no ucode is required */ |
1348 | if (!fw || IS_ERR(fw)) | 1348 | if (IS_ERR_OR_NULL(fw)) |
1349 | return PTR_ERR(fw); | 1349 | return PTR_ERR_OR_ZERO(fw); |
1350 | 1350 | ||
1351 | if ((err = e100_exec_cb(nic, (void *)fw, e100_setup_ucode))) | 1351 | if ((err = e100_exec_cb(nic, (void *)fw, e100_setup_ucode))) |
1352 | netif_err(nic, probe, nic->netdev, | 1352 | netif_err(nic, probe, nic->netdev, |