diff options
author | Olof Johansson <olof@lixom.net> | 2019-06-16 16:24:59 -0400 |
---|---|---|
committer | Olof Johansson <olof@lixom.net> | 2019-06-16 16:24:59 -0400 |
commit | c1d6f4adf46592e825b77c43408cd929a80e9aba (patch) | |
tree | 33f40bcf7d45da8e7b3cef94fbd86a9eba68ea0d | |
parent | 9e0babf2c06c73cda2c0cd37a1653d823adb40ec (diff) | |
parent | 6b23af0783a54efb348f0bd781b7850636023dbb (diff) |
Merge tag 'arm-soc/for-5.2/drivers-fixes' of https://github.com/Broadcom/stblinux into fixes
This pull request contains Broadcom ARM/ARM64/MIPS SoCs device drivers
fixes for 5.2-rc1, please pull the following:
- Florian fixes the biuctrl driver not to create an error condition/path
upon unsupported CPU and also fixes the biuctrl driver writes to used
a data barrier which is necessary given the HW block design
* tag 'arm-soc/for-5.2/drivers-fixes' of https://github.com/Broadcom/stblinux:
soc: bcm: brcmstb: biuctrl: Register writes require a barrier
soc: brcmstb: Fix error path for unsupported CPUs
Signed-off-by: Olof Johansson <olof@lixom.net>
-rw-r--r-- | drivers/soc/bcm/brcmstb/biuctrl.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb/biuctrl.c index b3dbdb365749..d326915e0f40 100644 --- a/drivers/soc/bcm/brcmstb/biuctrl.c +++ b/drivers/soc/bcm/brcmstb/biuctrl.c | |||
@@ -48,7 +48,7 @@ static inline void cbc_writel(u32 val, int reg) | |||
48 | if (offset == -1) | 48 | if (offset == -1) |
49 | return; | 49 | return; |
50 | 50 | ||
51 | writel_relaxed(val, cpubiuctrl_base + offset); | 51 | writel(val, cpubiuctrl_base + offset); |
52 | } | 52 | } |
53 | 53 | ||
54 | enum cpubiuctrl_regs { | 54 | enum cpubiuctrl_regs { |
@@ -238,7 +238,9 @@ static int __init brcmstb_biuctrl_init(void) | |||
238 | if (!np) | 238 | if (!np) |
239 | return 0; | 239 | return 0; |
240 | 240 | ||
241 | setup_hifcpubiuctrl_regs(np); | 241 | ret = setup_hifcpubiuctrl_regs(np); |
242 | if (ret) | ||
243 | return ret; | ||
242 | 244 | ||
243 | ret = mcp_write_pairing_set(); | 245 | ret = mcp_write_pairing_set(); |
244 | if (ret) { | 246 | if (ret) { |