summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEugen Hristev <eugen.hristev@microchip.com>2018-09-24 03:51:43 -0400
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2018-09-29 07:30:19 -0400
commitbc1b45326223e7e890053cf6266357adfa61942d (patch)
tree7abe24ddba4d254ce350fb085552cb72d925ab9c
parent057e5a1109faa01091a989c224833e2df6003b2e (diff)
iio: adc: at91: fix acking DRDY irq on simple conversions
When doing simple conversions, the driver did not acknowledge the DRDY irq. If this irq status is not acked, it will be left pending, and as soon as a trigger is enabled, the irq handler will be called, it doesn't know why this status has occurred because no channel is pending, and then it will go int a irq loop and board will hang. To avoid this situation, read the LCDR after a raw conversion is done. Fixes: 0e589d5fb ("ARM: AT91: IIO: Add AT91 ADC driver.") Cc: Maxime Ripard <maxime.ripard@bootlin.com> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
-rw-r--r--drivers/iio/adc/at91_adc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 44b516863c9d..e3be88e7192c 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -279,6 +279,8 @@ static void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
279 iio_trigger_poll(idev->trig); 279 iio_trigger_poll(idev->trig);
280 } else { 280 } else {
281 st->last_value = at91_adc_readl(st, AT91_ADC_CHAN(st, st->chnb)); 281 st->last_value = at91_adc_readl(st, AT91_ADC_CHAN(st, st->chnb));
282 /* Needed to ACK the DRDY interruption */
283 at91_adc_readl(st, AT91_ADC_LCDR);
282 st->done = true; 284 st->done = true;
283 wake_up_interruptible(&st->wq_data_avail); 285 wake_up_interruptible(&st->wq_data_avail);
284 } 286 }