summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2015-07-20 07:57:21 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-08-05 16:36:48 -0400
commitbab383de3b84e584b0f09227151020b2a43dc34c (patch)
treed638c1a43014ebd181af4d2fdc8d4961fe5b08bb
parentd25ded8d3c6ecc3043763d4330c964603dc61bd4 (diff)
auxdisplay: ks0108: fix refcount
parport_find_base() will implicitly do parport_get_port() which increases the refcount. Then parport_register_device() will again increment the refcount. But while unloading the module we are only doing parport_unregister_device() decrementing the refcount only once. We add an parport_put_port() to neutralize the effect of parport_get_port(). Cc: <stable@vger.kernel.org> # 2.6.32+ Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/auxdisplay/ks0108.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c
index 5b93852392b8..0d752851a1ee 100644
--- a/drivers/auxdisplay/ks0108.c
+++ b/drivers/auxdisplay/ks0108.c
@@ -139,6 +139,7 @@ static int __init ks0108_init(void)
139 139
140 ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME, 140 ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME,
141 NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL); 141 NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);
142 parport_put_port(ks0108_parport);
142 if (ks0108_pardevice == NULL) { 143 if (ks0108_pardevice == NULL) {
143 printk(KERN_ERR KS0108_NAME ": ERROR: " 144 printk(KERN_ERR KS0108_NAME ": ERROR: "
144 "parport didn't register new device\n"); 145 "parport didn't register new device\n");