diff options
author | Cornelia Huck <cohuck@redhat.com> | 2019-09-11 12:41:03 -0400 |
---|---|---|
committer | Vasily Gorbik <gor@linux.ibm.com> | 2019-09-19 06:56:06 -0400 |
commit | b91d9e67e50bfc79850a1760b8e59dc1dc56057f (patch) | |
tree | 73d29773f77325fe6208113c93bfbe6930b5b687 | |
parent | f71fee2711a788b94ff0acb02fbd2bfe2de7e0a3 (diff) |
s390/cio: fix intparm documentation
The common I/O layer is maintaining an "intparm" inspired by
the hardware intparm for driver usage. This "intparm" is not
only applicaple for ssch, but also for hsch/csch. The kerneldoc
states that it is only updated for hsch/csch if no prior request
is pending; however, this is not what the code does (whether
that would actually desireable is a different issue.)
Let's at least fix the kerneldoc for now.
Fixes: b2ffd8e9a76e ("[S390] cio: Add docbook comments.")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
-rw-r--r-- | drivers/s390/cio/device_ops.c | 23 |
1 files changed, 17 insertions, 6 deletions
diff --git a/drivers/s390/cio/device_ops.c b/drivers/s390/cio/device_ops.c index d722458c5928..65841af15748 100644 --- a/drivers/s390/cio/device_ops.c +++ b/drivers/s390/cio/device_ops.c | |||
@@ -124,9 +124,7 @@ EXPORT_SYMBOL(ccw_device_is_multipath); | |||
124 | /** | 124 | /** |
125 | * ccw_device_clear() - terminate I/O request processing | 125 | * ccw_device_clear() - terminate I/O request processing |
126 | * @cdev: target ccw device | 126 | * @cdev: target ccw device |
127 | * @intparm: interruption parameter; value is only used if no I/O is | 127 | * @intparm: interruption parameter to be returned upon conclusion of csch |
128 | * outstanding, otherwise the intparm associated with the I/O request | ||
129 | * is returned | ||
130 | * | 128 | * |
131 | * ccw_device_clear() calls csch on @cdev's subchannel. | 129 | * ccw_device_clear() calls csch on @cdev's subchannel. |
132 | * Returns: | 130 | * Returns: |
@@ -179,6 +177,9 @@ int ccw_device_clear(struct ccw_device *cdev, unsigned long intparm) | |||
179 | * completed during the time specified by @expires. If a timeout occurs, the | 177 | * completed during the time specified by @expires. If a timeout occurs, the |
180 | * channel program is terminated via xsch, hsch or csch, and the device's | 178 | * channel program is terminated via xsch, hsch or csch, and the device's |
181 | * interrupt handler will be called with an irb containing ERR_PTR(-%ETIMEDOUT). | 179 | * interrupt handler will be called with an irb containing ERR_PTR(-%ETIMEDOUT). |
180 | * The interruption handler will echo back the @intparm specified here, unless | ||
181 | * another interruption parameter is specified by a subsequent invocation of | ||
182 | * ccw_device_halt() or ccw_device_clear(). | ||
182 | * Returns: | 183 | * Returns: |
183 | * %0, if the operation was successful; | 184 | * %0, if the operation was successful; |
184 | * -%EBUSY, if the device is busy, or status pending; | 185 | * -%EBUSY, if the device is busy, or status pending; |
@@ -256,6 +257,9 @@ int ccw_device_start_timeout_key(struct ccw_device *cdev, struct ccw1 *cpa, | |||
256 | * Start a S/390 channel program. When the interrupt arrives, the | 257 | * Start a S/390 channel program. When the interrupt arrives, the |
257 | * IRQ handler is called, either immediately, delayed (dev-end missing, | 258 | * IRQ handler is called, either immediately, delayed (dev-end missing, |
258 | * or sense required) or never (no IRQ handler registered). | 259 | * or sense required) or never (no IRQ handler registered). |
260 | * The interruption handler will echo back the @intparm specified here, unless | ||
261 | * another interruption parameter is specified by a subsequent invocation of | ||
262 | * ccw_device_halt() or ccw_device_clear(). | ||
259 | * Returns: | 263 | * Returns: |
260 | * %0, if the operation was successful; | 264 | * %0, if the operation was successful; |
261 | * -%EBUSY, if the device is busy, or status pending; | 265 | * -%EBUSY, if the device is busy, or status pending; |
@@ -287,6 +291,9 @@ int ccw_device_start_key(struct ccw_device *cdev, struct ccw1 *cpa, | |||
287 | * Start a S/390 channel program. When the interrupt arrives, the | 291 | * Start a S/390 channel program. When the interrupt arrives, the |
288 | * IRQ handler is called, either immediately, delayed (dev-end missing, | 292 | * IRQ handler is called, either immediately, delayed (dev-end missing, |
289 | * or sense required) or never (no IRQ handler registered). | 293 | * or sense required) or never (no IRQ handler registered). |
294 | * The interruption handler will echo back the @intparm specified here, unless | ||
295 | * another interruption parameter is specified by a subsequent invocation of | ||
296 | * ccw_device_halt() or ccw_device_clear(). | ||
290 | * Returns: | 297 | * Returns: |
291 | * %0, if the operation was successful; | 298 | * %0, if the operation was successful; |
292 | * -%EBUSY, if the device is busy, or status pending; | 299 | * -%EBUSY, if the device is busy, or status pending; |
@@ -322,6 +329,9 @@ int ccw_device_start(struct ccw_device *cdev, struct ccw1 *cpa, | |||
322 | * completed during the time specified by @expires. If a timeout occurs, the | 329 | * completed during the time specified by @expires. If a timeout occurs, the |
323 | * channel program is terminated via xsch, hsch or csch, and the device's | 330 | * channel program is terminated via xsch, hsch or csch, and the device's |
324 | * interrupt handler will be called with an irb containing ERR_PTR(-%ETIMEDOUT). | 331 | * interrupt handler will be called with an irb containing ERR_PTR(-%ETIMEDOUT). |
332 | * The interruption handler will echo back the @intparm specified here, unless | ||
333 | * another interruption parameter is specified by a subsequent invocation of | ||
334 | * ccw_device_halt() or ccw_device_clear(). | ||
325 | * Returns: | 335 | * Returns: |
326 | * %0, if the operation was successful; | 336 | * %0, if the operation was successful; |
327 | * -%EBUSY, if the device is busy, or status pending; | 337 | * -%EBUSY, if the device is busy, or status pending; |
@@ -343,11 +353,12 @@ int ccw_device_start_timeout(struct ccw_device *cdev, struct ccw1 *cpa, | |||
343 | /** | 353 | /** |
344 | * ccw_device_halt() - halt I/O request processing | 354 | * ccw_device_halt() - halt I/O request processing |
345 | * @cdev: target ccw device | 355 | * @cdev: target ccw device |
346 | * @intparm: interruption parameter; value is only used if no I/O is | 356 | * @intparm: interruption parameter to be returned upon conclusion of hsch |
347 | * outstanding, otherwise the intparm associated with the I/O request | ||
348 | * is returned | ||
349 | * | 357 | * |
350 | * ccw_device_halt() calls hsch on @cdev's subchannel. | 358 | * ccw_device_halt() calls hsch on @cdev's subchannel. |
359 | * The interruption handler will echo back the @intparm specified here, unless | ||
360 | * another interruption parameter is specified by a subsequent invocation of | ||
361 | * ccw_device_clear(). | ||
351 | * Returns: | 362 | * Returns: |
352 | * %0 on success, | 363 | * %0 on success, |
353 | * -%ENODEV on device not operational, | 364 | * -%ENODEV on device not operational, |