diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2016-03-25 17:20:47 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-03-25 19:37:42 -0400 |
commit | b8b4ead11e9d258ccc9a8aea28cc0ac747b044ef (patch) | |
tree | 44938deabf08a6d5c75ca671b154e558d3448740 | |
parent | bb29902a7515208846114b3b36a4281a9bbf766a (diff) |
drivers/input: eliminate INPUT_COMPAT_TEST macro
INPUT_COMPAT_TEST became much simpler after commit f4056b52845283
("input: redefine INPUT_COMPAT_TEST as in_compat_syscall()") so we can
cleanly eliminate it altogether.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/input/input-compat.c | 6 | ||||
-rw-r--r-- | drivers/input/input-compat.h | 4 | ||||
-rw-r--r-- | drivers/input/input.c | 2 | ||||
-rw-r--r-- | drivers/input/misc/uinput.c | 4 |
4 files changed, 7 insertions, 9 deletions
diff --git a/drivers/input/input-compat.c b/drivers/input/input-compat.c index 64ca7113ff28..d84d20b9cec0 100644 --- a/drivers/input/input-compat.c +++ b/drivers/input/input-compat.c | |||
@@ -17,7 +17,7 @@ | |||
17 | int input_event_from_user(const char __user *buffer, | 17 | int input_event_from_user(const char __user *buffer, |
18 | struct input_event *event) | 18 | struct input_event *event) |
19 | { | 19 | { |
20 | if (INPUT_COMPAT_TEST && !COMPAT_USE_64BIT_TIME) { | 20 | if (in_compat_syscall() && !COMPAT_USE_64BIT_TIME) { |
21 | struct input_event_compat compat_event; | 21 | struct input_event_compat compat_event; |
22 | 22 | ||
23 | if (copy_from_user(&compat_event, buffer, | 23 | if (copy_from_user(&compat_event, buffer, |
@@ -41,7 +41,7 @@ int input_event_from_user(const char __user *buffer, | |||
41 | int input_event_to_user(char __user *buffer, | 41 | int input_event_to_user(char __user *buffer, |
42 | const struct input_event *event) | 42 | const struct input_event *event) |
43 | { | 43 | { |
44 | if (INPUT_COMPAT_TEST && !COMPAT_USE_64BIT_TIME) { | 44 | if (in_compat_syscall() && !COMPAT_USE_64BIT_TIME) { |
45 | struct input_event_compat compat_event; | 45 | struct input_event_compat compat_event; |
46 | 46 | ||
47 | compat_event.time.tv_sec = event->time.tv_sec; | 47 | compat_event.time.tv_sec = event->time.tv_sec; |
@@ -65,7 +65,7 @@ int input_event_to_user(char __user *buffer, | |||
65 | int input_ff_effect_from_user(const char __user *buffer, size_t size, | 65 | int input_ff_effect_from_user(const char __user *buffer, size_t size, |
66 | struct ff_effect *effect) | 66 | struct ff_effect *effect) |
67 | { | 67 | { |
68 | if (INPUT_COMPAT_TEST) { | 68 | if (in_compat_syscall()) { |
69 | struct ff_effect_compat *compat_effect; | 69 | struct ff_effect_compat *compat_effect; |
70 | 70 | ||
71 | if (size != sizeof(struct ff_effect_compat)) | 71 | if (size != sizeof(struct ff_effect_compat)) |
diff --git a/drivers/input/input-compat.h b/drivers/input/input-compat.h index 0f25878d5fa2..1563160a7af3 100644 --- a/drivers/input/input-compat.h +++ b/drivers/input/input-compat.h | |||
@@ -17,8 +17,6 @@ | |||
17 | 17 | ||
18 | #ifdef CONFIG_COMPAT | 18 | #ifdef CONFIG_COMPAT |
19 | 19 | ||
20 | #define INPUT_COMPAT_TEST in_compat_syscall() | ||
21 | |||
22 | struct input_event_compat { | 20 | struct input_event_compat { |
23 | struct compat_timeval time; | 21 | struct compat_timeval time; |
24 | __u16 type; | 22 | __u16 type; |
@@ -57,7 +55,7 @@ struct ff_effect_compat { | |||
57 | 55 | ||
58 | static inline size_t input_event_size(void) | 56 | static inline size_t input_event_size(void) |
59 | { | 57 | { |
60 | return (INPUT_COMPAT_TEST && !COMPAT_USE_64BIT_TIME) ? | 58 | return (in_compat_syscall() && !COMPAT_USE_64BIT_TIME) ? |
61 | sizeof(struct input_event_compat) : sizeof(struct input_event); | 59 | sizeof(struct input_event_compat) : sizeof(struct input_event); |
62 | } | 60 | } |
63 | 61 | ||
diff --git a/drivers/input/input.c b/drivers/input/input.c index 880605959aa6..b87ffbd4547d 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c | |||
@@ -1015,7 +1015,7 @@ static int input_bits_to_string(char *buf, int buf_size, | |||
1015 | { | 1015 | { |
1016 | int len = 0; | 1016 | int len = 0; |
1017 | 1017 | ||
1018 | if (INPUT_COMPAT_TEST) { | 1018 | if (in_compat_syscall()) { |
1019 | u32 dword = bits >> 32; | 1019 | u32 dword = bits >> 32; |
1020 | if (dword || !skip_empty) | 1020 | if (dword || !skip_empty) |
1021 | len += snprintf(buf, buf_size, "%x ", dword); | 1021 | len += snprintf(buf, buf_size, "%x ", dword); |
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index 4eb9e4d94f46..abe1a927b332 100644 --- a/drivers/input/misc/uinput.c +++ b/drivers/input/misc/uinput.c | |||
@@ -664,7 +664,7 @@ struct uinput_ff_upload_compat { | |||
664 | static int uinput_ff_upload_to_user(char __user *buffer, | 664 | static int uinput_ff_upload_to_user(char __user *buffer, |
665 | const struct uinput_ff_upload *ff_up) | 665 | const struct uinput_ff_upload *ff_up) |
666 | { | 666 | { |
667 | if (INPUT_COMPAT_TEST) { | 667 | if (in_compat_syscall()) { |
668 | struct uinput_ff_upload_compat ff_up_compat; | 668 | struct uinput_ff_upload_compat ff_up_compat; |
669 | 669 | ||
670 | ff_up_compat.request_id = ff_up->request_id; | 670 | ff_up_compat.request_id = ff_up->request_id; |
@@ -695,7 +695,7 @@ static int uinput_ff_upload_to_user(char __user *buffer, | |||
695 | static int uinput_ff_upload_from_user(const char __user *buffer, | 695 | static int uinput_ff_upload_from_user(const char __user *buffer, |
696 | struct uinput_ff_upload *ff_up) | 696 | struct uinput_ff_upload *ff_up) |
697 | { | 697 | { |
698 | if (INPUT_COMPAT_TEST) { | 698 | if (in_compat_syscall()) { |
699 | struct uinput_ff_upload_compat ff_up_compat; | 699 | struct uinput_ff_upload_compat ff_up_compat; |
700 | 700 | ||
701 | if (copy_from_user(&ff_up_compat, buffer, | 701 | if (copy_from_user(&ff_up_compat, buffer, |