diff options
author | Guenter Roeck <linux@roeck-us.net> | 2018-12-10 17:02:10 -0500 |
---|---|---|
committer | Guenter Roeck <linux@roeck-us.net> | 2019-02-18 17:23:29 -0500 |
commit | b65626b6d6ec8ec5c1a33af939bbee40df77c20a (patch) | |
tree | b5e332453582ed1ccea26ccc95d825139f9e2bf9 | |
parent | 4820d5115e0a385ff7bd2847e5c62f88e5f135db (diff) |
hwmon: (k8temp) Use permission specific SENSOR[_DEVICE]_ATTR variants
Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.
Also replace any remaining S_<PERMS> in the driver with octal values.
The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/.
This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.
Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r-- | drivers/hwmon/k8temp.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/hwmon/k8temp.c b/drivers/hwmon/k8temp.c index e59f9113fb93..93a5d51f3c6d 100644 --- a/drivers/hwmon/k8temp.c +++ b/drivers/hwmon/k8temp.c | |||
@@ -109,8 +109,8 @@ static ssize_t name_show(struct device *dev, struct device_attribute | |||
109 | } | 109 | } |
110 | 110 | ||
111 | 111 | ||
112 | static ssize_t show_temp(struct device *dev, | 112 | static ssize_t temp_show(struct device *dev, struct device_attribute *devattr, |
113 | struct device_attribute *devattr, char *buf) | 113 | char *buf) |
114 | { | 114 | { |
115 | struct sensor_device_attribute_2 *attr = | 115 | struct sensor_device_attribute_2 *attr = |
116 | to_sensor_dev_attr_2(devattr); | 116 | to_sensor_dev_attr_2(devattr); |
@@ -129,10 +129,10 @@ static ssize_t show_temp(struct device *dev, | |||
129 | 129 | ||
130 | /* core, place */ | 130 | /* core, place */ |
131 | 131 | ||
132 | static SENSOR_DEVICE_ATTR_2(temp1_input, S_IRUGO, show_temp, NULL, 0, 0); | 132 | static SENSOR_DEVICE_ATTR_2_RO(temp1_input, temp, 0, 0); |
133 | static SENSOR_DEVICE_ATTR_2(temp2_input, S_IRUGO, show_temp, NULL, 0, 1); | 133 | static SENSOR_DEVICE_ATTR_2_RO(temp2_input, temp, 0, 1); |
134 | static SENSOR_DEVICE_ATTR_2(temp3_input, S_IRUGO, show_temp, NULL, 1, 0); | 134 | static SENSOR_DEVICE_ATTR_2_RO(temp3_input, temp, 1, 0); |
135 | static SENSOR_DEVICE_ATTR_2(temp4_input, S_IRUGO, show_temp, NULL, 1, 1); | 135 | static SENSOR_DEVICE_ATTR_2_RO(temp4_input, temp, 1, 1); |
136 | static DEVICE_ATTR_RO(name); | 136 | static DEVICE_ATTR_RO(name); |
137 | 137 | ||
138 | static const struct pci_device_id k8temp_ids[] = { | 138 | static const struct pci_device_id k8temp_ids[] = { |