diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-05-06 08:50:18 -0400 |
---|---|---|
committer | Daniel Thompson <daniel.thompson@linaro.org> | 2019-05-12 04:50:44 -0400 |
commit | b586627e10f57ee3aa8f0cfab0d6f7dc4ae63760 (patch) | |
tree | 179466e3716826e61ead28ece56e385e4b99b2b7 | |
parent | ecebc5ce59a003163eb608ace38a01d7ffeb0a95 (diff) |
kdb: do a sanity check on the cpu in kdb_per_cpu()
The "whichcpu" comes from argv[3]. The cpu_online() macro looks up the
cpu in a bitmap of online cpus, but if the value is too high then it
could read beyond the end of the bitmap and possibly Oops.
Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
-rw-r--r-- | kernel/debug/kdb/kdb_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index fc96dbf8d9de..9ecfa37c7fbf 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c | |||
@@ -2583,7 +2583,7 @@ static int kdb_per_cpu(int argc, const char **argv) | |||
2583 | diag = kdbgetularg(argv[3], &whichcpu); | 2583 | diag = kdbgetularg(argv[3], &whichcpu); |
2584 | if (diag) | 2584 | if (diag) |
2585 | return diag; | 2585 | return diag; |
2586 | if (!cpu_online(whichcpu)) { | 2586 | if (whichcpu >= nr_cpu_ids || !cpu_online(whichcpu)) { |
2587 | kdb_printf("cpu %ld is not online\n", whichcpu); | 2587 | kdb_printf("cpu %ld is not online\n", whichcpu); |
2588 | return KDB_BADCPUNUM; | 2588 | return KDB_BADCPUNUM; |
2589 | } | 2589 | } |