diff options
author | Peter Zijlstra <peterz@infradead.org> | 2017-04-26 11:36:41 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-05-15 04:15:28 -0400 |
commit | af85596c74de2fd9abb87501ae280038ac28a3f4 (patch) | |
tree | 23793752fdb3bf47020278e8c4e04e57e8cb9c52 | |
parent | c20e1ea4b61c3d99a354d912f2d74822fd2a001d (diff) |
sched/topology: Remove FORCE_SD_OVERLAP
Its an obsolete debug mechanism and future code wants to rely on
properties this undermines.
Namely, it would be good to assume that SD_OVERLAP domains have
children, but if we build the entire hierarchy with SD_OVERLAP this is
obviously false.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | kernel/sched/features.h | 1 | ||||
-rw-r--r-- | kernel/sched/topology.c | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/kernel/sched/features.h b/kernel/sched/features.h index 11192e0cb122..dc4d1483b038 100644 --- a/kernel/sched/features.h +++ b/kernel/sched/features.h | |||
@@ -76,7 +76,6 @@ SCHED_FEAT(WARN_DOUBLE_CLOCK, false) | |||
76 | SCHED_FEAT(RT_PUSH_IPI, true) | 76 | SCHED_FEAT(RT_PUSH_IPI, true) |
77 | #endif | 77 | #endif |
78 | 78 | ||
79 | SCHED_FEAT(FORCE_SD_OVERLAP, false) | ||
80 | SCHED_FEAT(RT_RUNTIME_SHARE, true) | 79 | SCHED_FEAT(RT_RUNTIME_SHARE, true) |
81 | SCHED_FEAT(LB_MIN, false) | 80 | SCHED_FEAT(LB_MIN, false) |
82 | SCHED_FEAT(ATTACH_AGE_LOAD, true) | 81 | SCHED_FEAT(ATTACH_AGE_LOAD, true) |
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index c10f44a1ab2d..21efacf547d4 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c | |||
@@ -1439,7 +1439,7 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att | |||
1439 | sd = build_sched_domain(tl, cpu_map, attr, sd, i); | 1439 | sd = build_sched_domain(tl, cpu_map, attr, sd, i); |
1440 | if (tl == sched_domain_topology) | 1440 | if (tl == sched_domain_topology) |
1441 | *per_cpu_ptr(d.sd, i) = sd; | 1441 | *per_cpu_ptr(d.sd, i) = sd; |
1442 | if (tl->flags & SDTL_OVERLAP || sched_feat(FORCE_SD_OVERLAP)) | 1442 | if (tl->flags & SDTL_OVERLAP) |
1443 | sd->flags |= SD_OVERLAP; | 1443 | sd->flags |= SD_OVERLAP; |
1444 | if (cpumask_equal(cpu_map, sched_domain_span(sd))) | 1444 | if (cpumask_equal(cpu_map, sched_domain_span(sd))) |
1445 | break; | 1445 | break; |