summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobert P. J. Day <rpjday@crashcourse.ca>2017-09-08 19:17:22 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2017-09-08 21:26:51 -0400
commitab4f5260585e7e295eb68717131da11eaf40b239 (patch)
tree08fb92271ebc31a3fa5511ab98b64227a02de273
parenta2d818030135c293f878fbb772cf40e7a14c5acc (diff)
drivers/pps: use surrounding "if PPS" to remove numerous dependency checks
Adding high-level "if PPS" makes lower-level dependency tests superfluous. Link: http://lkml.kernel.org/r/alpine.LFD.2.20.1708261050500.8156@localhost.localdomain Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Acked-by: Rodolfo Giometti <giometti@enneenne.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/pps/Kconfig7
-rw-r--r--drivers/pps/clients/Kconfig7
-rw-r--r--drivers/pps/generators/Kconfig3
3 files changed, 8 insertions, 9 deletions
diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 4b29a7182d7b..c6008f296605 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -19,9 +19,10 @@ menuconfig PPS
19 To compile this driver as a module, choose M here: the module 19 To compile this driver as a module, choose M here: the module
20 will be called pps_core.ko. 20 will be called pps_core.ko.
21 21
22if PPS
23
22config PPS_DEBUG 24config PPS_DEBUG
23 bool "PPS debugging messages" 25 bool "PPS debugging messages"
24 depends on PPS
25 help 26 help
26 Say Y here if you want the PPS support to produce a bunch of debug 27 Say Y here if you want the PPS support to produce a bunch of debug
27 messages to the system log. Select this if you are having a 28 messages to the system log. Select this if you are having a
@@ -29,7 +30,7 @@ config PPS_DEBUG
29 30
30config NTP_PPS 31config NTP_PPS
31 bool "PPS kernel consumer support" 32 bool "PPS kernel consumer support"
32 depends on PPS && !NO_HZ_COMMON 33 depends on !NO_HZ_COMMON
33 help 34 help
34 This option adds support for direct in-kernel time 35 This option adds support for direct in-kernel time
35 synchronization using an external PPS signal. 36 synchronization using an external PPS signal.
@@ -39,3 +40,5 @@ config NTP_PPS
39source drivers/pps/clients/Kconfig 40source drivers/pps/clients/Kconfig
40 41
41source drivers/pps/generators/Kconfig 42source drivers/pps/generators/Kconfig
43
44endif # PPS
diff --git a/drivers/pps/clients/Kconfig b/drivers/pps/clients/Kconfig
index efec021ce662..7f02a9b1a1fd 100644
--- a/drivers/pps/clients/Kconfig
+++ b/drivers/pps/clients/Kconfig
@@ -3,11 +3,9 @@
3# 3#
4 4
5comment "PPS clients support" 5comment "PPS clients support"
6 depends on PPS
7 6
8config PPS_CLIENT_KTIMER 7config PPS_CLIENT_KTIMER
9 tristate "Kernel timer client (Testing client, use for debug)" 8 tristate "Kernel timer client (Testing client, use for debug)"
10 depends on PPS
11 help 9 help
12 If you say yes here you get support for a PPS debugging client 10 If you say yes here you get support for a PPS debugging client
13 which uses a kernel timer to generate the PPS signal. 11 which uses a kernel timer to generate the PPS signal.
@@ -17,21 +15,20 @@ config PPS_CLIENT_KTIMER
17 15
18config PPS_CLIENT_LDISC 16config PPS_CLIENT_LDISC
19 tristate "PPS line discipline" 17 tristate "PPS line discipline"
20 depends on PPS && TTY 18 depends on TTY
21 help 19 help
22 If you say yes here you get support for a PPS source connected 20 If you say yes here you get support for a PPS source connected
23 with the CD (Carrier Detect) pin of your serial port. 21 with the CD (Carrier Detect) pin of your serial port.
24 22
25config PPS_CLIENT_PARPORT 23config PPS_CLIENT_PARPORT
26 tristate "Parallel port PPS client" 24 tristate "Parallel port PPS client"
27 depends on PPS && PARPORT 25 depends on PARPORT
28 help 26 help
29 If you say yes here you get support for a PPS source connected 27 If you say yes here you get support for a PPS source connected
30 with the interrupt pin of your parallel port. 28 with the interrupt pin of your parallel port.
31 29
32config PPS_CLIENT_GPIO 30config PPS_CLIENT_GPIO
33 tristate "PPS client using GPIO" 31 tristate "PPS client using GPIO"
34 depends on PPS
35 help 32 help
36 If you say yes here you get support for a PPS source using 33 If you say yes here you get support for a PPS source using
37 GPIO. To be useful you must also register a platform device 34 GPIO. To be useful you must also register a platform device
diff --git a/drivers/pps/generators/Kconfig b/drivers/pps/generators/Kconfig
index 86b59378e71f..e4c4f3dc0728 100644
--- a/drivers/pps/generators/Kconfig
+++ b/drivers/pps/generators/Kconfig
@@ -3,11 +3,10 @@
3# 3#
4 4
5comment "PPS generators support" 5comment "PPS generators support"
6 depends on PPS
7 6
8config PPS_GENERATOR_PARPORT 7config PPS_GENERATOR_PARPORT
9 tristate "Parallel port PPS signal generator" 8 tristate "Parallel port PPS signal generator"
10 depends on PPS && PARPORT && BROKEN 9 depends on PARPORT && BROKEN
11 help 10 help
12 If you say yes here you get support for a PPS signal generator which 11 If you say yes here you get support for a PPS signal generator which
13 utilizes STROBE pin of a parallel port to send PPS signals. It uses 12 utilizes STROBE pin of a parallel port to send PPS signals. It uses