summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>2018-11-07 14:29:53 -0500
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>2018-12-07 10:34:06 -0500
commita3bb44bcb3a06b43940576f9749020a42d31a9c0 (patch)
treeb738a79eec2d1c3640e5f1bc4c5fdb43f8ca7947
parent0511e116b8327aa7bf621d9cee35b93ffa69c85a (diff)
gpio: pch: Remove duplicate assignments
There is no need to assign the same values which core does for us anyway. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-rw-r--r--drivers/gpio/gpio-pch.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 8759f5b4b8e4..9fadda50232b 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -222,7 +222,6 @@ static void pch_gpio_setup(struct pch_gpio *chip)
222 gpio->get = pch_gpio_get; 222 gpio->get = pch_gpio_get;
223 gpio->direction_output = pch_gpio_direction_output; 223 gpio->direction_output = pch_gpio_direction_output;
224 gpio->set = pch_gpio_set; 224 gpio->set = pch_gpio_set;
225 gpio->dbg_show = NULL;
226 gpio->base = -1; 225 gpio->base = -1;
227 gpio->ngpio = gpio_pins[chip->ioh]; 226 gpio->ngpio = gpio_pins[chip->ioh];
228 gpio->can_sleep = false; 227 gpio->can_sleep = false;
@@ -389,9 +388,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
389 pci_set_drvdata(pdev, chip); 388 pci_set_drvdata(pdev, chip);
390 spin_lock_init(&chip->spinlock); 389 spin_lock_init(&chip->spinlock);
391 pch_gpio_setup(chip); 390 pch_gpio_setup(chip);
392#ifdef CONFIG_OF_GPIO 391
393 chip->gpio.of_node = pdev->dev.of_node;
394#endif
395 ret = devm_gpiochip_add_data(&pdev->dev, &chip->gpio, chip); 392 ret = devm_gpiochip_add_data(&pdev->dev, &chip->gpio, chip);
396 if (ret) { 393 if (ret) {
397 dev_err(&pdev->dev, "PCH gpio: Failed to register GPIO\n"); 394 dev_err(&pdev->dev, "PCH gpio: Failed to register GPIO\n");