summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2019-07-26 00:51:35 -0400
committerMark Brown <broonie@kernel.org>2019-08-05 11:23:25 -0400
commit9d415fbf773f162a5c274e671741c6fa94b74287 (patch)
tree102991a5c9149cf91b6647b58f34a64d0231dcc7
parenta2a341752558cc67d6fe5c8ada7c16f9c3690f89 (diff)
ASoC: soc-component: move snd_soc_component_seq_notifier()
Current soc-dapm / soc-core are using a long way round to call .seq_notifier. if (driver->seq_notifier) dapm->seq_notifier = ...; ... if (dapm->seq_notifier) ret = dapm->seq_notifier(...); We can directly call it via driver->seq_notifier. One note here is that both Card and Component have dapm, but, Card's dapm doesn't have dapm->component. We need to check it. This patch moves snd_soc_component_seq_notifier() to soc-component.c, and updates parameters. dapm->seq_notifier is no longer needed Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/87wog54d0v.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--include/sound/soc-component.h3
-rw-r--r--include/sound/soc-dapm.h2
-rw-r--r--sound/soc/soc-component.c7
-rw-r--r--sound/soc/soc-core.c10
-rw-r--r--sound/soc/soc-dapm.c15
5 files changed, 18 insertions, 19 deletions
diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
index 3ed2c39e45c2..7ac903c1e33f 100644
--- a/include/sound/soc-component.h
+++ b/include/sound/soc-component.h
@@ -281,6 +281,9 @@ int snd_soc_component_set_pll(struct snd_soc_component *component, int pll_id,
281int snd_soc_component_set_jack(struct snd_soc_component *component, 281int snd_soc_component_set_jack(struct snd_soc_component *component,
282 struct snd_soc_jack *jack, void *data); 282 struct snd_soc_jack *jack, void *data);
283 283
284void snd_soc_component_seq_notifier(struct snd_soc_component *component,
285 enum snd_soc_dapm_type type, int subseq);
286
284#ifdef CONFIG_REGMAP 287#ifdef CONFIG_REGMAP
285void snd_soc_component_init_regmap(struct snd_soc_component *component, 288void snd_soc_component_init_regmap(struct snd_soc_component *component,
286 struct regmap *regmap); 289 struct regmap *regmap);
diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index 6c6694160130..a03db6f8faa8 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -661,8 +661,6 @@ struct snd_soc_dapm_context {
661 unsigned int idle_bias_off:1; /* Use BIAS_OFF instead of STANDBY */ 661 unsigned int idle_bias_off:1; /* Use BIAS_OFF instead of STANDBY */
662 /* Go to BIAS_OFF in suspend if the DAPM context is idle */ 662 /* Go to BIAS_OFF in suspend if the DAPM context is idle */
663 unsigned int suspend_bias_off:1; 663 unsigned int suspend_bias_off:1;
664 void (*seq_notifier)(struct snd_soc_dapm_context *,
665 enum snd_soc_dapm_type, int);
666 664
667 struct device *dev; /* from parent - for debug */ 665 struct device *dev; /* from parent - for debug */
668 struct snd_soc_component *component; /* parent component */ 666 struct snd_soc_component *component; /* parent component */
diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
index de1bc5196f67..ca0b28b1d918 100644
--- a/sound/soc/soc-component.c
+++ b/sound/soc/soc-component.c
@@ -52,6 +52,13 @@ int snd_soc_component_set_pll(struct snd_soc_component *component, int pll_id,
52} 52}
53EXPORT_SYMBOL_GPL(snd_soc_component_set_pll); 53EXPORT_SYMBOL_GPL(snd_soc_component_set_pll);
54 54
55void snd_soc_component_seq_notifier(struct snd_soc_component *component,
56 enum snd_soc_dapm_type type, int subseq)
57{
58 if (component->driver->seq_notifier)
59 component->driver->seq_notifier(component, type, subseq);
60}
61
55int snd_soc_component_enable_pin(struct snd_soc_component *component, 62int snd_soc_component_enable_pin(struct snd_soc_component *component,
56 const char *pin) 63 const char *pin)
57{ 64{
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 2f068c239f34..c618fecc3d45 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2646,14 +2646,6 @@ int snd_soc_register_dai(struct snd_soc_component *component,
2646} 2646}
2647EXPORT_SYMBOL_GPL(snd_soc_register_dai); 2647EXPORT_SYMBOL_GPL(snd_soc_register_dai);
2648 2648
2649static void snd_soc_component_seq_notifier(struct snd_soc_dapm_context *dapm,
2650 enum snd_soc_dapm_type type, int subseq)
2651{
2652 struct snd_soc_component *component = dapm->component;
2653
2654 component->driver->seq_notifier(component, type, subseq);
2655}
2656
2657static int snd_soc_component_stream_event(struct snd_soc_dapm_context *dapm, 2649static int snd_soc_component_stream_event(struct snd_soc_dapm_context *dapm,
2658 int event) 2650 int event)
2659{ 2651{
@@ -2690,8 +2682,6 @@ static int snd_soc_component_initialize(struct snd_soc_component *component,
2690 dapm->bias_level = SND_SOC_BIAS_OFF; 2682 dapm->bias_level = SND_SOC_BIAS_OFF;
2691 dapm->idle_bias_off = !driver->idle_bias_on; 2683 dapm->idle_bias_off = !driver->idle_bias_on;
2692 dapm->suspend_bias_off = driver->suspend_bias_off; 2684 dapm->suspend_bias_off = driver->suspend_bias_off;
2693 if (driver->seq_notifier)
2694 dapm->seq_notifier = snd_soc_component_seq_notifier;
2695 if (driver->stream_event) 2685 if (driver->stream_event)
2696 dapm->stream_event = snd_soc_component_stream_event; 2686 dapm->stream_event = snd_soc_component_stream_event;
2697 if (driver->set_bias_level) 2687 if (driver->set_bias_level)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index d93c1038fab0..0b60f688b433 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1611,12 +1611,12 @@ static void dapm_seq_run(struct snd_soc_card *card,
1611 if (!list_empty(&pending)) 1611 if (!list_empty(&pending))
1612 dapm_seq_run_coalesced(card, &pending); 1612 dapm_seq_run_coalesced(card, &pending);
1613 1613
1614 if (cur_dapm && cur_dapm->seq_notifier) { 1614 if (cur_dapm && cur_dapm->component) {
1615 for (i = 0; i < ARRAY_SIZE(dapm_up_seq); i++) 1615 for (i = 0; i < ARRAY_SIZE(dapm_up_seq); i++)
1616 if (sort[i] == cur_sort) 1616 if (sort[i] == cur_sort)
1617 cur_dapm->seq_notifier(cur_dapm, 1617 snd_soc_component_seq_notifier(
1618 i, 1618 cur_dapm->component,
1619 cur_subseq); 1619 i, cur_subseq);
1620 } 1620 }
1621 1621
1622 if (cur_dapm && w->dapm != cur_dapm) 1622 if (cur_dapm && w->dapm != cur_dapm)
@@ -1674,11 +1674,12 @@ static void dapm_seq_run(struct snd_soc_card *card,
1674 if (!list_empty(&pending)) 1674 if (!list_empty(&pending))
1675 dapm_seq_run_coalesced(card, &pending); 1675 dapm_seq_run_coalesced(card, &pending);
1676 1676
1677 if (cur_dapm && cur_dapm->seq_notifier) { 1677 if (cur_dapm && cur_dapm->component) {
1678 for (i = 0; i < ARRAY_SIZE(dapm_up_seq); i++) 1678 for (i = 0; i < ARRAY_SIZE(dapm_up_seq); i++)
1679 if (sort[i] == cur_sort) 1679 if (sort[i] == cur_sort)
1680 cur_dapm->seq_notifier(cur_dapm, 1680 snd_soc_component_seq_notifier(
1681 i, cur_subseq); 1681 cur_dapm->component,
1682 i, cur_subseq);
1682 } 1683 }
1683 1684
1684 list_for_each_entry(d, &card->dapm_list, list) { 1685 list_for_each_entry(d, &card->dapm_list, list) {