summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexey Dobriyan <adobriyan@gmail.com>2016-12-01 20:12:58 -0500
committerDavid S. Miller <davem@davemloft.net>2016-12-03 15:59:58 -0500
commit9bfc7b9969dbb800460e2577f1dea59336269ce4 (patch)
tree2fd83542f48b3aeb62c29035f08fa8019090e8df
parent1a9a059203299ed42b984e91b87086bafeea36c6 (diff)
netns: add dummy struct inside "struct net_generic"
This is precursor to fixing "[id - 1]" bloat inside net_generic(). Name "s" is chosen to complement name "u" often used for dummy unions. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--include/net/netns/generic.h6
-rw-r--r--net/core/net_namespace.c8
2 files changed, 8 insertions, 6 deletions
diff --git a/include/net/netns/generic.h b/include/net/netns/generic.h
index d315786bcfd7..65ccce69b040 100644
--- a/include/net/netns/generic.h
+++ b/include/net/netns/generic.h
@@ -25,8 +25,10 @@
25 */ 25 */
26 26
27struct net_generic { 27struct net_generic {
28 unsigned int len; 28 struct {
29 struct rcu_head rcu; 29 unsigned int len;
30 struct rcu_head rcu;
31 } s;
30 32
31 void *ptr[0]; 33 void *ptr[0];
32}; 34};
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 707b3c25cb80..55e28a8d0604 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -50,7 +50,7 @@ static struct net_generic *net_alloc_generic(void)
50 50
51 ng = kzalloc(generic_size, GFP_KERNEL); 51 ng = kzalloc(generic_size, GFP_KERNEL);
52 if (ng) 52 if (ng)
53 ng->len = max_gen_ptrs; 53 ng->s.len = max_gen_ptrs;
54 54
55 return ng; 55 return ng;
56} 56}
@@ -64,7 +64,7 @@ static int net_assign_generic(struct net *net, unsigned int id, void *data)
64 64
65 old_ng = rcu_dereference_protected(net->gen, 65 old_ng = rcu_dereference_protected(net->gen,
66 lockdep_is_held(&net_mutex)); 66 lockdep_is_held(&net_mutex));
67 if (old_ng->len >= id) { 67 if (old_ng->s.len >= id) {
68 old_ng->ptr[id - 1] = data; 68 old_ng->ptr[id - 1] = data;
69 return 0; 69 return 0;
70 } 70 }
@@ -84,11 +84,11 @@ static int net_assign_generic(struct net *net, unsigned int id, void *data)
84 * the old copy for kfree after a grace period. 84 * the old copy for kfree after a grace period.
85 */ 85 */
86 86
87 memcpy(&ng->ptr, &old_ng->ptr, old_ng->len * sizeof(void*)); 87 memcpy(&ng->ptr, &old_ng->ptr, old_ng->s.len * sizeof(void*));
88 ng->ptr[id - 1] = data; 88 ng->ptr[id - 1] = data;
89 89
90 rcu_assign_pointer(net->gen, ng); 90 rcu_assign_pointer(net->gen, ng);
91 kfree_rcu(old_ng, rcu); 91 kfree_rcu(old_ng, s.rcu);
92 return 0; 92 return 0;
93} 93}
94 94