diff options
author | Thomas Tai <thomas.tai@oracle.com> | 2019-07-18 14:37:34 -0400 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2019-07-19 17:28:46 -0400 |
commit | 94bccc34071094c165c79b515d21b63c78f7e968 (patch) | |
tree | b78291b8c6aec65ce9f1217a23901e1ffe1dc128 | |
parent | 8bd04c57fda62e3599f654aa43b521b326a95805 (diff) |
iscsi_ibft: make ISCSI_IBFT dependson ACPI instead of ISCSI_IBFT_FIND
iscsi_ibft can use ACPI to find the iBFT entry during bootup,
currently, ISCSI_IBFT depends on ISCSI_IBFT_FIND which is
a X86 legacy way to find the iBFT by searching through the
low memory. This patch changes the dependency so that other
arch like ARM64 can use ISCSI_IBFT as long as the arch supports
ACPI.
ibft_init() needs to use the global variable ibft_addr declared
in iscsi_ibft_find.c. A #ifndef CONFIG_ISCSI_IBFT_FIND is needed
to declare the variable if CONFIG_ISCSI_IBFT_FIND is not selected.
Moving ibft_addr into the iscsi_ibft.c does not work because if
ISCSI_IBFT is selected as a module, the arch/x86/kernel/setup.c won't
be able to find the variable at compile time.
Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
-rw-r--r-- | drivers/firmware/Kconfig | 5 | ||||
-rw-r--r-- | drivers/firmware/iscsi_ibft.c | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index f754578414f0..f028218815c6 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig | |||
@@ -170,7 +170,7 @@ config DMI_SCAN_MACHINE_NON_EFI_FALLBACK | |||
170 | 170 | ||
171 | config ISCSI_IBFT_FIND | 171 | config ISCSI_IBFT_FIND |
172 | bool "iSCSI Boot Firmware Table Attributes" | 172 | bool "iSCSI Boot Firmware Table Attributes" |
173 | depends on X86 && ACPI | 173 | depends on X86 && ISCSI_IBFT |
174 | default n | 174 | default n |
175 | help | 175 | help |
176 | This option enables the kernel to find the region of memory | 176 | This option enables the kernel to find the region of memory |
@@ -181,7 +181,8 @@ config ISCSI_IBFT_FIND | |||
181 | config ISCSI_IBFT | 181 | config ISCSI_IBFT |
182 | tristate "iSCSI Boot Firmware Table Attributes module" | 182 | tristate "iSCSI Boot Firmware Table Attributes module" |
183 | select ISCSI_BOOT_SYSFS | 183 | select ISCSI_BOOT_SYSFS |
184 | depends on ISCSI_IBFT_FIND && SCSI && SCSI_LOWLEVEL | 184 | select ISCSI_IBFT_FIND if X86 |
185 | depends on ACPI && SCSI && SCSI_LOWLEVEL | ||
185 | default n | 186 | default n |
186 | help | 187 | help |
187 | This option enables support for detection and exposing of iSCSI | 188 | This option enables support for detection and exposing of iSCSI |
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index c51462f5aa1e..966aef334c42 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c | |||
@@ -93,6 +93,10 @@ MODULE_DESCRIPTION("sysfs interface to BIOS iBFT information"); | |||
93 | MODULE_LICENSE("GPL"); | 93 | MODULE_LICENSE("GPL"); |
94 | MODULE_VERSION(IBFT_ISCSI_VERSION); | 94 | MODULE_VERSION(IBFT_ISCSI_VERSION); |
95 | 95 | ||
96 | #ifndef CONFIG_ISCSI_IBFT_FIND | ||
97 | struct acpi_table_ibft *ibft_addr; | ||
98 | #endif | ||
99 | |||
96 | struct ibft_hdr { | 100 | struct ibft_hdr { |
97 | u8 id; | 101 | u8 id; |
98 | u8 version; | 102 | u8 version; |