diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2019-08-12 14:16:17 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2019-08-12 14:35:05 -0400 |
commit | 91be2587e82a0f16348fd8f12a57e4c328baffc7 (patch) | |
tree | f805f2d53b85ea4b0cfbef051ffaeea707c7aa57 | |
parent | 5785675dfef4f9edcee66edef7b3af21618d2707 (diff) |
x86/fpu/math-emu: Address fallthrough warnings
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/errors.c: In function ‘FPU_printall’:
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/errors.c:187:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
tagi = FPU_Special(r);
~~~~~^~~~~~~~~~~~~~~~
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/errors.c:188:3: note: here
case TAG_Valid:
^~~~
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/fpu_trig.c: In function ‘fyl2xp1’:
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/fpu_trig.c:1353:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (denormal_operand() < 0)
^
/home/tglx/work/kernel/linus/linux/arch/x86/math-emu/fpu_trig.c:1356:3: note: here
case TAG_Zero:
Remove the pointless 'break;' after 'continue;' while at it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r-- | arch/x86/math-emu/errors.c | 5 | ||||
-rw-r--r-- | arch/x86/math-emu/fpu_trig.c | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c index 6b468517ab71..73dc66d887f3 100644 --- a/arch/x86/math-emu/errors.c +++ b/arch/x86/math-emu/errors.c | |||
@@ -178,13 +178,15 @@ void FPU_printall(void) | |||
178 | for (i = 0; i < 8; i++) { | 178 | for (i = 0; i < 8; i++) { |
179 | FPU_REG *r = &st(i); | 179 | FPU_REG *r = &st(i); |
180 | u_char tagi = FPU_gettagi(i); | 180 | u_char tagi = FPU_gettagi(i); |
181 | |||
181 | switch (tagi) { | 182 | switch (tagi) { |
182 | case TAG_Empty: | 183 | case TAG_Empty: |
183 | continue; | 184 | continue; |
184 | break; | ||
185 | case TAG_Zero: | 185 | case TAG_Zero: |
186 | case TAG_Special: | 186 | case TAG_Special: |
187 | /* Update tagi for the printk below */ | ||
187 | tagi = FPU_Special(r); | 188 | tagi = FPU_Special(r); |
189 | /* fall through */ | ||
188 | case TAG_Valid: | 190 | case TAG_Valid: |
189 | printk("st(%d) %c .%04lx %04lx %04lx %04lx e%+-6d ", i, | 191 | printk("st(%d) %c .%04lx %04lx %04lx %04lx e%+-6d ", i, |
190 | getsign(r) ? '-' : '+', | 192 | getsign(r) ? '-' : '+', |
@@ -198,7 +200,6 @@ void FPU_printall(void) | |||
198 | printk("Whoops! Error in errors.c: tag%d is %d ", i, | 200 | printk("Whoops! Error in errors.c: tag%d is %d ", i, |
199 | tagi); | 201 | tagi); |
200 | continue; | 202 | continue; |
201 | break; | ||
202 | } | 203 | } |
203 | printk("%s\n", tag_desc[(int)(unsigned)tagi]); | 204 | printk("%s\n", tag_desc[(int)(unsigned)tagi]); |
204 | } | 205 | } |
diff --git a/arch/x86/math-emu/fpu_trig.c b/arch/x86/math-emu/fpu_trig.c index 783c509f957a..127ea54122d7 100644 --- a/arch/x86/math-emu/fpu_trig.c +++ b/arch/x86/math-emu/fpu_trig.c | |||
@@ -1352,7 +1352,7 @@ static void fyl2xp1(FPU_REG *st0_ptr, u_char st0_tag) | |||
1352 | case TW_Denormal: | 1352 | case TW_Denormal: |
1353 | if (denormal_operand() < 0) | 1353 | if (denormal_operand() < 0) |
1354 | return; | 1354 | return; |
1355 | 1355 | /* fall through */ | |
1356 | case TAG_Zero: | 1356 | case TAG_Zero: |
1357 | case TAG_Valid: | 1357 | case TAG_Valid: |
1358 | setsign(st0_ptr, getsign(st0_ptr) ^ getsign(st1_ptr)); | 1358 | setsign(st0_ptr, getsign(st0_ptr) ^ getsign(st1_ptr)); |