diff options
author | Xin Long <lucien.xin@gmail.com> | 2018-08-27 06:40:18 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-08-27 18:13:17 -0400 |
commit | 834539e69a5fe2aab33cc777ccfd4a4fcc5b9770 (patch) | |
tree | 73f9c5e068b36bd6d430dc320c7e3879c8d42bb4 | |
parent | bab1be79a5169ac748d8292b20c86d874022d7ba (diff) |
sctp: remove useless start_fail from sctp_ht_iter in proc
After changing rhashtable_walk_start to return void, start_fail would
never be set other value than 0, and the checking for start_fail is
pointless, so remove it.
Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/sctp/proc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sctp/proc.c b/net/sctp/proc.c index 4d6f1c8d6659..a644292f9faf 100644 --- a/net/sctp/proc.c +++ b/net/sctp/proc.c | |||
@@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = { | |||
215 | struct sctp_ht_iter { | 215 | struct sctp_ht_iter { |
216 | struct seq_net_private p; | 216 | struct seq_net_private p; |
217 | struct rhashtable_iter hti; | 217 | struct rhashtable_iter hti; |
218 | int start_fail; | ||
219 | }; | 218 | }; |
220 | 219 | ||
221 | static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos) | 220 | static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos) |
@@ -224,7 +223,6 @@ static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos) | |||
224 | 223 | ||
225 | sctp_transport_walk_start(&iter->hti); | 224 | sctp_transport_walk_start(&iter->hti); |
226 | 225 | ||
227 | iter->start_fail = 0; | ||
228 | return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos); | 226 | return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos); |
229 | } | 227 | } |
230 | 228 | ||
@@ -232,8 +230,6 @@ static void sctp_transport_seq_stop(struct seq_file *seq, void *v) | |||
232 | { | 230 | { |
233 | struct sctp_ht_iter *iter = seq->private; | 231 | struct sctp_ht_iter *iter = seq->private; |
234 | 232 | ||
235 | if (iter->start_fail) | ||
236 | return; | ||
237 | sctp_transport_walk_stop(&iter->hti); | 233 | sctp_transport_walk_stop(&iter->hti); |
238 | } | 234 | } |
239 | 235 | ||