summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2019-03-02 11:13:11 -0500
committerDavid S. Miller <davem@davemloft.net>2019-03-04 00:47:57 -0500
commit7be3ad848f77eba893bd08b97e7383e8d5e873ac (patch)
tree5a01c7bc9878996169117e00bb18e78c7ce0a1f9
parentd81210c25e17b5cca71138f3990ed8071d510ba9 (diff)
net: phy: remove gen10g_no_soft_reset
genphy_no_soft_reset and gen10g_no_soft_reset are both the same no-ops, one is enough. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/phy/cortina.c2
-rw-r--r--drivers/net/phy/marvell10g.c4
-rw-r--r--drivers/net/phy/phy-c45.c9
-rw-r--r--drivers/net/phy/teranetics.c2
-rw-r--r--include/linux/phy.h1
5 files changed, 5 insertions, 13 deletions
diff --git a/drivers/net/phy/cortina.c b/drivers/net/phy/cortina.c
index a64eb211cc56..856cdc36aacd 100644
--- a/drivers/net/phy/cortina.c
+++ b/drivers/net/phy/cortina.c
@@ -82,7 +82,7 @@ static struct phy_driver cortina_driver[] = {
82 .features = PHY_10GBIT_FEATURES, 82 .features = PHY_10GBIT_FEATURES,
83 .config_aneg = gen10g_config_aneg, 83 .config_aneg = gen10g_config_aneg,
84 .read_status = cortina_read_status, 84 .read_status = cortina_read_status,
85 .soft_reset = gen10g_no_soft_reset, 85 .soft_reset = genphy_no_soft_reset,
86 .probe = cortina_probe, 86 .probe = cortina_probe,
87}, 87},
88}; 88};
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index 79106e70010f..100b401b1f4a 100644
--- a/drivers/net/phy/marvell10g.c
+++ b/drivers/net/phy/marvell10g.c
@@ -459,7 +459,7 @@ static struct phy_driver mv3310_drivers[] = {
459 .phy_id_mask = MARVELL_PHY_ID_MASK, 459 .phy_id_mask = MARVELL_PHY_ID_MASK,
460 .name = "mv88x3310", 460 .name = "mv88x3310",
461 .get_features = mv3310_get_features, 461 .get_features = mv3310_get_features,
462 .soft_reset = gen10g_no_soft_reset, 462 .soft_reset = genphy_no_soft_reset,
463 .config_init = mv3310_config_init, 463 .config_init = mv3310_config_init,
464 .probe = mv3310_probe, 464 .probe = mv3310_probe,
465 .suspend = mv3310_suspend, 465 .suspend = mv3310_suspend,
@@ -474,7 +474,7 @@ static struct phy_driver mv3310_drivers[] = {
474 .name = "mv88x2110", 474 .name = "mv88x2110",
475 .get_features = genphy_c45_pma_read_abilities, 475 .get_features = genphy_c45_pma_read_abilities,
476 .probe = mv3310_probe, 476 .probe = mv3310_probe,
477 .soft_reset = gen10g_no_soft_reset, 477 .soft_reset = genphy_no_soft_reset,
478 .config_init = mv3310_config_init, 478 .config_init = mv3310_config_init,
479 .config_aneg = mv3310_config_aneg, 479 .config_aneg = mv3310_config_aneg,
480 .aneg_done = mv3310_aneg_done, 480 .aneg_done = mv3310_aneg_done,
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index 6cd4bd5e9e43..c596eb54e4ac 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -508,18 +508,11 @@ static int gen10g_read_status(struct phy_device *phydev)
508 return genphy_c45_read_link(phydev); 508 return genphy_c45_read_link(phydev);
509} 509}
510 510
511int gen10g_no_soft_reset(struct phy_device *phydev)
512{
513 /* Do nothing for now */
514 return 0;
515}
516EXPORT_SYMBOL_GPL(gen10g_no_soft_reset);
517
518struct phy_driver genphy_10g_driver = { 511struct phy_driver genphy_10g_driver = {
519 .phy_id = 0xffffffff, 512 .phy_id = 0xffffffff,
520 .phy_id_mask = 0xffffffff, 513 .phy_id_mask = 0xffffffff,
521 .name = "Generic 10G PHY", 514 .name = "Generic 10G PHY",
522 .soft_reset = gen10g_no_soft_reset, 515 .soft_reset = genphy_no_soft_reset,
523 .features = PHY_10GBIT_FEATURES, 516 .features = PHY_10GBIT_FEATURES,
524 .config_aneg = gen10g_config_aneg, 517 .config_aneg = gen10g_config_aneg,
525 .read_status = gen10g_read_status, 518 .read_status = gen10g_read_status,
diff --git a/drivers/net/phy/teranetics.c b/drivers/net/phy/teranetics.c
index 95280212d5d5..beb054b931ee 100644
--- a/drivers/net/phy/teranetics.c
+++ b/drivers/net/phy/teranetics.c
@@ -78,7 +78,7 @@ static struct phy_driver teranetics_driver[] = {
78 .phy_id_mask = 0xffffffff, 78 .phy_id_mask = 0xffffffff,
79 .name = "Teranetics TN2020", 79 .name = "Teranetics TN2020",
80 .features = PHY_10GBIT_FEATURES, 80 .features = PHY_10GBIT_FEATURES,
81 .soft_reset = gen10g_no_soft_reset, 81 .soft_reset = genphy_no_soft_reset,
82 .aneg_done = teranetics_aneg_done, 82 .aneg_done = teranetics_aneg_done,
83 .config_aneg = gen10g_config_aneg, 83 .config_aneg = gen10g_config_aneg,
84 .read_status = teranetics_read_status, 84 .read_status = teranetics_read_status,
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 60794240141f..34084892a466 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1119,7 +1119,6 @@ int genphy_c45_read_status(struct phy_device *phydev);
1119 1119
1120/* The gen10g_* functions are the old Clause 45 stub */ 1120/* The gen10g_* functions are the old Clause 45 stub */
1121int gen10g_config_aneg(struct phy_device *phydev); 1121int gen10g_config_aneg(struct phy_device *phydev);
1122int gen10g_no_soft_reset(struct phy_device *phydev);
1123 1122
1124static inline int phy_read_status(struct phy_device *phydev) 1123static inline int phy_read_status(struct phy_device *phydev)
1125{ 1124{