summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEzequiel Garcia <ezequiel@collabora.com>2019-08-16 12:01:23 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-08-19 12:16:08 -0400
commit7bb3c32abd7bafd346f667cccb7dfe9686f14ddd (patch)
treee0ef6087e7b48a26f0482dfa1a2051ce92c61dc5
parent4333fb96ca1086d1cec0f93f78c453aa2dee8a5c (diff)
media: uapi: h264: Rename pixel format
The V4L2_PIX_FMT_H264_SLICE_RAW name was originally suggested because the pixel format would represent H264 slices without any start code. However, as we will now introduce a start code menu control, give the pixel format a more meaningful name, while it's still early enough to do so. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> Tested-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
-rw-r--r--Documentation/media/uapi/v4l/pixfmt-compressed.rst4
-rw-r--r--drivers/media/v4l2-core/v4l2-ioctl.c2
-rw-r--r--drivers/staging/media/sunxi/cedrus/cedrus_dec.c2
-rw-r--r--drivers/staging/media/sunxi/cedrus/cedrus_video.c6
-rw-r--r--include/media/h264-ctrls.h2
5 files changed, 8 insertions, 8 deletions
diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst b/Documentation/media/uapi/v4l/pixfmt-compressed.rst
index f52a7b67023d..9b65473a2288 100644
--- a/Documentation/media/uapi/v4l/pixfmt-compressed.rst
+++ b/Documentation/media/uapi/v4l/pixfmt-compressed.rst
@@ -52,9 +52,9 @@ Compressed Formats
52 - ``V4L2_PIX_FMT_H264_MVC`` 52 - ``V4L2_PIX_FMT_H264_MVC``
53 - 'M264' 53 - 'M264'
54 - H264 MVC video elementary stream. 54 - H264 MVC video elementary stream.
55 * .. _V4L2-PIX-FMT-H264-SLICE-RAW: 55 * .. _V4L2-PIX-FMT-H264-SLICE:
56 56
57 - ``V4L2_PIX_FMT_H264_SLICE_RAW`` 57 - ``V4L2_PIX_FMT_H264_SLICE``
58 - 'S264' 58 - 'S264'
59 - H264 parsed slice data, without the start code and as 59 - H264 parsed slice data, without the start code and as
60 extracted from the H264 bitstream. This format is adapted for 60 extracted from the H264 bitstream. This format is adapted for
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index bb5b4926538a..39f10621c91b 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1343,7 +1343,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
1343 case V4L2_PIX_FMT_H264: descr = "H.264"; break; 1343 case V4L2_PIX_FMT_H264: descr = "H.264"; break;
1344 case V4L2_PIX_FMT_H264_NO_SC: descr = "H.264 (No Start Codes)"; break; 1344 case V4L2_PIX_FMT_H264_NO_SC: descr = "H.264 (No Start Codes)"; break;
1345 case V4L2_PIX_FMT_H264_MVC: descr = "H.264 MVC"; break; 1345 case V4L2_PIX_FMT_H264_MVC: descr = "H.264 MVC"; break;
1346 case V4L2_PIX_FMT_H264_SLICE_RAW: descr = "H.264 Parsed Slice Data"; break; 1346 case V4L2_PIX_FMT_H264_SLICE: descr = "H.264 Parsed Slice Data"; break;
1347 case V4L2_PIX_FMT_H263: descr = "H.263"; break; 1347 case V4L2_PIX_FMT_H263: descr = "H.263"; break;
1348 case V4L2_PIX_FMT_MPEG1: descr = "MPEG-1 ES"; break; 1348 case V4L2_PIX_FMT_MPEG1: descr = "MPEG-1 ES"; break;
1349 case V4L2_PIX_FMT_MPEG2: descr = "MPEG-2 ES"; break; 1349 case V4L2_PIX_FMT_MPEG2: descr = "MPEG-2 ES"; break;
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_dec.c b/drivers/staging/media/sunxi/cedrus/cedrus_dec.c
index bdad87eb9d79..56ca4c9ad01c 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus_dec.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_dec.c
@@ -46,7 +46,7 @@ void cedrus_device_run(void *priv)
46 V4L2_CID_MPEG_VIDEO_MPEG2_QUANTIZATION); 46 V4L2_CID_MPEG_VIDEO_MPEG2_QUANTIZATION);
47 break; 47 break;
48 48
49 case V4L2_PIX_FMT_H264_SLICE_RAW: 49 case V4L2_PIX_FMT_H264_SLICE:
50 run.h264.decode_params = cedrus_find_control_data(ctx, 50 run.h264.decode_params = cedrus_find_control_data(ctx,
51 V4L2_CID_MPEG_VIDEO_H264_DECODE_PARAMS); 51 V4L2_CID_MPEG_VIDEO_H264_DECODE_PARAMS);
52 run.h264.pps = cedrus_find_control_data(ctx, 52 run.h264.pps = cedrus_find_control_data(ctx,
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
index 681dfe3367a6..eeee3efd247b 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
@@ -38,7 +38,7 @@ static struct cedrus_format cedrus_formats[] = {
38 .directions = CEDRUS_DECODE_SRC, 38 .directions = CEDRUS_DECODE_SRC,
39 }, 39 },
40 { 40 {
41 .pixelformat = V4L2_PIX_FMT_H264_SLICE_RAW, 41 .pixelformat = V4L2_PIX_FMT_H264_SLICE,
42 .directions = CEDRUS_DECODE_SRC, 42 .directions = CEDRUS_DECODE_SRC,
43 }, 43 },
44 { 44 {
@@ -104,7 +104,7 @@ static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt)
104 104
105 switch (pix_fmt->pixelformat) { 105 switch (pix_fmt->pixelformat) {
106 case V4L2_PIX_FMT_MPEG2_SLICE: 106 case V4L2_PIX_FMT_MPEG2_SLICE:
107 case V4L2_PIX_FMT_H264_SLICE_RAW: 107 case V4L2_PIX_FMT_H264_SLICE:
108 /* Zero bytes per line for encoded source. */ 108 /* Zero bytes per line for encoded source. */
109 bytesperline = 0; 109 bytesperline = 0;
110 110
@@ -449,7 +449,7 @@ static int cedrus_start_streaming(struct vb2_queue *vq, unsigned int count)
449 ctx->current_codec = CEDRUS_CODEC_MPEG2; 449 ctx->current_codec = CEDRUS_CODEC_MPEG2;
450 break; 450 break;
451 451
452 case V4L2_PIX_FMT_H264_SLICE_RAW: 452 case V4L2_PIX_FMT_H264_SLICE:
453 ctx->current_codec = CEDRUS_CODEC_H264; 453 ctx->current_codec = CEDRUS_CODEC_H264;
454 break; 454 break;
455 455
diff --git a/include/media/h264-ctrls.h b/include/media/h264-ctrls.h
index e1404d78d6ff..6160a69c0143 100644
--- a/include/media/h264-ctrls.h
+++ b/include/media/h264-ctrls.h
@@ -14,7 +14,7 @@
14#include <linux/videodev2.h> 14#include <linux/videodev2.h>
15 15
16/* Our pixel format isn't stable at the moment */ 16/* Our pixel format isn't stable at the moment */
17#define V4L2_PIX_FMT_H264_SLICE_RAW v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */ 17#define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */
18 18
19/* 19/*
20 * This is put insanely high to avoid conflicting with controls that 20 * This is put insanely high to avoid conflicting with controls that