summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2019-06-09 11:09:53 -0400
committerLinus Walleij <linus.walleij@linaro.org>2019-06-12 03:10:54 -0400
commit78b99577b3934e3e787fe0c52aa1b59442c8bbb5 (patch)
tree4c7bd48ac2cd30bc85e7268f9cb2c7edda6160c7
parent6cadafb310866b95f1ca956eaebbe3076adc0886 (diff)
pinctrl: remove unused pin_is_valid()
This function was used by pin_request() to pointlessly double-check the pin validity, and it was the only user ever. Since commit d2f6a1c6fb0e ("pinctrl: remove double pin validity check."), no one has ever used it. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/pinctrl/core.c23
-rw-r--r--include/linux/pinctrl/pinctrl.h10
2 files changed, 0 insertions, 33 deletions
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 04787eefe2a2..e745788fa36f 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -178,29 +178,6 @@ const char *pin_get_name(struct pinctrl_dev *pctldev, const unsigned pin)
178 return desc->name; 178 return desc->name;
179} 179}
180 180
181/**
182 * pin_is_valid() - check if pin exists on controller
183 * @pctldev: the pin control device to check the pin on
184 * @pin: pin to check, use the local pin controller index number
185 *
186 * This tells us whether a certain pin exist on a certain pin controller or
187 * not. Pin lists may be sparse, so some pins may not exist.
188 */
189bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)
190{
191 struct pin_desc *pindesc;
192
193 if (pin < 0)
194 return false;
195
196 mutex_lock(&pctldev->mutex);
197 pindesc = pin_desc_get(pctldev, pin);
198 mutex_unlock(&pctldev->mutex);
199
200 return pindesc != NULL;
201}
202EXPORT_SYMBOL_GPL(pin_is_valid);
203
204/* Deletes a range of pin descriptors */ 181/* Deletes a range of pin descriptors */
205static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev, 182static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev,
206 const struct pinctrl_pin_desc *pins, 183 const struct pinctrl_pin_desc *pins,
diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
index 2744113f1024..36a79fe7b84f 100644
--- a/include/linux/pinctrl/pinctrl.h
+++ b/include/linux/pinctrl/pinctrl.h
@@ -172,7 +172,6 @@ extern struct pinctrl_dev *devm_pinctrl_register(struct device *dev,
172extern void devm_pinctrl_unregister(struct device *dev, 172extern void devm_pinctrl_unregister(struct device *dev,
173 struct pinctrl_dev *pctldev); 173 struct pinctrl_dev *pctldev);
174 174
175extern bool pin_is_valid(struct pinctrl_dev *pctldev, int pin);
176extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev, 175extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,
177 struct pinctrl_gpio_range *range); 176 struct pinctrl_gpio_range *range);
178extern void pinctrl_add_gpio_ranges(struct pinctrl_dev *pctldev, 177extern void pinctrl_add_gpio_ranges(struct pinctrl_dev *pctldev,
@@ -203,15 +202,6 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
203extern const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev); 202extern const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev);
204extern const char *pinctrl_dev_get_devname(struct pinctrl_dev *pctldev); 203extern const char *pinctrl_dev_get_devname(struct pinctrl_dev *pctldev);
205extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev); 204extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev);
206#else
207
208struct pinctrl_dev;
209
210/* Sufficiently stupid default functions when pinctrl is not in use */
211static inline bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)
212{
213 return pin >= 0;
214}
215 205
216#endif /* !CONFIG_PINCTRL */ 206#endif /* !CONFIG_PINCTRL */
217 207