diff options
author | Denis Efremov <efremov@linux.com> | 2019-09-25 19:49:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-09-26 13:10:30 -0400 |
commit | 7159d54418e0a1a3df91e74501363a1c05379517 (patch) | |
tree | d653219453f5d7d4fd59e1f23e6579777af0bde6 | |
parent | 89f403541325181748b491fd96118e68292f47e1 (diff) |
fs: remove unlikely() from WARN_ON() condition
"unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely()
internally.
Link: http://lkml.kernel.org/r/20190829165025.15750-5-efremov@linux.com
Signed-off-by: Denis Efremov <efremov@linux.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | fs/open.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -776,7 +776,7 @@ static int do_dentry_open(struct file *f, | |||
776 | f->f_mode |= FMODE_ATOMIC_POS; | 776 | f->f_mode |= FMODE_ATOMIC_POS; |
777 | 777 | ||
778 | f->f_op = fops_get(inode->i_fop); | 778 | f->f_op = fops_get(inode->i_fop); |
779 | if (unlikely(WARN_ON(!f->f_op))) { | 779 | if (WARN_ON(!f->f_op)) { |
780 | error = -ENODEV; | 780 | error = -ENODEV; |
781 | goto cleanup_all; | 781 | goto cleanup_all; |
782 | } | 782 | } |